Files
alan a1c4c1c402 feat(app): icon-only tab bars, Settings from the Pipelines bar, main bar bottom right with detail bars above it
Settings leaves the tab bar (Pipelines, Runs, Chat, Search) and opens as a
page from a gear in the Pipelines bar, keeping /settings, its keys and a Back
to Pipelines (also the system Back). Every floating tab bar shows icons only,
named for assistive technology. On wide windows the shell's tab bar stays at
the bottom right; a split detail learns its height plus a 12px gap, so its
tabs or the chat composer float above it, and pages the detail opens (the
stage page) stay in its pane through its own navigator.
2026-10-31 14:57:56 +00:00

7.5 KiB
Raw Permalink Blame History

Tab bars v2 (operator feedback)

Follows notes/floating-tab-bars.md and notes/wide-shell-fixes.md. Where they disagree, this note wins: the shell's tab bar no longer stays over the list pane.

1. Settings is a page, not a tab

  • shellTabDestinations (lib/shell/destination.dart) is the tab bar: Pipelines, Runs, Chat, Search. AppDestination.settings still exists, so the shell can show it. The /settings route, deep link, SettingsScreen and its keys are unchanged, and Templates and Schedules still open above it.
  • Pipelines bar: there is a gear action after Refresh (key pipelines-open-settings, PipelinesScreen.onOpenSettings / PipelinesDestination.onOpenSettings). It is shown while the list is visible. The Schedules and Settings buttons live in features/pipelines/widgets/pipeline_bar_buttons.dart.
  • While Settings is shown, the shell keeps Pipelines selected in the tab bar (shellTabFor), so Settings reads as a page of Pipelines.
    • The top bar gets a Back button (shell.back) and no Search action.
    • The system Back (PopScope around the shell, present at all times so nothing remounts) also returns to Pipelines, instead of leaving the app.
    • Tapping the Pipelines tab returns to Pipelines as well.

2. Icons only

FloatingDestinationBar no longer draws labels.

  • Material uses NavigationDestinationLabelBehavior.alwaysHide. The label is still the tab's semantics label and its tooltip.
  • Cupertino draws the icon alone, inside Semantics(label:). It has no tooltip, because a tooltip would be a Material widget.
  • Selected state, "tab n of m", badges and every test key are unchanged.
  • Sizes:
    • Pill height is 56 for Material and 50 for Cupertino.
    • On a wide window each tab is 72 wide (Material) or 64 (Cupertino), so the pill no longer depends on text scale.
  • Icons changed so that no detail tab repeats a shell tab it can float above:
    • Pipeline Graph: Icons.hub_outlined / CupertinoIcons.flowchart. The old icon was the Pipelines tab's.
    • Stage Session (Cupertino): CupertinoIcons.text_bubble. The old icon was the Chat tab's.

3–4. Main bar bottom right; detail bars above it

  • The shell no longer wraps its bottom bar in ListPaneWidth. The bar gets the full window width, so at 600 and wider it is compact at the bottom right, whether the list is split or not.
  • In ListDetailPanes (split, under a shell):
    • Detail pane: its bottom padding is the shell bar's height (the shell's own bottom padding) plus kStackedBarGap (12). As a result:
      • The item's floating tabs sit 12 above the main pill, trailing-aligned.
      • The chat composer's box starts 12 above the pill, and its pill adds another 12 inside.
      • Content clears both bars.
    • Top inset: this is still ShellSystemInsets (status bar).
    • List pane: gets only the system bottom inset. The bar never covers the list, because the detail is at least half the window and wider than the pill.
  • DetailPaneNavigator (lib/shell/detail_pane_navigator.dart):
    • The split detail now has its own Navigator. The item is its first page, under a fixed key, so it updates in place.
    • Pages the item pushes (the stage page from the timeline, artifact/diff viewers, the expanded graph) open inside the pane. The list and the main bar stay visible, and the stage page's tabs float above the main bar like the run tabs do.
    • NavigatorPopHandler makes the system Back pop such a page first.
    • Dialogs still use the root navigator.
  • Phones are unchanged. A detail is a pushed full-screen page, with its tabs at the bottom and no shell bar.

5. Kept

  • ShellSystemInsets, the status-bar inset in the split detail.
  • Content scrolling behind both bars.
  • No remount when the width changes. The shell's scaffold structure, the PopScope and the bar do not depend on width or split.
  • The Cupertino bar still builds no Material widget.
  • 320px at 2x text: the existing tests pass, and icon tabs do not scale.

Tests

Full suite: 2233 passed (flutter test); flutter analyze clean; flutter build web OK.

New:

  • test/application/settings_page_test.dart, on both hosts at 390 and 1200:
    • The gear opens /settings.
    • Settings shows Back and has no Search, and Pipelines stays selected.
    • Back returns to /pipelines.
    • The tab bar labels are exactly Pipelines/Runs/Chat/Search.
    • The /settings deep link opens Settings, and the system Back is handled and returns to Pipelines.
  • test/shell/split_detail_pages_test.dart: the real run detail in a 1200 split under the shell, on both hosts.
    • The run tabs are trailing-aligned and sit 12 above the main pill, which keeps the bottom right.
    • The stage page opens inside the pane: the root navigator cannot pop and the list stays visible. Its tabs are 12 above the main pill, with no overlap.
    • The stage page's Back returns to the run.
  • test/ui/adaptive/icon_only_tab_bars_test.dart, covering the run detail, stage page and pipeline detail bars on both hosts:
    • No label is drawn (Cupertino has no Text; Material uses alwaysHide).
    • Each tab's semantics label starts with its name, and the selected state is correct.
    • The icons are distinct, and no detail icon equals a shell tab icon.
  • test/shell/split_destination_bar_test.dart (rewritten), at 1200 and 1600 on both hosts:
    • The main pill is at the bottom right, over the detail, never the list.
    • The composer box is 12 above it.
    • Detail tabs are 12 above it, no overlap, and the item list clears both.
    • The list pane pads only the system inset.
    • At 600 and 840 split with 2x text, there is no overflow.

Updated for the intentional changes:

  • shell_bar_test: Search is the fourth tab and Settings is not a tab.
  • floating_tab_bar_test: the wide pill is exactly 4 tab widths, and the semantics test uses tab keys and the label.
  • split_status_bar_test: a 24px bottom inset; the item tabs sit 12 above the main pill, which is at 800 − 24.
  • pane_bar_row_test: the item tabs are above the main pill.
  • attention_badge_test: tabs are tapped by key.
  • Tests that tapped tab label text now tap tab keys:
    • Pipeline tests use pipeline-detail-tab-*.
    • App tests use shell.destination.*; Settings is opened by pipelines-open-settings.
    • Run detail tests use run-detail-tab-*.
  • list_detail_consistency_test and chat_list_detail_test use the root navigator (find.byType(Navigator).first), because the split pane now has its own.

Evidence

/tmp/tabs-v2-evidence/ holds 84 PNGs taken with headless Chrome, using /tmp/app-style-review-r2/shoot.mjs over a web build of tool/app_host_probe_entry.dart (build/tabs2-app_host). The specs are in scripts/.

  • Runs fixture (wave2-e, RICH=1): {m,c}-{runs,run1,stage,thread}-{560,1200,1600}-{light,dark}.
  • Pipelines fixture (pipelines_wiring_probe_server): {m,c}-{plist,pdetail}-….
  • Settings opened by clicking the gear: {m,c}-settings-via-bar-….

What the captures show:

  • At 1200 and 1600:
    • The main pill is at the bottom right.
    • The run, stage and pipeline tabs sit above it with a visible gap.
    • The chat composer sits above it.
    • The stage page opens in the detail pane, beside the list.
  • At 560 the bars are full width and icon-only.
  • Settings shows Back, with Pipelines selected.

Known gaps:

  • There was no device run, so the Android and iOS hardware Back for the Settings page and the in-pane pages are covered by widget tests only.
  • Headless Chrome has no status bar, so the status-bar inset is again covered by tests only.