package transfer import ( "archive/zip" "bytes" "encoding/json" "os" "path/filepath" "testing" ) func TestBundleRoundTripAndNoOverwrite(t *testing.T) { file := filepath.Join(t.TempDir(), "export.zip") entries := []Entry{{Name: "Research / notes", Version: 3, Source: "definition one\n"}, {Name: "第二", Version: 1, Source: "definition two\n"}} if err := Write(file, entries); err != nil { t.Fatal(err) } got, err := Read(file) if err != nil { t.Fatal(err) } if len(got) != 2 { t.Fatal(got) } for i, e := range got { if e.Name != entries[i].Name || e.Version != entries[i].Version || e.Source != entries[i].Source { t.Fatal(e) } } before, _ := os.ReadFile(file) if err = Write(file, entries); err == nil { t.Fatal("overwrote archive") } after, _ := os.ReadFile(file) if !bytes.Equal(before, after) { t.Fatal("existing archive changed") } info, _ := os.Stat(file) if info.Mode().Perm() != 0600 { t.Fatal("unsafe archive permissions", info.Mode()) } } func TestBundleRejectsMalformedAndTamperedEntries(t *testing.T) { for _, kind := range []string{"checksum", "traversal", "duplicate", "unknown", "format", "oversize", "names"} { t.Run(kind, func(t *testing.T) { file := filepath.Join(t.TempDir(), "bad.zip") m := Manifest{Format: "pipelines-definitions", Version: 1, Pipelines: []Entry{{Name: "one", Version: 1, File: "pipelines/0001.md", SHA256: digest("source")}}} payload := "source" if kind == "checksum" { payload = "changed" } if kind == "traversal" { m.Pipelines[0].File = "../evil.md" } if kind == "format" { m.Version = 2 } if kind == "oversize" { payload = string(make([]byte, maxSource+1)) } if kind == "names" { m.Pipelines[0].Name = " one " } var buf bytes.Buffer w := zip.NewWriter(&buf) data, _ := json.Marshal(m) f, _ := w.Create("manifest.json") f.Write(data) f, _ = w.Create(m.Pipelines[0].File) f.Write([]byte(payload)) if kind == "duplicate" { f, _ = w.Create("manifest.json") f.Write(data) } if kind == "unknown" { f, _ = w.Create("extra") f.Write([]byte("x")) } w.Close() os.WriteFile(file, buf.Bytes(), 0600) if _, err := Read(file); err == nil { t.Fatal("unsafe bundle accepted", kind) } }) } }