package protocol import ( "encoding/json" "strings" "testing" ) func TestRunStepArtifactsRoundTrip(t *testing.T) { step := RunStep{ Sequence: 2, Stage: "review", Artifacts: []StageArtifact{{ Name: "captures/shot.png", SizeBytes: 1234, ContentType: "image/png", URL: "/artifacts/9/2/captures/shot.png", }}, ArtifactsSkipped: 1, ArtifactsTruncated: 3, } encoded, err := json.Marshal(step) if err != nil { t.Fatal(err) } var decoded RunStep if err := json.Unmarshal(encoded, &decoded); err != nil { t.Fatal(err) } if len(decoded.Artifacts) != 1 || decoded.Artifacts[0] != step.Artifacts[0] { t.Fatalf("artifacts lost in round trip: %+v", decoded.Artifacts) } if decoded.ArtifactsSkipped != 1 || decoded.ArtifactsTruncated != 3 { t.Fatalf("counters lost in round trip: %+v", decoded) } } func TestRunStepOmitsAbsentArtifacts(t *testing.T) { encoded, err := json.Marshal(RunStep{Sequence: 1, Stage: "one"}) if err != nil { t.Fatal(err) } if strings.Contains(string(encoded), "artifacts") { t.Fatalf("empty artifacts must be omitted: %s", encoded) } var decoded RunStep if err := json.Unmarshal([]byte(`{"sequence":1}`), &decoded); err != nil { t.Fatal(err) } if decoded.Artifacts != nil || decoded.ArtifactsSkipped != 0 || decoded.ArtifactsTruncated != 0 { t.Fatalf("absent field must decode empty: %+v", decoded) } } func TestPresentedArtifactsHidesRetiredSessionMarkdown(t *testing.T) { step := RunStep{Artifacts: []StageArtifact{ {Name: "session.md", URL: "/artifacts/344/1/session.md"}, {Name: "session.html", URL: "/artifacts/344/1/session.html"}, {Name: "shot.png", URL: "/artifacts/344/1/shot.png"}, }} presented := step.PresentedArtifacts() if len(presented) != 2 || presented[0].Name != "session.html" || presented[1].Name != "shot.png" { t.Fatalf("presented = %+v", presented) } if len(step.Artifacts) != 3 { t.Fatalf("PresentedArtifacts mutated the stored record: %+v", step.Artifacts) } if got := (RunStep{}).PresentedArtifacts(); got != nil { t.Fatalf("empty step presented %+v, want nil", got) } onlyLegacy := RunStep{Artifacts: []StageArtifact{{Name: LegacySessionMarkdownArtifact}}} if got := onlyLegacy.PresentedArtifacts(); got != nil { t.Fatalf("legacy-only step presented %+v, want nil", got) } }