Commit Graph

4 Commits

Author SHA1 Message Date
alan 8d2ca95057 Open Search artifact hits in the viewer over the run's Artifacts tab
On a phone-width window the open run is its own page pushed on the app
navigator, so RunDetailTabs was not a descendant of the shell's
RunSearchSelectionScope (which wraps only the Runs tab body). The field or
artifact selection was never seen and the run opened at its plain Summary.
The previous widget tests injected the scope directly above RunDetailView at
900 px, where the detail is an inline pane, so they could not catch it.

- RunsScreen relays the shell's search scope into the detail it builds, so
  the pushed page sees the selection too (also fixes field hits on phones).
- An artifact hit now opens the run's Artifacts tab and the gallery opens
  that artifact exactly as a tap there does: selected, scrolled into view
  (ArtifactVisitReveal) and in the viewer. Back returns to the tab with the
  artifact highlighted. An unknown URL leaves the tab open with the existing
  "That artifact is no longer available." notice.
- New test/application/search_artifact_open_test.dart drives the real Search
  tab -> typed query -> result tap -> run read -> viewer on a 390x844 phone,
  Material and Cupertino; it fails without the scope relay.
2026-11-02 18:39:43 +00:00
alan 41492df436 WIP: search artifact hit opens the viewer (run #231) 2026-11-02 00:35:23 +00:00
alan 2d1cd743ee fix(app): keep a search selection one-shot and always reach Summary
A retired or unknown field hit now selects the plain Summary instead of
leaving an open visit pane in place, matching the browser's searchFieldTab
and Android. The resolved target is a sealed Summary/visit value, so the
field mapping lives in one place.

An unapplied request is dropped when the shell leaves the run it names, so
Backing out of a loading detail no longer replays the selection on a later,
unrelated visit. Search/Templates/Schedules pages above the run keep it.
2026-10-22 16:03:18 +01:00
alan 133df9301d feat(app): select a search hit's recorded run section or visit 2026-10-22 15:35:19 +01:00