Commit Graph

162 Commits

Author SHA1 Message Date
alan b771f3813a Remove Cupertino remnants from runs and pipelines
Keep the assigned runs and pipelines UI Material-only by removing alternate icons, host branches, and Cupertino color usage while preserving compatibility parameters needed by other callers. Update mirrored tests and record focused verification for the cleanup.
2026-11-11 21:12:40 +00:00
alan ba198d144a Use desktop dialogs for remaining sheets
Keep the audited runs filter, chat colour picker, and Needs you flows as Material bottom sheets on narrow or touch layouts while presenting bounded desktop dialogs on wide layouts. Remove obsolete Cupertino flags and add focused route regressions and notes.
2026-11-11 20:06:27 +00:00
alan 75929a0a41 Remove Cupertino branches from runs UI
Keep the Material-only run detail implementation while preserving public parameters for callers. Narrow the corresponding widget tests to the supported Material host and remove unused Cupertino-only code.
2026-11-11 05:11:26 +00:00
alan bc4e638475 Keep artifact tests on Material platform
Remove the unused Cupertino test variants so the reviewed artifact changes match the app's Material-only execution path.
2026-11-11 04:50:14 +00:00
alan 2ae18f3c9a Merge commit '03915fbb35c202d554d9e4cbc1549c0c4e62bdef' into pipelines/run-20261111-0420-cupertino-out-artifacts-9258 2026-11-11 04:37:15 +00:00
alan f46b82e207 Remove Cupertino branches from artifact features
Keep the Material implementation while preserving public parameters needed by callers. Remove Cupertino-only tests and variants because the app runs exclusively under MaterialApp.
2026-11-11 04:36:57 +00:00
alan 98e2abd9af Merge commit 'd365959bf1bb7921e728f8ad152548b21a44f9b5' into pipelines/run-20261111-0353-cupertino-out-runs-actions-7b6c 2026-11-11 04:19:56 +00:00
alan 364fd5b538 Remove Cupertino run action branches
Keep the Material-only run action behavior while preserving public Cupertino parameters for callers that will be cleaned up separately. Narrow the related tests to the supported Material path.
2026-11-11 04:18:26 +00:00
alan 8316b25029 Remove remaining Cupertino-only shell tests
Keep the Material coverage while removing tests for unreachable Cupertino hosts and variants from the shell cleanup.
2026-11-11 04:11:51 +00:00
alan f3d6013ef5 Remove Cupertino variants from runs sheet tests
Keep the runs sheet coverage focused on the Material-only app path and remove obsolete Cupertino hosts and loop variants.
2026-11-11 03:04:27 +00:00
alan f65eb98311 Merge branch 'main' into pipelines/run-20261111-0115-cupertino-out-ui-motion-navigation-input-6491
# Conflicts:
#	app/test/features/runs/ui/runs_list_widget_test.dart
2026-11-11 02:43:51 +00:00
alan 9adee6cc60 Remove Cupertino UI branches
Keep the public Cupertino-compatible parameters while retaining only the Material implementations and tests. The app is Material-only, so deleting unreachable Cupertino branches reduces dead code without changing the active path.
2026-11-11 02:41:26 +00:00
alan 968e3e908a Remove Cupertino attention branches
Keep the reviewed attention surfaces on their Material implementations while preserving public cupertino parameters for remaining callers. Remove the unreachable Cupertino sheet and narrow tests to the Material path.
2026-11-11 01:31:14 +00:00
alan 6a071a5b02 Drop Cupertino variants of the row menu and run detail tests 2026-11-10 23:02:20 +00:00
alan 42a2378ecb Anchor desktop Files and Runs menus
Use Material popup menus for file actions and anchor Runs sorting choices to the sort button while retaining the phone fallback. Update callers, tests, and implementation notes to match the desktop behavior.
2026-11-10 22:14:29 +00:00
alan 7287ba35c9 Refresh runs from nested wire events and foreground resume 2026-11-07 23:46:02 +00:00
alan 5423f1e839 Show definition and run warnings in app summaries 2026-11-05 14:23:36 +00:00
alan fc615c69e7 Merge branch 'main' into worktree-agent-a35ac03e196ffae50
# Conflicts:
#	app/lib/features/runs/ui/run_detail_content.dart
#	app/lib/features/runs/ui/run_list_row.dart
#	app/tool/search_selection_probe_entry.dart
2026-11-04 17:44:29 +00:00
alan e7d00b85ff Runs: running run and stage durations tick live
One shared ElapsedClock (single timer, only while a visible running item
is watched and the app is visible; cadence follows formatDuration
precision) and a LiveElapsedBuilder that repaints only its own text.
Running list rows, the Summary Duration and running timeline visits
tick. A stage start re-reads the open detail, since step deltas carry
no started_at. Fixture ?running=1 for captures.
2026-11-04 17:43:29 +00:00
alan d3a2369d1f Stage rows show cached share and cost; Changes explain no_patch_reason
Timeline stage rows add the cached share (when cache_known) and a positive
cost: 20.1M tokens · 97% cached · $1.42. The file viewer words each server
no_patch_reason, keeping the old truncated/binary text as the fallback.
2026-11-04 17:26:31 +00:00
alan 3227d61caf Token usage: keep cache/reasoning split, count only recorded steps, cost only when positive; captures fixture, docs and notes 2026-11-03 22:16:49 +00:00
alan aa948bdfe4 Runs list carries per-run token usage; app shows tokens beside size, Most tokens sort, Summary and stage tokens 2026-11-03 22:04:55 +00:00
alan a40a6e2e1c Narrow list panes: readable bar title, More overflow menu, rows keep status and actions
The floating bar keeps the title at its own width (up to half the bar) and
moves overflowable actions into one More menu instead of squeezing them
below their touch targets. List rows keep their leading status avatar and
More actions at any list-pane width; the time moves under the subtitle.
2026-11-03 18:04:10 +00:00
alan 6fbfa4e11f Merge: tabs as separate round glass buttons 2026-11-02 18:44:27 +00:00
alan 377ff04aaf Show each floating tab as its own round glass button
Replace the single glass pill (host NavigationBar/CupertinoTabBar with one
gliding highlight) with a row of separate circular GlassPill buttons, 52/50 px
with 12/10 px gaps, at the same bottom-right place. The selected button fills
with the host selection tint and cross-fades; each button pops in on its own,
staggered, only when the bar appears or its tabs change; presses sink like the
top bar's. Tab semantics, keys, tooltips and badges are kept; the row shares
one BackdropGroup for its blurs.
2026-11-02 18:43:05 +00:00
alan 8d2ca95057 Open Search artifact hits in the viewer over the run's Artifacts tab
On a phone-width window the open run is its own page pushed on the app
navigator, so RunDetailTabs was not a descendant of the shell's
RunSearchSelectionScope (which wraps only the Runs tab body). The field or
artifact selection was never seen and the run opened at its plain Summary.
The previous widget tests injected the scope directly above RunDetailView at
900 px, where the detail is an inline pane, so they could not catch it.

- RunsScreen relays the shell's search scope into the detail it builds, so
  the pushed page sees the selection too (also fixes field hits on phones).
- An artifact hit now opens the run's Artifacts tab and the gallery opens
  that artifact exactly as a tap there does: selected, scrolled into view
  (ArtifactVisitReveal) and in the viewer. Back returns to the tab with the
  artifact highlighted. An unknown URL leaves the tab open with the existing
  "That artifact is no longer available." notice.
- New test/application/search_artifact_open_test.dart drives the real Search
  tab -> typed query -> result tap -> run read -> viewer on a 390x844 phone,
  Material and Cupertino; it fails without the scope relay.
2026-11-02 18:39:43 +00:00
alan 629c8c6091 Search artifact hit: clear the pending visit flag; tests for opening
After opening an artifact from search the pending flag was never cleared, so
later visit selections stopped syncing. It is cleared once the visit page is
installed. Adds widget tests: the hit opens the viewer on that artifact, Back
lands on its visit and another visit still opens, and a missing artifact shows
the notice. Finishes run #231.
2026-11-02 00:40:38 +00:00
alan 41492df436 WIP: search artifact hit opens the viewer (run #231) 2026-11-02 00:35:23 +00:00
alan 6e6559235f WIP: expandable run title (run #224) 2026-11-01 12:43:27 +00:00
alan 944a26ce1a Open run artifact groups by default
Turn documents are hidden behind the Debug toggle now, so the run's own
artifact groups (the run Artifacts tab and a stage's Artifacts section) start
open instead of collapsed.
2026-11-01 01:41:54 +00:00
alan 266916f92a Runs: multi-select delete, run sizes and Largest-first sort
- Select mode (bar Select or long-press): per-row checkboxes, per-day
  Select all/Deselect all over finished runs only, "N selected" with the
  selection size, Delete and Done. Active runs get a disabled checkbox
  whose semantics give the reason.
- Native destructive confirmation, then delete_runs {run_ids} (batched by
  1000); the nested runs_deleted reply removes deleted rows and reports
  "Deleted N runs, freed X" plus refusals verbatim. runs_removed pushes
  remove rows and close an open detail; a deleted open run closes too.
  Delete run in the row and detail menus.
- size_bytes shown compactly in rows (0/absent = unknown, nothing shown),
  updated from run_event frames that carry it; Largest first sort (flat,
  unknowns last); the sort choice persists.
- Shared AppListRow gains selectionControl and onLongPress.
- Browser probe tool/runs_delete_probe.mjs; fixture server implements
  delete_runs/runs_removed.
2026-10-31 22:19:36 +00:00
alan 44ea45150f Compact floating tab bars with circular selection and equal edge gaps
The floating tab bar is now sized to its icon tabs at the bottom right on
every width, the selected icon sits in a tinted circle on both hosts, and
the gap from each outer circle to the pill's sides equals the gap to its
top, bottom and neighbours.
2026-10-31 16:53:24 +00:00
alan f84948153b feat(app): add debug toggle for turn documents 2026-10-31 15:22:33 +00:00
alan 5adcc0a379 fix(app): use native selected affordance in runs sort sheet 2026-10-31 15:15:45 +00:00
alan ea498e88db Merge branch 'worktree-agent-a992ffc22d3f335ed' into integrate/tabs-v2 2026-10-31 14:58:19 +00:00
alan a1c4c1c402 feat(app): icon-only tab bars, Settings from the Pipelines bar, main bar bottom right with detail bars above it
Settings leaves the tab bar (Pipelines, Runs, Chat, Search) and opens as a
page from a gear in the Pipelines bar, keeping /settings, its keys and a Back
to Pipelines (also the system Back). Every floating tab bar shows icons only,
named for assistive technology. On wide windows the shell's tab bar stays at
the bottom right; a split detail learns its height plus a 12px gap, so its
tabs or the chat composer float above it, and pages the detail opens (the
stage page) stay in its pane through its own navigator.
2026-10-31 14:57:56 +00:00
alan 6b11b136db fix(app): meaning colours for common outcomes; detail pages fill the pane
Timeline outcomes: success-like words are green, failures red,
rejections orange, retries/advisories amber, skips/cancellations grey;
a second word of the same family takes the family's next shade and any
other word a distinct hue outside the families, so different outcomes
still never share a colour.
Run detail, stage page and pipeline Summary no longer cap their width
at 840: on an unfolded foldable the sections fill the pane. The unused
ReadingWidth helper is removed.
2026-10-31 14:36:15 +00:00
alan 33cb9ca121 Merge branch 'main' into run/artifacts-split 2026-10-31 12:56:19 +00:00
alan acf74116d7 feat(app): separate turn documents from artifacts 2026-10-31 12:56:16 +00:00
alan ab64f55bf2 Merge branch 'worktree-agent-aab11f4f1fe3dff6b' into integrate/r3-rest 2026-10-31 12:51:39 +00:00
alan 6987a8992e Merge branch 'worktree-agent-a099cbf073f6e9e51' into integrate/shell-wide
# Conflicts:
#	app/lib/features/runs/ui/run_detail_tabs.dart
2026-10-31 12:51:39 +00:00
alan 8d9a21c310 Merge branch 'worktree-agent-a75e04ded5a42e4fb' into integrate/detail-bodies
# Conflicts:
#	app/lib/features/runs/ui/run_detail_timeline.dart
2026-10-31 12:42:39 +00:00
alan 75fb0fc6e5 Merge branch 'main' into worktree-agent-aab11f4f1fe3dff6b
# Conflicts:
#	app/test/features/runs/ui/run_list_row_test.dart
2026-10-31 12:36:49 +00:00
alan 251a15f8f8 Merge branch 'main' into worktree-agent-aab11f4f1fe3dff6b 2026-10-31 12:34:16 +00:00
alan bd370c9956 Merge branch 'main' into run/formats-wording 2026-10-31 12:29:16 +00:00
alan fe24f228fe fix(app): one relative-time style, day-aware durations, consistent visit wording
Review r2 findings P2-4, P2-5, P3-13: a shared relative-time helper for
every list row's time, formatDuration switches to days past 24h ('9d
16h'), the stage page uses one visit numbering, drops a repeated stage
heading and fixes '1 files', and search run hits read 'Run 1'.
Implemented by pipeline run #205/#207 (Terra); its UIReview blocked on a
fixture without timestamps, verified by the manager.
2026-10-31 12:29:16 +00:00
alan 1bf2ae41c4 fix(runs): colour timeline outcomes by name, not by status
A completed step's outcome chip took the success colour, so 'rejected'
read green beside 'success'. Outcome chips now get one colour per
distinct outcome name in the run (assigned by first appearance, from a
well-separated hue list that continues by the golden angle), so equal
names match and different names never share a colour. No outcome word
is wired to a colour; the status glyph still shows the step's state.
2026-10-31 12:28:54 +00:00
alan b4273a6492 Flatten run, stage and pipeline detail bodies; facts grid, wide run chrome, pipeline Summary rows
Detail bodies are flat on the page on both hosts (no Cupertino inset groups,
pinned headings on the page colour). Run and pipeline Summary share a
FactsGrid that fills its width (no centred single-fact card). Missing run
graph is one muted line. Beside a list the run tabs and header share one
row; the duplicate Pipeline fact and the decision card-in-card are gone.
Pipeline Summary: facts grid, Schedules heading with Add (no inline Refresh
or paragraph), versions as AppListRow. Timeline rows are AppListRow.
2026-10-31 12:25:21 +00:00
alan 05a06e8f08 Drop unused test imports 2026-10-31 12:19:03 +00:00
alan e43cc867f9 Sheets, decision options, usage, settings and artifact errors: review r2 batches H and L
Shared AppSheetHeader (title + Done) for the Runs filter/sort and Needs you
sheets; Runs filter single-choice groups as check rows and statuses in
sentence case; Cupertino decision options as a check list; run action sheet
titled with the run; usage page without the duplicate title and with honest
empty states; Settings Reconnect wording, compact notifications row and a
tinted Cupertino Save workspace; friendly artifact preview failures with
Retry.
2026-10-31 12:13:34 +00:00