Commit Graph

24 Commits

Author SHA1 Message Date
alan 28d8bdb29d Merge branch 'main' into web-attention
# Conflicts:
#	web/PARITY.md
#	web/src/app.js
#	web/styles.css
2026-10-19 04:55:01 +01:00
alan f3bc6ed126 web: attention / "Needs you" surface — bell, sheet, dismissals (R15, R2) 2026-10-19 04:52:34 +01:00
alan 3d98c60de6 Merge branch 'main' into web-search
# Conflicts:
#	web/src/app.js
#	web/src/protocol.js
#	web/src/repository.js
#	web/styles.css
#	web/test/repository.test.mjs
#	web/test/ui-smoke.mjs
2026-10-19 04:44:54 +01:00
alan 6992ecd4e8 web: run-level actions — human decision, cancel, retry and rename (R11–R14)
Add the run-level operator actions to the browser run detail, matching the
Android client's wording and wire frames:

- R11 human decision: pure model in src/actions.js (pendingDecision,
  lastWaitingStep, waitingPrompt/waitingOptions, humanOptions,
  decisionTargetLabel, DecisionDraft) plus the decision card and sheet;
  decide_run sends run_id, the chosen option and trimmed feedback.
- R12 cancel: a Cancel run action offered only while executing; the Android
  confirm copy; cancel_run then a silent get_run refresh.
- R13 retry: offered only for a loaded, non-executing failed run; resume is
  the default (no retry_mode, like Android) with a browser-only
  Restart from start secondary that sends retry_mode:"restart".
- R14 rename: an inline set_run_title field; refreshes the run and its list row.
- One shared Action failed dialog for all of the above.

Add the protocol constants and typed builders, a hand-written dark-palette
section for the card/sheet/dialogs, focused unit tests for the helpers and
request shapes, and ui-smoke captures for the new states. Update PARITY.md:
R11 stays partial (no live waiting run), R12–R14 done with the stated
shown-not-executed and Android-divergence notes.

Also harden openRunDetail() in the UI smoke: the tabstrip already exists from
the previously opened run, so wait for the target run's identity line before
asserting on its actions (review finding).
2026-10-19 04:37:35 +01:00
alan 26eaec2531 web: add omni-search results and routing (S1/S2) 2026-10-19 04:31:24 +01:00
alan 9555bfe58f Merge branch 'main' into web-connection
Integrate main's run-detail Changes (R4) and Graph (R5) work with the
connection banner/reconnect/foreground-recovery/live-badge work (T3/T4/T5).

Conflicts resolved by keeping both independent additions:
- web/styles.css: the .conn-*/.live-* rules and the .change-*/.diff-* rules
  are separate blocks; both retained under their own comment headers.
- web/test/ui-smoke.mjs: both capture sequences retained (T3/T4/T5 writes
  28-connected-banner/29-disconnected-banner/30-reconnect-recovered; R4/R5
  writes its own distinct 28-34 run-change captures), so no filename collides.

Checks after the merge: node --check on all touched JS/MJS; node --test test/
225 pass / 0 fail; node test/ui-smoke.mjs --out <worktree>/captures UI SMOKE
PASS against ws://127.0.0.1:8080/connect, including the connected banner +
build line + live badge, the disconnected retry banner, the online-event
recovery, and main's R4/R5 captures.
2026-10-19 04:11:50 +01:00
alan 9f6e10bf71 Merge branch 'main' into web-changes
Resolve the web/PARITY.md conflict by keeping main's R3 (now listing the
Graph tab) and R5 rows alongside this branch's R4 row; R4's Changes viewer
merges cleanly into app.js, styles.css and ui-smoke.mjs.
2026-10-19 04:07:48 +01:00
alan 9d1745da1d web: run Summary Changes section with rendered/raw diff viewer (R4)
Add a collapsed-by-default Changes section to the run Summary tab and a
full-screen diff viewer, ported from the Android RunChanges/ChangeDiffViewer
wording. Pure aggregation and unified-patch parsing live in src/changes.js;
app.js wires the section/viewer and sets every server string with textContent.
Unit tests cover the header variants, kind merge, stat sums and hunk parsing;
ui-smoke captures the collapsed/expanded section, rendered and raw viewer,
paging, Escape/backdrop close, binary, truncated and a running run's header.
2026-10-19 04:06:44 +01:00
alan 71342fe027 web: connection banner, reconnect, foreground recovery and live badge (T3/T4/T5)
Close T3, T4 and T5 of web/PARITY.md (the "Transport and connection"
table). T1/T2/T6 are untouched beyond wiring.

- src/connection.js (new): the pure, DOM/socket/timer-free helpers behind
  every new state — `bannerState` (the persistent banner's copy and tone),
  `stateBadge` (the compact header indicator, which is also where the retry
  attempt is named), `foregroundAction` (the return-to-foreground policy
  from ConnectionRecovery.kt), `protocolMismatch`, `serverBuildLabel` and
  `liveBadgeState`. Wording and colour roles mirror ConnectionBanner.kt,
  LiveBadge.kt/RunStream.kt and SettingsScreen.kt.
- src/app.js: wiring only. The banner sits in normal document flow under
  the header (never overlaying content); a Reconnect control appears beside
  the URL field whenever `bannerState` offers one and re-opens the same
  validated endpoint through `client.connect`, resetting the backoff;
  `visibilitychange`/`online` drive the foreground recovery; the ping reply
  records the server build and protocol for the banner.
- src/protocol.js: `PROTOCOL_VERSION = 1`, citing internal/protocol/
  identity.go and Message.kt.
- styles.css: the .conn-* banner and .live-badge rules in the app's dark
  palette, on the existing :root variables.
- test/connection.test.mjs (new): 18 focused unit tests for the pure
  helpers, including source-parity assertions against the Android files.
- test/ui-smoke.mjs: assert the connected banner + build line + live badge
  and capture them, then point the page at a closed port to capture the
  disconnected retry banner and recover via the browser's `online` event.
- PARITY.md: T3/T4/T5 done with their captures.

Checks: `node --check` on all five touched JS/MJS files; `node --test
test/` 190 pass / 0 fail (18 new); `node test/ui-smoke.mjs --out ...
/web/captures` UI SMOKE PASS against ws://127.0.0.1:8080/connect, writing
28-connected-banner.png, 29-disconnected-banner.png and
30-reconnect-recovered.png.
2026-10-19 04:06:18 +01:00
alan 94d4ff02d3 web: run detail Graph tab with executed styling and stage panes (R5)
Add the run detail's Graph tab (between Summary and Input), reusing the
shared src/graph.js renderer (P6) rather than a second renderer. In run
mode a visited stage is executed (solid fill + border), an unvisited one
hollow with a dashed muted border; a terminal is executed only when a
visit resolved to it; a route is executed only when a recorded visit
produced that outcome (solid with an arrowhead, success first, error
last, others alphabetical, `error*` for the fallback). The Executed /
Not executed legend shows only for a run. While the run executes the
current stage carries a pulsing halo (static under prefers-reduced-motion)
and a ticking elapsed badge; a finished run shows neither. Clicking a
stage opens the existing visit pane at that stage's latest visit, and
Back/Escape return focus. The empty state is the exact
"This server did not include the run graph."

extend src/graph.js with the run-mode inputs (runState-driven executed
styling, legend, active halo/elapsed badge); keep app.js to wiring.
Extend graph.test.mjs with focused run-mode unit tests and ui-smoke.mjs
with the run 438 / run 440 / live-run captures. Mark R5 done in
web/PARITY.md.

Checks: node --check on every touched file; cd web && node --test test/
(178 pass, 0 fail); cd web && node test/ui-smoke.mjs --out captures
(UI SMOKE PASS, captures 28-31).
2026-10-19 04:05:37 +01:00
alan 2e9ff1704f Merge branch 'main' into web-run-tabs 2026-10-19 03:32:34 +01:00
alan 06965933f4 web: tabbed run detail with summary, IO fields and timeline (R3/R6/R7)
The browser run detail becomes a tab strip — Summary, Input, Output,
Timeline — over the selected tab's body, with the Graph tab key reserved
for the R5 item.

- Summary: run label, status chip + outcome, the run identity line, the
  key/value rows (Pipeline, Stage, waiting-for-resource line, Workspace,
  content hash, Started, Finished, live Duration, Retry of, Diagnostic)
  and the collapsed run artifacts gallery.
- Input / Output: one collapsed section per recorded map entry, the value
  as a monospace block; empty states match the app.
- Timeline: one row per visit with the stage-outcome glyph, `{stage} ·
  visit {n}`, an outcome chip, a paperclip when artifacts were recorded,
  the duration and the description; a row opens the per-visit stage pane.
- Stage pane: headline rows, the Verdict block with inline artifact links
  and the Artifacts / Session / Output / Input / This run / Stage
  definition sections, all closable with Escape.

All new logic is the pure, DOM-free src/runDetail.js ported from the
Android sources; app.js keeps only the wiring and every server string is
set with textContent.

PARITY.md: R3, R6 and R7 marked done with their captures.
2026-10-19 03:32:32 +01:00
alan 9456f8a319 web: workflow graph rendering in the pipeline detail (P6)
Close P6 of web/PARITY.md: the pipeline detail's Graph tab now renders the
pipeline's workflow graph — stage nodes in declaration order, labelled outcome
edges, and the #failure/#success terminals on a shared lower row — plus a
definition pane opened from a node.

- src/graph.js (new): reusable `mount(container, graph, options) -> { unmount }`
  plus the pure helpers it is built from (layout, edges, `error*`, lanes,
  fit/clamp/zoom, hit-test, stage-definition fields). Definition view only, so
  the run-detail Graph tab (R5) can reuse it. Mirrors WorkflowGraph.kt,
  GraphPalette.kt, GraphSemantics.kt, StageDetailPane.kt and RunGraphTab.kt.
- src/app.js: wiring only — mount the graph in the Graph tab, drop the previous
  mount on every re-render.
- styles.css: the .graph-* styles in the app's dark palette.
- test/graph.test.mjs (new): focused unit tests for the pure helpers, no DOM.
- test/ui-smoke.mjs: open "Plan and land", switch to Graph, capture the graph,
  a stage pane and the expanded view, and assert the zoom/pan clamps and the
  empty-pane wording against the live server.
- PARITY.md: P6 done with the 2026-10-19 captures; P3 notes the Graph tab now
  renders the graph; R5 stays todo.

Checks: node --check on all five touched JS/MJS files; `node --test test/`
137 pass / 0 fail; `node test/ui-smoke.mjs --out ../captures` UI SMOKE PASS
against ws://127.0.0.1:8080/connect.
2026-10-19 03:26:50 +01:00
alan 4be740b461 Merge branch 'main' into web-artifacts
Combine the R8/R9 artifacts gallery, viewer and session link with main's
pipelines/runs/templates work. app.js: keep both import blocks. ui-smoke.mjs:
the artifacts step now navigates to Runs and selects run 430 through the
post-main run-row markup (meta[data-run-id=430]) instead of the retired
'.list button.row #430' spike row.

Checks: node --check on every touched file; node --test test/ 108 pass;
live ui-smoke against ws://127.0.0.1:8080/connect passes (run 430: 18 tiles,
viewer '1 of 10 · image/png', session link .../artifacts/430/8/session.html).
captures/ stays untracked.
2026-10-19 03:05:58 +01:00
alan aed65a7431 Merge branch 'main' into web-runs-home
# Conflicts:
#	web/src/app.js
#	web/styles.css
2026-10-19 03:02:42 +01:00
alan 28edc32dc3 Merge branch 'main' into web-runs-home
# Conflicts:
#	web/src/app.js
#	web/styles.css
#	web/test/ui-smoke.mjs
2026-10-19 03:00:13 +01:00
alan 96c315dbec Merge branch 'main' into web-templates
# Conflicts:
#	web/PARITY.md
#	web/src/app.js
#	web/styles.css
2026-10-19 02:58:34 +01:00
alan 13404b2a2b web: pipeline list, filter/sort and detail (P1/P2/P3)
Close three rows of the browser client's parity checklist, matching the Android
app's wording and behaviour:

- P1 pipeline list: name; "id {id} · v{version} · {N stages}"; "updated d MMM
  HH:mm"; a last-run line joined from list_runs (status chip plus
  "{ago} · {duration} · run {id}", or "no runs recorded").
- P2 filter + sort: Filter menu (name contains, Runs Any/Has runs/No runs, the
  seven server run statuses, Clear filters) and Sort menu (Server order default,
  Name A-Z/Z-A, Most recent run, Fewest/Most stages, Reset). Server order is
  preserved.
- P3 pipeline detail: Summary/Graph/Source tabs; Summary shows the content hash
  (monospace), latest version, created/updated and a collapsed-by-default
  Versions section. The Graph tab carries the browser guidance note only; the
  rendered graph stays P6.

New src/pipelines.js holds the pure, DOM-free helpers (timestamps, durations,
last-run join, comparators, filter, empty states); app.js is wiring only.
web/test/pipelines.test.mjs covers the helpers; web/test/ui-smoke.mjs captures
the list, controls and detail against the live server. All server strings are
set with textContent.
2026-10-19 02:52:35 +01:00
alan 849a184561 web: run history list, filter and sort (R1/R2)
Day-grouped run list with sticky day headers (Today / Yesterday / d MMM
yyyy / Unknown date), a usage roll-up block, the app's row hierarchy and
a bounded filter/sort menu — mirroring RunHistoryScreen.kt, ListFilter.kt
and ListSort.kt. New pure helpers live in src/runs.js with focused unit
tests; app.js keeps the wiring and sets server strings with textContent.

R1 done, R2 partial: no per-row "needs you" mark exists in the Android
app; its wording is deferred to R15 (separate attention surface).
2026-10-19 02:50:51 +01:00
alan 67120947c2 web: artifacts gallery, full-screen viewer and session export link (R8/R9)
Port the Android artifact derivation into a pure, DOM-free src/artifacts.js
(presentedArtifacts with the retired session.md hidden everywhere, grouping by
stage/visit, the header/summary/capture-note wording, kind and size formatting,
viewer paging and sessionExportArtifact) and unit-test it.

Wire it into src/app.js: a run-level artifacts gallery with per-(stage,visit)
groups, per-visit summaries and tiles, a full-screen viewer overlay (paging,
Escape/backdrop close) and the read-only session.html link. Every server string
is set with textContent; captures/ stays untracked.

Captured live against run 430 through test/ui-smoke.mjs:
captures/04-run-430-artifacts.png, 05-artifact-viewer.png,
06-session-export-link.png. PARITY.md marks R8 and R9 done.
2026-10-19 02:38:48 +01:00
alan da3c488506 web: templates gallery and template detail (P4) 2026-10-19 02:30:39 +01:00
alan 4721b8af10 web: prepare the client workstream for feature parity
Adds the area map (web/AGENTS.md), the parity acceptance checklist
(web/PARITY.md, one row per Android feature), and a zero-dependency browser
verification harness: test/browser.mjs drives the installed Chrome over the
DevTools protocol, and test/ui-smoke.mjs serves the page, connects it through
its own /connect proxy, and captures the rendered pipeline list, a pipeline
detail and a run detail as PNGs.

This closes the spike's 'rendered page not verified' gap (29 pipelines rendered,
three captures) and gives review stages real UI evidence without a phone or an
npm install. Hosting is unchanged: serve.mjs stays alongside the Pipelines
server and proxies /connect.
2026-10-19 02:13:39 +01:00
alan 95362134aa session export: write only session.html, retire the markdown export
A stage's session was exported twice, as session.md and session.html, and both
files were presented. It is now one html file; the markdown export is retired.

- internal/stage/session_export.go: ExportSession renders and writes exactly one
  file, session.html, via writeSessionFile; renderSessionMarkdown and its helpers
  are gone; SessionExportResult carries HTML/HTMLBytes only. The source read, the
  8 MiB source / 2 MiB rendered bounds, the truncation banner, the
  never-overwrite rule and the honest empty-session handling are unchanged.
- internal/protocol/runs.go: SessionExport drops markdown/markdown_bytes (a
  record written before the change still decodes; unknown fields are ignored),
  and adds LegacySessionMarkdownArtifact with RunStep.PresentedArtifacts(), the
  one Go rule that hides the retired session.md from every artifact listing.
- internal/server/runner.go: evidence.Markdown/MarkdownBytes are no longer copied.
- internal/tui: the artifacts panel, the recorded count and the per-visit summary
  derive from PresentedArtifacts(), so the terminal never lists session.md.
- web/src/app.js: the spike's renderArtifacts applies the same filter.
- android: the Session section is the html export alone in a WebView — SessionView,
  the Markdown/HTML toggle and the session markdown path are removed;
  presentedArtifacts(step) filters the retired session.md out of the per-visit
  gallery, the run gallery and its count, the verdict/selection lists and the
  timeline indicator; data/protocol SessionExport drops the markdown fields.
- Tests pin the single html file, prove no session.md is written and that a
  pre-existing one is neither overwritten nor presented, and prove a legacy
  export record still loads and its session.md is hidden.

The legacy session.md of an older run stays on disk (dated evidence); it is only
no longer produced and no longer presented.

Checks (macOS, Go 1.24, Android Gradle 8.11.1, 18 Oct 2026): gofmt -l . prints
nothing; go build ./... && go vet ./... clean; go test ./internal/... ./cmd/...
-> 19 packages ok, 0 failures; node --check web/src/app.js ok and node --test
web/test -> 20/20; gradle --offline --no-daemon :app:assembleDebug
:app:testDebugUnitTest -> BUILD SUCCESSFUL.

Packaged references checked: internal/author/skill/references/delivery.md and
operations.md both described the session.md+session.html pair, so both are
updated here to describe the single session.html export and the retired, hidden
session.md. README.md and internal/author/skill/SKILL.md carry no session.md
reference and install.go's managed inventory is unchanged (no reference added or
removed). docs/notes/session-html-only.md records the remaining stale shared
documentation (docs/stage-artifacts.md, docs/app-integration-verification.md) for
the docs-fold writer; shared docs are not edited by this item.
2026-10-18 10:06:49 +01:00
alan bd09c55c47 Merge lane-go: titles, verdicts, human stage, line result format, stale-client guard
Integrates nine commits of reviewed work from the lane-go branch after the
automated resolver failed on this merge five times (each attempt dying on the
malformed-result defect whose fix is contained in this same merge).

Integration decisions:
- Search: kept main's shipped design (Store.Search + SearchResponse.Results) and
  dropped lane-go's parallel, older attempt (an unused Message.Matches field, an
  absent runs.search, and two partial TUI plumbing blocks). lane-go itself did not
  compile: protocol.SearchMatch was undefined and model.go referenced searchNav,
  requestSearch and applyRunNav, which exist nowhere. Those partial TUI blocks are
  removed; the queued TUI omni-search item will implement the surface properly on
  main's design.
- Both sides' additions are kept where they are independent: run titles and
  provenance, the human decision stage and its CLI/TUI surface, the derived stage
  verdict, the stale-client guard, the line-oriented result format, and main's
  search command.
- The search key's help label is now "/ omni search"; the two tests asserting the
  old label are updated rather than the label reverted.
- docs/cli.md and the packaged operations reference carry both sides' text.

Verified: go build ./... , go vet ./... and the full go test ./... suite pass.
2026-10-16 22:21:43 +01:00