Commit Graph

26 Commits

Author SHA1 Message Date
alan 0b74903a00 Add long-press artifact multi-select with bulk copy and share
Long-pressing any artifact — a gallery tile in the run summary or a row in
the stage pane's per-visit list — now enters artifact selection: the pressed
item is selected with the app's selected treatment and further taps toggle
items instead of opening them. A contextual bar replaces the surface's top
bar while selecting, showing the count plus Copy links, Share and a close;
it carries the same pane safe-area insets as the bar it replaces, uses 48dp
IconButtons and leaves selection mode on Back before the surface's own Back
runs. Selection applies only to artifacts, never the runs or pipelines lists.

The selection is one shared host: ArtifactSelectionScaffold owns the
remembered ArtifactSelection, the resolvedSelection lookup, the bulk
copy/share actions, the SnackbarHostState and the pane-scoped BackHandler,
and both RunDetailScreen (summary grid) and StageDetailPane (per-visit list)
go through it, so neither screen owns its own SnackbarHostState or
BackHandler. The immutable ArtifactSelection (enter/toggle/selectAll/clear)
treats selection mode as "one or more urls selected", so it can never
restore half-applied; rememberArtifactSelection saves it via a listSaver and
reseeds per run/visit.

Copy links resolves every selected url against the configured server through
the existing resolvedArtifactUrl (no hardcoded host), writes one absolute
link per line through the new single Clipboard.copyText path (now also used
by the code blocks, pipeline source, artifact row and viewer), and confirms
the number of lines actually produced in a Snackbar. Share fetches every
selected artifact through the existing client, reuses the single-item
writeSharedArtifact (same bounded cache, FileProvider and prune), and sends
one ACTION_SEND_MULTIPLE typed by bulkShareMimeType (the common type, else
the wildcard) with the count in the chooser title; when any fetch fails the
whole set degrades in the same action to its resolved links shared as text.

Pure helpers and tests: ArtifactSelectionTest covers enter, toggle,
deselect-last, select-all/clear, the restored state, the one-per-line link
formatting and the labels; ArtifactSharingTest gains shareTargets and
bulkShareMimeType cases. Unit tests plus assembleDebug pass (168 tests,
21 classes, 0 failures). android/README.md documents the model, action bar
and the bulk share flow, and the doc-accuracy pass records that the bulk
copy writes links in gallery (candidate) order.

No new dependency (icons come from the declared material-icons-extended).
2026-10-16 08:51:03 +01:00
alan 1195535852 Add a real share action to every artifact item
Give each gallery image cell and each per-visit file row its own share
control: a 48dp IconButton with an accurate "Share <name>" content
description drawn as a sibling of the item's tap handler, so sharing
never opens the image or the item.

Sharing fetches the artifact through the existing client into a scoped
cache file (cache/shared-artifacts/), exposed via a non-exported
FileProvider declared with the new res/xml/file_paths.xml, and sends it
through ACTION_SEND. When the fetch returns nothing the action falls
back to sharing the resolved link as text. Cache files are named
deterministically per artifact so re-sharing overwrites instead of
growing without bound, and a failed or unreachable fetch cannot crash.

The artifact-to-file naming, mime/extension table and the file-vs-link
fallback decision are factored into ArtifactSharing.kt and covered by
the new ArtifactSharingTest.kt. The existing open and copy-link actions
are unchanged; the viewer's action scrim alpha is shared as
ARTIFACT_ACTION_SCRIM_ALPHA. android/README.md documents the provider
and the share flow. No new dependency is added.
2026-10-16 07:03:18 +01:00
alan d339827b5f Open artifact images in a full-screen zoomable viewer
Tapping an image artifact (run summary grid, per-visit list or stage pane,
all rendered through ArtifactGallery) now opens a new scrim-backed
full-screen viewer instead of the former small centred dialog, which is
removed rather than stacked.

- ArtifactViewer.kt renders a full-bleed Dialog (usePlatformDefaultWidth =
  false, decorFitsSystemWindows = false) whose content re-applies
  paneSafeArea() so the dark backdrop reaches the edges while respecting
  status bar, cutout and navigation bar. A top-right row keeps the
  open-in-new and copy-link actions and adds a close button over a
  translucent scrim capsule.
- Gestures: pinch zooms about the centroid, drag pans via the existing
  graph zoomAbout, double-tap toggles fit <-> 2.5x, and a downward swipe at
  fit dismisses; a plain tap does nothing. Zoom clamps to [1x, 5x] and the
  new pure clampImageOffset keeps pan inside the scaled image. Zoom state is
  keyed on the url, so closing the viewer or opening another image resets to
  fit/centred. System Back and the close button dismiss the viewer without
  closing the pane behind it.
- Loading goes through the existing cached, off-main-thread
  rememberArtifactBitmap/ArtifactImageState path with distinct loading and
  error states, drawn in the light inverseSurface role that contrasts with
  the always-black scrim.
- Pure helpers fitImageSize, clampImageOffset and toggleZoomScale are
  covered by the new ArtifactViewerTest. ArtifactImage.kt widens
  rememberArtifactBitmap/ArtifactImageState to internal and Artifacts.kt
  replaces FullSizeArtifactDialog with ArtifactViewer (openArtifact made
  internal).
- android/README.md documents the viewer, its gestures and the evidence
  gathered on emulator-5554.
2026-10-16 06:35:08 +01:00
alan 7b61906e1b Lead the run summary with a width-derived artifact grid
In the run detail summary, artifacts now appear at the top of the page and as a grid rather than a list:

- RunDetailScreen emits the "run-artifacts" LazyColumn item before the "run-summary" item, so the captured screenshots are the first thing the operator sees. The rest of the summary and its collapsed-by-default sections are unchanged.
- ArtifactGallery derives its geometry from the measured width via the new pure artifactGrid(availableWidth, preferred, spacing): it fits as many preferred-shaped cells as the width allows and stretches them to fill the row, instead of the removed fixed ARTIFACT_GRID_COLUMNS count. A host narrower than one preferred cell falls back to a single narrower cell; a non-positive preferred token never divides by zero. Tiles still open the full-size image on tap; non-image artifacts keep their compact list form.
- ArtifactGalleryTest replaces the fixed-column cases with grid cases covering a narrow pane (fewer, larger cells), a wide window (more columns), a very wide window (cells near the preferred shape), the single-cell fallback and degenerate inputs, asserting the row never overflows the host.

Verified with assembleDebug (APK 17,863,337 bytes, sha256 32e9081b28f5caa85f5bfa24f7fe7149eeddb919d4e71cf497e9017b80f54ce7) and the unit tests (140 tests, 0 failures/errors/skipped); captured on emulator-5554 at both window widths.
2026-10-16 05:28:39 +01:00
alan 6229fc9db5 Keep every pane inside the Android safe area
The stage detail pane covered the status bar. Introduce one shared
paneSafeArea() (WindowInsets.safeDrawing: status bar, display cutout,
navigation bar, gesture area and IME) and apply it from the live window
insets across the pane stack:

- SlidingPaneStack uses it (unioned with systemGestures) for the covered
  peeks' strip geometry.
- Each pane's Scaffold reserves it once via contentWindowInsets, and its
  TopAppBar reserves the top/horizontal part, so no pane sits under the
  status bar, a cutout, the navigation bar or the IME. Applied to the five
  stacked panes and SettingsScreen.
- The connection banner owns the top inset and the NavHost consumes it
  (paneSafeArea().only(Top), was statusBars) so the inset is never doubled.
- The floating destinations pill clears the same safe area, so the keyboard
  no longer hides it.

Scrollable content stays inside the remaining space rather than clipping.
android/README.md records the design and emulator-5554 verification.
2026-10-16 05:08:46 +01:00
alan 5ad4b58770 Mirror the Android pane close animation
Give every pane one shared slide spec, a fixed 300 ms duration and a symmetric cubic-bezier easing, so a close is the open curve run backwards at the same duration; several levels that pop in one tap now stagger so each reverses in order from the top.

The stack mounts a level while it is open or still sliding out and calls the pane only then, and rememberPaneContent retains each closing pane's full parent identity (item/version/section, stage key, visit). A closing pane therefore keeps rendering the content that opened it instead of vanishing or falling back to an empty node, and a fully closed level composes nothing. Geometry, tokens and insets are unchanged.

Adds three pure unit cases for the symmetric easing and the stagger rule; documents the change and its emulator verification in android/README.md.
2026-10-16 04:31:53 +01:00
alan 1fece88286 Make the Android stage detail pane an opaque raised sheet
The pane's Scaffold already painted an opaque colour, but it was the app
background role, identical to the peeks it slides over, so it read as
"no background" and its rows ran together with the covered pane's compact
identity.

Paint the whole pane one theme container role: StageDetailPane gains
paneContainerColor() = colorScheme.surfaceContainer and applies it to the
Scaffold container, the TopAppBar and the visit PrimaryScrollableTabRow, and
StageSection passes it to the shared SectionHeader, which gains an opaque
containerColor parameter defaulting to the previous background. The pane now
fully covers the area it occupies, including under a sticky section header,
and sits a tuneful step above the app background it covers.

Move the shared cards one step up so a card stays a card on the new sheet:
CodeBlock and the artifacts ArtifactRow use surfaceContainerHigh and the
full-size artifact dialog uses surfaceContainerHighest. No geometry, inset or
dependency changes; all colours come from the existing theme.

Verified with gradle :app:assembleDebug and :app:testDebugUnitTest (137 tests,
0 failures) and by capturing the pane open over the graph and the Timeline at
both window widths on emulator-5554. android/README.md records the change and
evidence.
2026-10-16 02:33:30 +01:00
alan cfd5887311 Lead a run's stage pane with the run's results
A stage opened from a run (Timeline, run graph or run stage list) now leads
with the run-side result instead of the stage's own definition: status,
outcome, duration, visit and target, then the visit's results in the order
Artifacts (gallery first), Output, Input, then the remaining run evidence
under This run. The stage's full definition (type, prompt, output contract,
outcomes, model, provider, configs, tools, limits, memory, notify) moves into
one collapsed "Stage definition" section at the bottom.

StageDetailPane gains a runContext flag: RunStagePane passes true and gets the
collapsed-definition default, while PipelineStagePane passes false and keeps
the definition expanded, since it is then the pane's only content.
rememberSectionExpansion gains an initiallyExpanded set (part of the save key)
so the seed respects an operator's own expand/collapse choices without
inheriting them across contexts.

Nothing visible before is removed - the previous Model/Provider headline
promotion is reverted and those facts remain reachable inside the expanded
definition. The visit tabs and the collapsed-by-default behaviour of the other
sections are unchanged. android/ only; no dependency added.

Updates android/README.md and StageDetailSheetTest.kt accordingly.
2026-10-16 02:02:43 +01:00
alan cd85f6954b Render artifact thumbnails with an honest loading/failure state
The artifact grid could show failure placeholders that were never earned:
a server-relative artifact url that failed to resolve against the configured
server was fetched anyway and blamed with the "!" failure mark, and the
loading state was a bare "…" text.

- Pass the resolved url (nullable) into ArtifactImage; a null short-circuits
  to a new distinct Unavailable state (LinkOff glyph) and issues no request,
  so a fetch that was never attempted is never drawn as a failure.
- Reserve Error/"!" for a fetch or decode that was actually attempted.
- Replace the "…" text with a real Material 3 CircularProgressIndicator.
- Resolve gallery artifact urls in one shared helper (resolvedArtifactUrl)
  so the image tile and the non-image row cannot disagree; non-image
  artifacts keep their file-type icon.
- Add unit tests covering resolution against the configured server and the
  null (unconfigured) case.
2026-10-16 01:40:44 +01:00
alan 66d4856348 Validate Android screenshot captures before use
Add android/scripts/capture_png.sh, which captures on-device (screencap -p -d <SurfaceFlinger id>) to /sdcard, pulls the file, and validates PNG magic bytes plus the reported type, deleting and failing on anything that is not a real image. Document the multi-display warning failure mode and the required helper in android/README.md so every UI-capturing run captures and validates instead of writing adb screencap straight to a file.
2026-10-16 01:22:45 +01:00
alan 3deff18572 Render a compact identity for covered Android panes
On a wide window, a covered pane in the stack used to render a squeezed
copy of a full pane, so a covered entry showed a truncated title and a
crushed tab rail. A covered pane now renders only a compact identity: a
centred title plus at most one status/subtitle line, with no tab rail,
list, gallery or scroll body drawn into the sliver.

- SlidingPaneStack's pane lambda receives a covered flag; on a wide window
  a covered level composes only the new PaneIdentity, while the list, both
  detail screens and the stage pane early-return from their covered branch
  after their data-loading effects.
- Adds MIN_COVERED_PANE_WIDTH_DP (112.dp); peekStripsDp shows at most
  budget / MIN_COVERED_PANE_WIDTH_DP covered peeks and folds the oldest
  levels into a single "<n> more" edge indicator rather than squeezing
  them below the minimum.
- The fixed PEEK_BUDGET_DP (224.dp) and the constant active-pane width
  are unchanged; the peek tap, Back and the narrow layout keep the same
  behaviour.
- Rewrites SlidingPaneStackTest (10 cases) for the fold rule, minimum
  width, constant active width and inset/geometry invariants, and records
  the evidence and the unreachable-fold gap in android/README.md.
2026-10-16 01:16:24 +01:00
alan 206953e067 Show an Android run stage's Model/Provider in the headline
Surface a run stage's recorded Model and Provider configs in the stage
pane's always-visible headline instead of leaving them inside the
collapsed Definition section, so the operator sees them without expanding
anything, and stop rendering them twice.

- StageDetailPane.kt gains the pure STAGE_CONFIG_HEADLINE_LABELS
  ({"Model", "Provider"}), stageConfigHeadlineFields(definition) and
  remainingDefinitionFields(definition). StageDetailBody renders
  headlineFields(runFields) + stageConfigHeadlineFields(definition) as the
  headline and remainingDefinitionFields(definition) inside the collapsed
  Definition section; both derivations are remember(definition)-keyed and
  the run-evidence split stays runStepFields/headlineFields/evidenceFields.
- The definition-only, never-visited stage keeps its existing look; the
  Definition section no longer repeats Model/Provider because they are now
  headline facts, and everything else stays as before.
- StageDetailSheetTest adds
  definitionModelAndProviderArePromotedToTheHeadlineWithoutDuplication and
  aDefinitionWithNoConfigsPromotesNothing.
- android/README.md records the pass: the reported "content lost" symptom
  is not reproducible at 791d3dd (the run-61 definition-only screenshots
  are the Pipelines destination), the promoted facts are the real gap, and
  the unit tests (132/0), assembleDebug, device verification on
  emulator-5554 and the APK publish are noted with what was not verified.
2026-10-16 00:54:22 +01:00
alan 791d3dd3ff Swap Android detail sections in place instead of sliding them
Selecting a section in a run or pipeline detail now cross-fades the body in
place rather than sliding it sideways, so a tap on the rail or tab row is an
ordinary tab change with no lateral motion and nothing to swipe.

- DetailTabs.kt drops the HorizontalPager for section bodies and renders only
  the selected section behind a short Crossfade (SECTION_SWAP_MILLIS = 180).
  Level navigation (list -> detail -> stage pane) still slides via the
  unchanged SlidingPaneStack.
- Each section's saved state (its LazyColumn scroll) is kept under its stable
  tab key with rememberSaveableStateHolder().SaveableStateProvider, so
  returning to a section restores where the operator left off instead of
  resetting it.
- The rail/tab-row selected state and tab semantics are unchanged.
- Update the two call sites' stale "pager" comments and refresh the README
  section describing the section selector.
2026-10-15 23:57:57 +01:00
alan 0b373d0c65 Make Android pane navigation adaptive with a fixed peek budget
Replace the per-level peek with a fixed total peek budget on wide windows
and drop the stack entirely on narrow ones, so a folded phone loses no
width to dead peek space and a deep stack never reserves more than the
budget.

- SlidingPaneStack gains a `wide` parameter (the callers pass the existing
  isWideLayout value). On a narrow window the budget is 0dp, so every
  pane's open offset is 0 and each opened pane is a full-window screen
  that springs in over the last; Back, the gesture and the pane's own back
  control pop one level and nothing is left on the left.
- On a wide window peekBudgetDp (PEEK_BUDGET_DP, 224dp) is the fixed total
  space shared between the covered panes, independent of depth, so the
  active pane's left edge is always exactly the budget and its width
  (hostWidth - budget) stays constant as levels are added. paneOpenOffsetsDp
  widens the leftmost strip first so it stays tappable after the start
  inset (min of PEEK_WIDTH_DP and the platform minimum interactive size),
  then splits the rest evenly. peekBudgetDp clamps so the active pane never
  collapses below MIN_ACTIVE_PANE_WIDTH_DP and paneWidthDp is never
  negative. All geometry is derived from the named tokens, the measured
  host width and the system insets - no new literals.
- The peek-strip hit targets now come from the shared offsets, and panes
  remain opaque, inset inside the safe area, hidden from accessibility when
  covered, and opening/closing stay exact mirrors through the same
  animators. PaneState documents the narrow (no peek) rule.
- SlidingPaneStackTest is rewritten around the pure budget geometry (narrow
  spends no peek, the wide active pane is constant width, four levels share
  one budget with every strip tappable, the budget clamps, tiny hosts never
  go negative), and android/README.md records the pass, its evidence and
  what was not verified.
2026-10-15 23:49:10 +01:00
alan 5314542c13 Make the Android stage detail a pane and add an artifacts gallery
Turn the stage detail into the rightmost pane of a bounded three-level
stack and show every run artifact in a summary gallery.

- The stage detail opens as a real level-2 pane from both entry points (a
  Timeline row and a graph node). StageDetailPane is wrapped in the same
  Scaffold/TopAppBar with a back arrow as the other panes, and its
  identity/result facts (status, outcome, target, duration, visit, model
  target) render outside any collapsible so a fresh pane is never empty.
  StageDetailSheet, ModalBottomSheet and RightSlidingPanel are removed.
- SlidingPaneStack replaces SlidingMasterDetail: pane 0 fills the host,
  panes 1 and 2 overlay at peek*level, each covered pane keeps one
  tappable peek strip, and MasterPane/backStep/popTo/MAX_PANE_DEPTH are
  the pure model. The peek tap, the pane back arrow, the system Back
  button and the predictive-back gesture all pop exactly one level.
- New pure runArtifactGroups(steps) groups a run's artifacts by stage and
  visit (stable order, duplicates kept, empty run -> empty) and
  artifactsEmptyMessage distinguishes the running "capture pending" case.
  ArtifactGallery renders image thumbnails (tap opens full size) and
  non-image rows with name, size, content type and open/copy; urls resolve
  through ServerUrl, never a hardcoded host.
- Run Summary shows the run gallery and the stage pane shows that visit's
  group, keeping the existing per-visit artifacts summary and notes.
- Tests updated/added (PaneStateTest, SlidingPaneStackTest,
  ArtifactGroupsTest, ArtifactGalleryTest, StageDetailSheetTest, refreshed
  DetailTabsTest/PipelinesNavTest, CollapseRemovalTest kept green) and
  android/README.md records the pass, evidence and not-verified list.
2026-10-15 23:34:36 +01:00
alan 059c85add8 Show per-visit artifacts in the Android client and fix the top inset
Implements four Android-only client changes (no server, Go, installer or
Docker changes; nothing under android/ was left uncommitted).

- Per-visit artifacts: model StageArtifact{name, size_bytes, content_type,
  url} plus artifacts/artifacts_skipped/artifacts_truncated on RunStep with the
  exact internal/protocol/runs.go wire names, covered by ProtocolModelTest.
  Add a dedicated artifacts section to the stage detail sheet: one row per
  file with name, humanBytes size and content type, open (ACTION_VIEW) and
  copy-link actions, resolving the server-relative url against the configured
  server URL (never a hardcoded host) and disabling those actions with a hint
  when none is set. Images render an inline thumbnail with a full-size view on
  tap; other types get a type icon. Empty/partial copy matches the TUI
  ("capture pending", "not recorded for this visit", partial-capture notes).
  Timeline rows carry a subtle AttachFile indicator via a pure hasArtifacts
  helper. Pure helpers (humanBytes, resolveArtifactUrl, isImageContentType,
  artifactsSummary, artifactCaptureNotes, artifactMetaLine) carry unit tests.
- Collapsed defaults and self-describing titles: rememberSectionExpansion now
  tracks the set of expanded keys (default emptySet) so every inner section in
  the run detail and pipeline detail starts collapsed while operator choices
  still persist across configuration changes. Evidence sections are titled
  from the correlated step/stage/visit and backend identity instead of a bare
  index; field sections fall back to their prefix so a blank key never yields
  an empty title. Covered by DetailTabsTest.
- Single top inset: zero the outer Scaffold contentWindowInsets so the inner
  Material 3 app bars own the status-bar inset once; the connection banner
  owns the status-bar inset while visible (NavHost consumes it below), and the
  floating destinations pill clears the navigation bar.
- Publish the debug APK as a run artifact named by the short SHA, documented
  with the verified LAN URL and sha in android/README.md.

Verification (unit tests, assembleDebug, live-server APK and run 55 step 4
artifact fetches, emulator narrow/wide drives) is recorded in android/README.md.
2026-10-15 21:16:18 +01:00
alan d00bd37833 Give every outcome its own colour and reach stage visits from the Timeline
- GraphPalette: a curated fixed palette plus a deterministic outcome-to-index
  mapping (no hashCode() % n); every colour is measured at >= 4.5:1 against the
  dark surface. Node fills differ by kind, and selection inverts the fill.
- Run detail: the Steps tab becomes Timeline, one compact line per recorded
  visit. The stage detail sheet takes the ordered visits plus an
  initialVisitIndex and shows a visit 1..N tab row only when there is more than
  one visit; the timeline opens the tapped visit, the graph the most recent.
- List pane: pipelines and runs share one ListRow (flat surface, thin divider,
  leading element, title plus secondary line) with a tonal selected row, and the
  wide list pane collapses to a 56dp strip.
- Navigation: the bottom bar becomes a floating three-icon destination pill at
  the bottom right with Role.Tab selected semantics, used on both window widths,
  with 88dp reserved so nothing scrolls under it.
- Icons come from the already-declared material-icons-extended; no new
  dependency.

Implemented by pipeline run 55 (pipeline 9 v6). Its ui_reviewer stage failed on a
malformed model result rather than on this work, so the change was verified by
hand: assembleDebug plus 93 unit tests pass, and the run's captures were
reviewed (graph colours per outcome, Timeline entries, visit tabs, selected list
row, floating pill).
2026-10-15 19:16:44 +01:00
alan 370eaaed1f Let the detail tabs collapse and rebuild the step and source layouts
DetailTabs: give every tab a meaningful ImageVector from the core Material
icon set and turn the wide rail into a collapsible one. A rememberSaveable
railExpanded flag plus an accessibility-labelled "Collapse tabs"/"Expand
tabs" control shrink the rail to a narrow icon-only strip and back; the
collapsed tile still names its tab via the icon's content description and
still marks the selected tab by container colour and tab semantics, and the
content box reclaims the rail width. Narrow windows keep the top
PrimaryScrollableTabRow. railWidthDp is a pure, unit-tested predicate.

RunDetailScreen: render a step's metadata as aligned label/value rows
(KeyValueRow) instead of a ragged stack of lines, paired into two columns on
wide windows (status/outcome, duration/visit, target/session, agent/model
target) and a single column on narrow ones. Evidence (input, output,
transcript, file changes, notifications, control diagnostics) fills its card
in full-width monospace with a shared padding/line height, and the vertical
rhythm is one bottom gap per step with no doubled gap for a step without
expandable detail. The timeline glyph and connector stay aligned with the
step title. All previously shown fields are retained.

PipelineDetailScreen/CodeBlock: the Source tab now fills the whole tab area
with the tab's single LazyColumn owning all scrolling (CodeBlock gains an
optional maxHeight = null that renders unbounded; the default bounded
behaviour is unchanged for other callers). It renders the parsed definition
as one collapsible section per stage (key, type) built from the same
stageDefinitionFields/StageFieldRow the stage detail sheet uses, covering
prompt, output, tools, configs, edges (outcomes with resolved targets and
#success/#failure terminals), memory, limits and notify policy while skipping
absent fields. A Raw toggle reveals the exact markdown and a copy action
copies the whole definition.

Extract shared formatting helpers (fileChangeLine, notificationLine,
fileChangesSummary, controlVisitLabel) into Format.kt and expose
StageFieldRow/StageTypeChip/stageDefinitionFields so the sheet and the Source
tab agree. Add StageDetailSheetTest and StepMetaTest, extend DetailTabsTest
(icon distinctness, rail width) and FormatTest, and record the build,
unit-test and emulator-screenshot verification in android/README.md; the
captures stay in the git-ignored android/captures/space_pass/.

Assisted-by: DeepSeek V4.1 Flash
2026-10-15 17:18:05 +01:00
alan 238f3fbdd8 Give every graph edge its own track and open a stage detail sheet on tap
Allocate a distinct source port, target port, across-run lane and vertical
track per edge in the pure layoutGraph (stable edge-id order), mirroring the
TUI's per-edge routing, so no two routes share a row or column; each outcome
label follows its own edge's track. Rewrite routePoints to build every
polyline from those precomputed ports/lanes/tracks instead of shared corridor
constants, keeping runs axis-aligned and the layout deterministic.

Add pure hitTest/toGraphPoint plus a tap detector that maps taps back through
the current transform: tapping a node calls onStageTap, tapping empty space
does nothing, and pan/zoom keep working. Add StageDetailSheet, a Material 3
ModalBottomSheet overlay (near full height, scrollable, responsive on wide
windows) showing the stage definition and, on a run graph, that run's step;
wire it into the pipeline and run graph tabs.

Extend WorkflowGraphTest with the no-shared-collinear-run invariant, distinct
port, determinism and hit-test cases.
2026-10-15 16:46:40 +01:00
alan 1828171a9c Give the detail screens tabs, styled code blocks and a foldable layout
- Pipeline detail and run detail are now tabbed: run detail has Summary, Graph,
  Input, Output, Evidence and Steps, pipeline detail has Summary, Graph and Source,
  with the version list in Summary. The graph gets a tab of its own, so it uses the
  whole content area with its Fit and expand controls. Selection is remembered and
  the tabs carry real tab semantics.
- The code-like blocks (Input, Output, Source, prompt, transcripts) are styled
  content cards with a label header, monospace body, a copy action and a bounded
  height that scrolls internally, instead of a raw bordered div.
- Content inside a tab breaks down into collapsible inner sections (DetailTabs.kt,
  CodeBlock.kt), reusing the existing section component with remembered state.
- Foldable layout is driven by window width (WindowSize.kt): narrow windows keep
  the single-pane tabs, wide windows use list-and-detail side by side with the
  detail capped to a readable width.

Verified: :app:assembleDebug and :app:testDebugUnitTest succeed offline with 60
tests and 0 failures (new WindowSizeTest and DetailTabsTest), and the reviewer
drove every tab plus both a narrow and a wide window on the emulator (captures in
android/captures/tabs_pass/view/). The implementer's own capture set in that
directory is unusable: it wrote screencap's multi-display warning into the files
(they begin with ASCII '[Warning', not the PNG magic), so only the reviewer's
captures were reviewed.
2026-10-15 14:34:49 +01:00
alan e843aa08a8 Restructure the Runs area and add collapsible sticky sections
Four related UI changes, all requested after using the app on a phone.

- Graph pinch zoom is now anchored to the gesture centroid. The handler dropped
  the centroid and the canvas scaled about the content origin, so a pinch slid
  the graph away from the fingers. zoomAbout() keeps the content point under the
  fingers fixed, applies the pan and then clampOffset, with unit tests proving
  the centroid point is unchanged and the scale and bounds are respected.
- Pipeline detail and run detail now use a LazyColumn of collapsible sections
  (shared Sections.kt header, rotating chevron, animateContentSize) whose titles
  stick to the top while their content scrolls beneath, with per-section state
  remembered and exposed to accessibility. Steps and session evidence stay lazy
  list items instead of nested scrollables.
- The Runs list is rebuilt: the raw result preview is gone, failures show a
  two-line diagnostic in the error colour, each run has a colour-coded status
  chip with a matching icon per state (RunStatus.kt, core Material icons - no new
  dependency), the usage aggregates render as a metrics block with a formatted
  average instead of a run-on line of seconds, and runs are grouped by day under
  sticky date headers.
- Run detail steps are a timeline: a status dot joined to the next step, the
  stage and visit number, an outcome chip and the duration, with input, output,
  transcript, file changes and notifications behind a per-step 'Show details'.
- One centralised type hierarchy (Typography.kt) for screen title, section
  header, card title, subtitle, body and monospace data, applied across the list,
  the cards and both detail screens.

Verified: :app:assembleDebug and :app:testDebugUnitTest succeed offline with 53
tests and 0 failures (new FormatTest, RunStatusTest and RunGroupingTest;
WorkflowGraphTest 23 to 27), and the app was driven on the emulator with
screenshots of the runs list states, the sticky date header, the steps timeline,
an expanded step, a collapsed section and the sticky section header.
2026-10-15 03:46:06 +01:00
alan 1a890d8c31 Draw workflow-graph edges as straight runs and give the graph a bigger panel
A user reading the graph on their phone said it was not clear what happened, and
asked for the TUI's straight arrows and a larger panel.

- Edges are now axis-aligned orthogonal polylines instead of Bezier curves: the
  stage-to-stage runs and the routes into the bottom-row #success/#failure
  terminals are horizontal/vertical segments joined at right angles, matching the
  Go TUI's routing, and every arrowhead now points along the direction of its
  final segment instead of the straight source-to-target chord (which pointed
  wrongly as soon as a route turned a corner). Routing is a pure function.
- The graph panel is a sensible share of the window height on both screens
  instead of 360dp/340dp, and a new expand/collapse control beside 'Fit graph to
  view' grows it to nearly the full height.

Verified: :app:assembleDebug and :app:testDebugUnitTest succeed offline with 42
tests and 0 failures (WorkflowGraphTest 15 to 23, covering the orthogonal routing
and arrowhead direction), and the app was driven on the emulator with before/after
screenshots of a pipeline graph, a run graph with the executed route highlighted,
a panned state and the expanded panel.
2026-10-15 02:34:15 +01:00
alan 9ca775291b Give the Android client a dark-first Material 3 look and TUI-style graph terminals
Three UI changes requested after reviewing the first on-device screenshots:

- Dark-first theme: the app now owns its colour scheme instead of following the
  system wallpaper. Theme.kt defaults to a deliberate darkColorScheme built from
  a mint/teal seed with an amber tertiary (new Color.kt) so it matches the dark
  Pipelines TUI; dynamic colour is gone and a complete light scheme is retained
  for when it is explicitly requested. themes.xml/colors.xml give the app a dark
  window background and dark system bars with light icons, so launching never
  flashes light.
- Workflow graph matches the TUI: the #success/#failure terminals now share a
  lower row under the stage row, with arrows entering their top borders and the
  error -> #failure route leaving the bottom of its source stage, mirroring
  internal/tui/graph_layout.go ('Terminals share a lower row...') and graph.go's
  '[FAILURE]   [SUCCESS]' bottom row. Fit-to-content, pan clamping, the Fit
  action, run highlighting and the TalkBack description are preserved.
- More style: consistent Material 3 top app bars for Pipelines, Runs and
  Settings, the new colour scheme applied across the screens and state
  components, and monospace retained for hashes, source and run input/output.

Verified on the host and on the device: :app:compileDebugKotlin, :app:assembleDebug
and :app:testDebugUnitTest succeed offline with 34 tests and 0 failures
(WorkflowGraphTest grew to 15 tests covering the terminal row, bottom exits and
fit/clamp), and the app was run on the Pixel_Fold_API_36 emulator in dark mode
against the live server: the whole 4-stage graph renders with its terminal row,
and the list, detail and settings screens use the new theme.
2026-10-14 12:36:58 +01:00
alan cee9fb2f79 Fix graph fitting, pan bounds, auto-connect and run wording in the Android client
An emulator run against the live server exposed four usability defects and one
legibility defect, all fixed here:

- The workflow graph was not fit-to-content: 3- and 4-stage graphs showed only the
  first columns until the user panned. The initial view now fits and centres the
  whole graph, scaling down when it is wider than the viewport.
- A panned graph could be dragged completely out of view with no way back. Pan is
  now clamped so content stays visible, and a 'Fit graph to view' action restores
  the fitted view.
- The app did not connect on launch even with a saved server URL. It now connects
  from the saved URL using the existing bounded backoff; an explicit Disconnect
  still stays authoritative for the session.
- The runs list said 'N steps' while run detail said 'N recorded visits'. Both now
  use the server's own vocabulary ('N completed visits' / 'N recorded visits')
  through one shared helper in Format.kt.
- Outcome labels: labels are drawn after all curves so none is crossed, dimmed
  labels use onSurfaceVariant, and executed labels no longer resolve to
  near-invisible container accents ('rejected' measured ~1.2:1 before).

Verified: :app:compileDebugKotlin, :app:assembleDebug and :app:testDebugUnitTest
succeed offline with 28 tests and 0 failures (WorkflowGraphTest grew to 9 tests
covering fitScale, clampOffset extremes and label slots), and the app was driven
on the Pixel_Fold_API_36 emulator against the live server with before/after
screenshots and no FATAL or Compose exception in logcat.
2026-10-13 21:55:16 +01:00
alan 2881256af3 Fix workflow-graph crashes and label layout in the Android client
Running the client on an emulator against a live server exposed real defects in the
workflow graph, all fixed here:

- DrawScope.drawText's string overload measured against the draw scope's constraints
  and threw when a node or edge label fell outside them (wide or panned graphs),
  crashing the pipeline-detail and run-detail screens. Both call sites now draw a
  pre-measured TextLayoutResult.
- The graph Canvas was not clipped, so panning drew nodes and edges over the
  'Versions' row and the 'Workflow graph' heading. The viewport now clips its
  children.
- Outcome labels overprinted when a stage had more than one outgoing edge ('error'
  over 'success'). Labels are now laid out in one row per source edge, with a
  backing rect for legibility.
- Stage columns followed an iterative rank relaxation, so graphs with a back edge
  rendered out of order (planner before reviewer). rankStages now returns
  declaration order, matching internal/tui/graph_layout.go.

Verified: :app:compileDebugKotlin, :app:assembleDebug and :app:testDebugUnitTest
succeed offline with 20 tests and 0 failures (new WorkflowGraphTest covers the
rank order and label slots), and the app was driven on the Pixel_Fold_API_36
emulator against the live server with no FATAL or Compose exception in logcat.
2026-10-13 19:23:10 +01:00
alan 9a94eabaa3 Add the native Android client for the Pipelines server
Kotlin and Jetpack Compose Material 3 client that speaks the existing WebSocket
protocol: settings requiring an explicit server URL and workspace, pipeline list and
detail with the workflow graph, run history, run detail and evidence, start and
cancel run, reconnect, and the loading/empty/error/disconnected states. It stores no
credentials and keeps execution, definitions and run history on the server.

Verified on the host: :app:compileDebugKotlin and :app:assembleDebug succeed and
:app:testDebugUnitTest passes 19 tests. Ignore Gradle outputs and re-include the
net.awan.pipelines.data package, which the repository runtime data/ rule would
otherwise exclude.
2026-10-13 17:20:18 +01:00