From fd496a7b20ade62fd2b369de98794d1a5906e0b5 Mon Sep 17 00:00:00 2001 From: Alan Silva Date: Thu, 22 Oct 2026 23:59:13 +0100 Subject: [PATCH] fix(app): mark deep-linked chat sessions read --- .../ui/sessions/chat_sessions_screen.dart | 21 ++++++++ .../sessions/chat_sessions_screen_test.dart | 50 +++++++++++++++++++ 2 files changed, 71 insertions(+) diff --git a/app/lib/features/chat/ui/sessions/chat_sessions_screen.dart b/app/lib/features/chat/ui/sessions/chat_sessions_screen.dart index 1d40e529..4579cf73 100644 --- a/app/lib/features/chat/ui/sessions/chat_sessions_screen.dart +++ b/app/lib/features/chat/ui/sessions/chat_sessions_screen.dart @@ -68,6 +68,7 @@ class _ChatSessionsScreenState extends State { ..refresh(); final _search = TextEditingController(); Timer? _undoTimer; + String? _markedActiveSessionId; @override void initState() { @@ -78,6 +79,7 @@ class _ChatSessionsScreenState extends State { /// Reports the loaded rows at the end of the frame: the destination learns a /// routed row without this screen calling back inside its own build. void _reportSessions() { + _markActiveSessionRead(); if (widget.onSessions == null) return; WidgetsBinding.instance.addPostFrameCallback((_) { if (!mounted) return; @@ -85,10 +87,28 @@ class _ChatSessionsScreenState extends State { }); } + void _markActiveSessionRead() { + final id = widget.activeSessionId; + if (id == null) { + _markedActiveSessionId = null; + return; + } + if (id == _markedActiveSessionId) return; + for (final session in _controller.sessions) { + if (_sessionId(session) != id) continue; + // Mark synchronously so row activation and subsequent list notifications + // cannot write the same read watermark twice. + _markedActiveSessionId = id; + unawaited(_controller.markOpened(session)); + return; + } + } + @override void didUpdateWidget(covariant ChatSessionsScreen oldWidget) { super.didUpdateWidget(oldWidget); _controller.activeSessionId = widget.activeSessionId; + _markActiveSessionRead(); if (oldWidget.gateway != widget.gateway) { _controller.replaceRepository(ChatRepository(widget.gateway)); } else if (oldWidget.syncToken != widget.syncToken) { @@ -141,6 +161,7 @@ class _ChatSessionsScreenState extends State { } void _open(JsonMap session) { + _markedActiveSessionId = _sessionId(session); unawaited(_controller.markOpened(session)); widget.onOpen(session); } diff --git a/app/test/features/chat/ui/sessions/chat_sessions_screen_test.dart b/app/test/features/chat/ui/sessions/chat_sessions_screen_test.dart index eaabd296..366a1512 100644 --- a/app/test/features/chat/ui/sessions/chat_sessions_screen_test.dart +++ b/app/test/features/chat/ui/sessions/chat_sessions_screen_test.dart @@ -1,11 +1,61 @@ +import 'dart:async'; + import 'package:flutter/cupertino.dart'; import 'package:flutter/material.dart'; import 'package:flutter_test/flutter_test.dart'; +import 'package:pipelines_app/core/api_gateway.dart'; import 'chat_test_harness.dart'; import 'fake_chat_gateway.dart'; +import 'package:pipelines_app/features/chat/ui/sessions/chat_sessions_screen.dart'; void main() { + testWidgets('deep-linked active chat is marked read when its row loads', ( + tester, + ) async { + final gateway = FakeChatGateway(); + final localStore = MemoryChatSessionLocalStore(); + final pending = Completer(); + gateway.pendingSessions.add(pending); + const updatedAt = '2026-10-22T12:00:00Z'; + final session = { + 'id': 'deep-linked', + 'title': 'Deep linked chat', + 'directory': '/work', + 'updated_at': updatedAt, + }; + await tester.pumpWidget( + MaterialApp( + home: ChatSessionsScreen( + gateway: gateway, + onOpen: (_) {}, + localStore: localStore, + activeSessionId: 'deep-linked', + ), + ), + ); + await tester.pump(); + + pending.complete({'chat_sessions': [session]}); + await tester.pumpAndSettle(); + expect(localStore.state?.watermark('deep-linked'), greaterThan(0)); + + await tester.pumpWidget( + MaterialApp( + home: ChatSessionsScreen( + gateway: gateway, + onOpen: (_) {}, + localStore: localStore, + ), + ), + ); + await tester.pumpAndSettle(); + await tester.tap(find.byKey(const Key('chat-refresh'))); + await tester.pumpAndSettle(); + expect(find.text('New'), findsNothing); + expect(localStore.state?.watermark('deep-linked'), greaterThan(0)); + }); + testWidgets( 'material list keeps closed starred rows once and groups directories once', (tester) async {