Remove the Runs error counter for now
Keep the running indicator and Needs you flow, but remove the failed-count badge and its tab count plumbing until unseen-state behavior is addressed. Preserve the unfinished seen-state work separately. Verify application, Runs, attention and shell regressions.
This commit is contained in:
@@ -2,9 +2,9 @@ import 'package:flutter_test/flutter_test.dart';
|
||||
import 'package:pipelines_app/features/runs/domain/run_tab_counts.dart';
|
||||
|
||||
void main() {
|
||||
test('running and failed statuses are counted independently', () {
|
||||
test('running work excludes failed and completed runs', () {
|
||||
expect(
|
||||
runTabCounts([
|
||||
runningRunCount([
|
||||
{'status': 'running', 'executing': true},
|
||||
{'status': 'queued', 'executing': true},
|
||||
{'status': 'failed', 'executing': false},
|
||||
@@ -12,30 +12,30 @@ void main() {
|
||||
{'status': 'canceled'},
|
||||
{'status': 'interrupted'},
|
||||
]),
|
||||
(running: 2, failed: 1),
|
||||
2,
|
||||
);
|
||||
});
|
||||
|
||||
test('terminal statuses override stale execution flags', () {
|
||||
expect(
|
||||
runTabCounts([
|
||||
runningRunCount([
|
||||
{'status': 'failed', 'executing': true},
|
||||
{'status': 'succeeded', 'executing': true},
|
||||
]),
|
||||
(running: 0, failed: 1),
|
||||
0,
|
||||
);
|
||||
});
|
||||
|
||||
test('older running summaries work without inventing other live states', () {
|
||||
expect(
|
||||
runTabCounts([
|
||||
runningRunCount([
|
||||
{'status': 'running'},
|
||||
{'status': 'running', 'executing': false},
|
||||
{'status': 'queued'},
|
||||
{'status': 'waiting'},
|
||||
]),
|
||||
(running: 1, failed: 0),
|
||||
1,
|
||||
);
|
||||
expect(runTabCounts([]), (running: 0, failed: 0));
|
||||
expect(runningRunCount([]), 0);
|
||||
});
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user