Remove the Runs error counter for now

Keep the running indicator and Needs you flow, but remove the failed-count badge and its tab count plumbing until unseen-state behavior is addressed. Preserve the unfinished seen-state work separately. Verify application, Runs, attention and shell regressions.
This commit is contained in:
2026-11-11 23:18:30 +00:00
parent aebd549d53
commit fa95c2fcae
13 changed files with 102 additions and 128 deletions
@@ -18,7 +18,7 @@ void main() {
Finder badgeCount(String count) =>
find.descendant(of: find.byType(Badge), matching: find.text(count));
testWidgets('waiting is announced without being labelled as a failed run', (
testWidgets('attention events do not restore the removed error counter', (
tester,
) async {
final semantics = tester.ensureSemantics();
@@ -45,7 +45,7 @@ void main() {
],
);
expect(find.text('Nightly build'), findsWidgets);
expect(tester.widget<Badge>(find.byType(Badge)).isLabelVisible, isFalse);
expect(find.byKey(const ValueKey('shell.badge.runs.failed')), findsNothing);
expect(find.bySemanticsLabel(needingAttention), findsNothing);
await tester.tap(find.byKey(const ValueKey('shell.destination.pipelines')));
@@ -63,16 +63,16 @@ void main() {
await tester.pump();
expect(provider.value.uri.path, '/pipelines');
expect(tester.widget<Badge>(find.byType(Badge)).isLabelVisible, isFalse);
expect(find.byKey(const ValueKey('shell.badge.runs.failed')), findsNothing);
expect(
tester
.widget<RunsDestinationIcon>(find.byType(RunsDestinationIcon))
.failed,
.running,
0,
);
expect(
find.bySemanticsLabel(RegExp('Notifications, 1 needing attention')),
findsOneWidget,
findsNothing,
);
// The decision taken elsewhere clears the badge the same way.
@@ -81,7 +81,7 @@ void main() {
);
await tester.pump();
await tester.pump();
expect(tester.widget<Badge>(find.byType(Badge)).isLabelVisible, isFalse);
expect(find.byKey(const ValueKey('shell.badge.runs.failed')), findsNothing);
expect(badgeCount('1'), findsNothing);
expect(find.bySemanticsLabel(needingAttention), findsNothing);
semantics.dispose();
@@ -98,7 +98,7 @@ void main() {
addTearDown(provider.dispose);
await pumpApp(tester, channel: channel, client: client, provider: provider);
expect(tester.widget<Badge>(find.byType(Badge)).isLabelVisible, isFalse);
expect(find.byKey(const ValueKey('shell.badge.runs.failed')), findsNothing);
channel.incoming.add(
jsonEncode({
@@ -119,7 +119,7 @@ void main() {
expect(
tester
.widget<RunsDestinationIcon>(find.byType(RunsDestinationIcon))
.failed,
.running,
0,
);
});
@@ -10,7 +10,7 @@ import '../core/transport/pipelines_client_test.dart' show FakeChannel;
import 'pipelines_app_test.dart' show pumpApp, replyList;
void main() {
testWidgets('both run counts update while another destination is visible', (
testWidgets('running updates across tabs without restoring the error counter', (
tester,
) async {
SharedPreferences.setMockInitialValues({});
@@ -59,7 +59,7 @@ void main() {
RunsDestinationIcon counts() =>
tester.widget<RunsDestinationIcon>(find.byType(RunsDestinationIcon));
expect(counts().running, 1);
expect(counts().failed, 1);
expect(find.byKey(const ValueKey('shell.badge.runs.failed')), findsNothing);
expect(counts().attention, 2);
await tester.tap(find.byKey(const ValueKey('shell.destination.pipelines')));
@@ -75,7 +75,7 @@ void main() {
await tester.pumpAndSettle();
expect(provider.value.uri.path, '/pipelines');
expect(counts().running, 1);
expect(counts().failed, 2);
expect(find.byKey(const ValueKey('shell.badge.runs.failed')), findsNothing);
// Waiting -> failed must repaint even though total attention is unchanged.
expect(counts().attention, 2);
@@ -89,7 +89,7 @@ void main() {
);
await tester.pumpAndSettle();
expect(counts().running, 0);
expect(counts().failed, 2);
expect(find.byKey(const ValueKey('shell.badge.runs.failed')), findsNothing);
expect(tester.takeException(), isNull);
});
}