Remove the Runs error counter for now
Keep the running indicator and Needs you flow, but remove the failed-count badge and its tab count plumbing until unseen-state behavior is addressed. Preserve the unfinished seen-state work separately. Verify application, Runs, attention and shell regressions.
This commit is contained in:
@@ -71,7 +71,7 @@ bool shouldReconnectOnForeground(ConnectionKind kind) =>
|
||||
///
|
||||
/// Tests may inject the client and route-information provider; the session
|
||||
/// owns the socket either way, so there is never a second app-level connection.
|
||||
typedef _RunIndicators = ({int attention, int running, int failed});
|
||||
typedef _RunIndicators = ({int attention, int running});
|
||||
|
||||
class PipelinesApp extends StatefulWidget {
|
||||
const PipelinesApp({
|
||||
@@ -209,7 +209,6 @@ class _PipelinesAppState extends State<PipelinesApp>
|
||||
final _attentionCount = ValueNotifier<_RunIndicators>((
|
||||
attention: 0,
|
||||
running: 0,
|
||||
failed: 0,
|
||||
));
|
||||
|
||||
/// Android background delivery (no service elsewhere).
|
||||
@@ -565,11 +564,9 @@ class _PipelinesAppState extends State<PipelinesApp>
|
||||
/// frame arrives outside any build and applies at once.
|
||||
void _attentionChanged() {
|
||||
if (!mounted) return;
|
||||
final statuses = runTabCounts(_attention.rows);
|
||||
final count = (
|
||||
attention: _attention.entries.length,
|
||||
running: statuses.running,
|
||||
failed: statuses.failed,
|
||||
running: runningRunCount(_attention.rows),
|
||||
);
|
||||
if (count == _attentionCount.value) return;
|
||||
if (SchedulerBinding.instance.schedulerPhase ==
|
||||
@@ -826,7 +823,6 @@ class _PipelinesAppState extends State<PipelinesApp>
|
||||
],
|
||||
attentionCount: counts.attention,
|
||||
runningRunCount: counts.running,
|
||||
failedRunCount: counts.failed,
|
||||
destination: _destinationOf(route.kind),
|
||||
onDestinationSelected: _selectDestination,
|
||||
onClosePage: () => _delegate.goTo(
|
||||
|
||||
Reference in New Issue
Block a user