Bind both Docker services to 0.0.0.0 by default

This commit is contained in:
2026-10-09 22:07:46 +01:00
parent de3a3c2363
commit f3d829bea5
8 changed files with 59 additions and 17 deletions
+21 -2
View File
@@ -53,7 +53,7 @@ class DockerSetupTests(unittest.TestCase):
setup.Setup(directory).settings(setup.arguments([]))
text=Path(directory,".env").read_text()
self.assertIn("NTFY_BASE_URL=http://192.168.1.25:8090\n",text)
self.assertIn("NTFY_BIND_ADDRESS=192.168.1.25\n",text)
self.assertIn("NTFY_BIND_ADDRESS=0.0.0.0\n",text)
self.assertIn("TZ=Europe/London\n",text)
def test_timezone_fallback_does_not_prompt(self):
@@ -118,7 +118,11 @@ class DockerSetupTests(unittest.TestCase):
before = [p.read_bytes() for p in files]
calls, _ = self.exercise(directory, existing=True)
self.assertFalse(any("login" in c or "token" in c for c in calls))
self.assertEqual(before, [p.read_bytes() for p in files])
self.assertEqual(before[1],files[1].read_bytes())
self.assertEqual(files[0].read_bytes(),before[0].replace(b"NTFY_BIND_ADDRESS=192.168.1.20",b"NTFY_BIND_ADDRESS=0.0.0.0")+b"PIPELINES_BIND_ADDRESS=0.0.0.0\n")
normalized=files[0].read_bytes()
self.exercise(directory,existing=True)
self.assertEqual(normalized,files[0].read_bytes())
def test_login_failure_or_cancel_does_not_mark_complete_or_start_server(self):
for fail, confirm in [("login", "yes"), (None, "no")]:
@@ -141,6 +145,21 @@ class DockerSetupTests(unittest.TestCase):
setup.Setup(directory).settings(setup.arguments(["--ntfy-url", "https://example.com"]))
self.assertEqual(path.read_text(), "existing settings")
def test_existing_env_rejects_unsafe_bind_override(self):
with tempfile.TemporaryDirectory() as directory:
path=Path(directory,".env");path.write_text("NTFY_BIND_ADDRESS=127.0.0.1\n")
with self.assertRaises(ValueError):
setup.Setup(directory).settings(setup.arguments(["--bind-address","0.0.0.0\nOTHER=bad"]))
self.assertEqual(path.read_text(),"NTFY_BIND_ADDRESS=127.0.0.1\n")
def test_existing_env_symlink_is_not_modified(self):
with tempfile.TemporaryDirectory() as directory:
target=Path(directory,"custom.env");target.write_text("keep")
Path(directory,".env").symlink_to(target)
with self.assertRaises(ValueError):
setup.Setup(directory).settings(setup.arguments([]))
self.assertEqual(target.read_text(),"keep")
if __name__ == "__main__":
unittest.main()