From f3d6013ef5f30d6e57e53e33fea4dd5dd91f3313 Mon Sep 17 00:00:00 2001 From: Alan Silva Date: Wed, 11 Nov 2026 03:04:27 +0000 Subject: [PATCH] Remove Cupertino variants from runs sheet tests Keep the runs sheet coverage focused on the Material-only app path and remove obsolete Cupertino hosts and loop variants. --- .../features/runs/ui/runs_sheets_test.dart | 78 ++++++++----------- 1 file changed, 31 insertions(+), 47 deletions(-) diff --git a/app/test/features/runs/ui/runs_sheets_test.dart b/app/test/features/runs/ui/runs_sheets_test.dart index 973c1436..cd6f1d28 100644 --- a/app/test/features/runs/ui/runs_sheets_test.dart +++ b/app/test/features/runs/ui/runs_sheets_test.dart @@ -1,6 +1,5 @@ import 'dart:async'; -import 'package:flutter/cupertino.dart'; import 'package:flutter/material.dart'; import 'package:flutter_test/flutter_test.dart'; import 'package:pipelines_app/core/api_gateway.dart'; @@ -39,11 +38,7 @@ void main() { await gateway.framesController.close(); }); - Future mount( - WidgetTester tester, { - required bool cupertino, - String? createdAt, - }) async { + Future mount(WidgetTester tester, {String? createdAt}) async { tester.view.physicalSize = const Size(800, 1400); tester.view.devicePixelRatio = 1; addTearDown(tester.view.resetPhysicalSize); @@ -67,54 +62,44 @@ void main() { builder: (context, _) => RunsList(controller: controller, onSelected: (_) {}), ); - await tester.pumpWidget( - cupertino - ? CupertinoApp(home: CupertinoPageScaffold(child: list)) - : MaterialApp(home: Scaffold(body: list)), - ); + await tester.pumpWidget(MaterialApp(home: Scaffold(body: list))); await tester.pumpAndSettle(); } - for (final cupertino in [false, true]) { - final host = cupertino ? 'Cupertino' : 'Material'; + testWidgets('filter sheet has a header whose Done closes it', (tester) async { + await mount(tester); + await tester.tap(find.byKey(const ValueKey('runs.filter'))); + await tester.pumpAndSettle(); - testWidgets('$host filter sheet has a header whose Done closes it', ( - tester, - ) async { - await mount(tester, cupertino: cupertino); - await tester.tap(find.byKey(const ValueKey('runs.filter'))); - await tester.pumpAndSettle(); + expect(find.byType(AppSheetHeader), findsOneWidget); + expect( + find.descendant( + of: find.byType(AppSheetHeader), + matching: find.text(runsFilterTitle), + ), + findsOneWidget, + ); + expect(find.text('Queued'), findsOneWidget); + expect(find.text('queued'), findsNothing); + expect(find.byKey(runsFilterClearKey), findsNothing); - expect(find.byType(AppSheetHeader), findsOneWidget); - expect( - find.descendant( - of: find.byType(AppSheetHeader), - matching: find.text(runsFilterTitle), - ), - findsOneWidget, - ); - expect(find.text('Queued'), findsOneWidget); - expect(find.text('queued'), findsNothing); - expect(find.byKey(runsFilterClearKey), findsNothing); + await tester.tap(find.text('Last 7 days')); + await tester.pumpAndSettle(); + expect(controller.timeRange, 'last_7_days'); + // An active filter offers Clear in the header. + expect(find.byKey(runsFilterClearKey), findsOneWidget); - await tester.tap(find.text('Last 7 days')); - await tester.pumpAndSettle(); - expect(controller.timeRange, 'last_7_days'); - // An active filter offers Clear in the header. - expect(find.byKey(runsFilterClearKey), findsOneWidget); - - await tester.tap(find.byKey(runsFilterDoneKey)); - await tester.pumpAndSettle(); - expect(find.byKey(const ValueKey('runs.filter.sheet')), findsNothing); - // The applied chip reads in sentence case too. - expect(find.textContaining('Last 7 days'), findsOneWidget); - }); - } + await tester.tap(find.byKey(runsFilterDoneKey)); + await tester.pumpAndSettle(); + expect(find.byKey(const ValueKey('runs.filter.sheet')), findsNothing); + // The applied chip reads in sentence case too. + expect(find.textContaining('Last 7 days'), findsOneWidget); + }); testWidgets('Material single-choice groups are check rows, not checkboxes', ( tester, ) async { - await mount(tester, cupertino: false); + await mount(tester); await tester.tap(find.byKey(const ValueKey('runs.filter'))); await tester.pumpAndSettle(); @@ -139,7 +124,7 @@ void main() { }); testWidgets('Material sort opens an anchored choice menu', (tester) async { - await mount(tester, cupertino: false); + await mount(tester); await tester.tap(find.byKey(const ValueKey('runs.sort'))); await tester.pumpAndSettle(); expect(find.byKey(const ValueKey('app-choice-menu')), findsOneWidget); @@ -153,7 +138,6 @@ void main() { ) async { await mount( tester, - cupertino: false, createdAt: DateTime(2020, 1, 1).toIso8601String(), ); await tester.tap(find.byKey(const ValueKey('runs.stats'))); @@ -171,7 +155,7 @@ void main() { testWidgets('the 7-day chart shows bars over an axis when runs started', ( tester, ) async { - await mount(tester, cupertino: true); + await mount(tester); await tester.tap(find.byKey(const ValueKey('runs.stats'))); await tester.pumpAndSettle(); expect(find.byKey(const ValueKey('runs.stats.days')), findsOneWidget);