Merge: no UI-review auto-skip without complete change capture; capture lists over-budget changes
# Conflicts: # internal/protocol/runs.go
This commit is contained in:
@@ -665,6 +665,13 @@ total as input tokens. The
|
||||
CLI is the deliverable; a TUI picker for choosing overrides is a documented
|
||||
follow-up, not half-built.
|
||||
|
||||
The run detail (`inspect <id> --json`, `get_run`) also carries an additive
|
||||
top-level `warnings` string list, derived at read time from the steps; `inspect`
|
||||
repeats each entry on stderr as `warning: ...`. Today it names every visit whose
|
||||
retained file-change capture was `partial` or `unavailable`, because such a
|
||||
capture is not a complete workspace diff and disables the server skip fallback
|
||||
(see [stage-file-diffs.md](stage-file-diffs.md)). Older peers ignore the field.
|
||||
|
||||
|
||||
On either the runs list or run inspector, press `P` (or use `:pipeline`) to open
|
||||
the selected run's exact pipeline version. Navigation does not cancel the run.
|
||||
|
||||
@@ -26,10 +26,21 @@ includes the same evidence under each step's `file_changes` field.
|
||||
`secrets/`, Git internals and `node_modules/` are excluded. This is a path-based
|
||||
precaution, **not secret-content scanning**; ordinary source patches may contain
|
||||
sensitive text and become part of retained history.
|
||||
- Limits: 10,000 inventoried entries, 1 MiB per file, 32 MiB per snapshot,
|
||||
five seconds per snapshot, 5,000 combined lines per textual comparison,
|
||||
64 KiB per patch and 128 KiB serialized file evidence per visit. Oversized,
|
||||
unreadable, omitted or truncated evidence is explicitly flagged partial.
|
||||
- Limits: 10,000 inventoried entries, 1 MiB per file and 32 MiB per snapshot of
|
||||
retained text, 256 MiB per hashed file, five seconds per snapshot, 5,000
|
||||
combined lines per textual comparison, 64 KiB per patch and 128 KiB serialized
|
||||
file evidence per visit. Oversized, unreadable, omitted or truncated evidence
|
||||
is explicitly flagged partial.
|
||||
- Over-budget content degrades to a listing, not silence: a text file over 1 MiB,
|
||||
or beyond the 32 MiB snapshot budget, is still compared by SHA-256 and a change
|
||||
is listed with `no_patch: true` (and `truncated`) but no patch. In a Git working
|
||||
tree, a path the snapshot could not compare at all (above 256 MiB, unreadable,
|
||||
or past the time/file limit) is listed the same way when its
|
||||
`git status --porcelain` entry changed during the visit; a path dirty with the
|
||||
same status before and after cannot be proven changed and stays in `skipped`.
|
||||
Git is only read (`--no-optional-locks`); protected paths are never listed.
|
||||
- `pipelines inspect RUN_ID --json` carries a top-level `warnings` list (also
|
||||
printed to stderr) naming every visit whose capture was partial or unavailable.
|
||||
- Failed/canceled stages still retain changes when execution returns. Unconfirmed
|
||||
agent cleanup is flagged partial. A server/process crash cannot guarantee an
|
||||
after-snapshot; recovered steps without capture say “not recorded.”
|
||||
@@ -41,3 +52,24 @@ includes the same evidence under each step's `file_changes` field.
|
||||
|
||||
Snapshots are transient server memory. The database retains patches/metadata,
|
||||
not full copies of every workspace file. No new model calls are used for capture.
|
||||
|
||||
## Server skip fallback
|
||||
|
||||
A non-human stage that declares a `skipped` edge (typically a UI reviewer) is
|
||||
completed by the server without a model call, and routed along `skipped`, only
|
||||
when every earlier visit of the run recorded a **complete** capture with **no**
|
||||
changed files and no image artifact. The step's verdict reason begins
|
||||
"Server fallback skip (no model run):" and has `reason_source: fallback`.
|
||||
|
||||
Everything else runs the stage's model, which may still choose `skipped` itself:
|
||||
|
||||
- any recorded file change, whatever its path or extension (no repository layout
|
||||
or "non-UI" extension list is assumed: Go TUIs, Flutter `.dart`, Kotlin, Swift,
|
||||
templates, strings and config files can all be rendered surface);
|
||||
- any partial or unavailable capture, or a visit with no capture (a crash, a
|
||||
historical row, a human decision during which the workspace was unobserved, or
|
||||
a checkpoint-retry prefix);
|
||||
- `auto_skip=false` in the stage's `configs`.
|
||||
|
||||
A wrong run costs one model call; a wrong skip would ship an unreviewed change, so
|
||||
absent or partial evidence is never read as "nothing changed".
|
||||
|
||||
Reference in New Issue
Block a user