From e5403ae257bf0c3fbf332fcc0608f81511f054f0 Mon Sep 17 00:00:00 2001 From: Alan Silva Date: Fri, 13 Nov 2026 12:38:27 +0000 Subject: [PATCH] Open a run or pipeline in a new chat The run and pipeline More menus offer Open in chat: a new chat in the run's (or the pipeline's latest run's) workspace opens on the Chat tab with a draft naming the run or pipeline and how to inspect or change it. --- app/lib/application/open_in_chat.dart | 74 +++++ app/lib/application/pipelines_app.dart | 66 +++- .../application/pipelines_destination.dart | 9 + app/lib/application/runs_destination.dart | 4 + app/lib/features/chat/chat_pane_content.dart | 1 + app/lib/features/chat/chat_runtime.dart | 4 + .../chat/conversation/chat_thread_view.dart | 7 + .../features/pipelines/pipeline_models.dart | 3 + app/lib/features/pipelines/screen.dart | 17 +- .../widgets/pipeline_archive_action.dart | 29 +- .../widgets/pipeline_detail_panel.dart | 16 +- .../widgets/pipeline_list_panel.dart | 25 +- app/lib/features/runs/screen.dart | 4 + app/lib/features/runs/ui/run_detail_view.dart | 3 + app/lib/features/runs/ui/run_list_row.dart | 9 +- app/lib/features/runs/ui/run_more_menu.dart | 23 +- app/lib/features/runs/ui/runs_list.dart | 6 +- app/notes/open-in-chat.md | 21 ++ app/test/application/open_in_chat_test.dart | 296 ++++++++++++++++++ app/tool/search_selection_probe_entry.dart | 78 +++++ 20 files changed, 680 insertions(+), 15 deletions(-) create mode 100644 app/lib/application/open_in_chat.dart create mode 100644 app/notes/open-in-chat.md create mode 100644 app/test/application/open_in_chat_test.dart diff --git a/app/lib/application/open_in_chat.dart b/app/lib/application/open_in_chat.dart new file mode 100644 index 00000000..5d82c846 --- /dev/null +++ b/app/lib/application/open_in_chat.dart @@ -0,0 +1,74 @@ +import 'package:flutter/material.dart'; + +import '../core/api_gateway.dart'; +import '../features/chat/chat_runtime.dart'; +import '../features/chat/ui/sessions/chat_create_fields.dart'; +import '../features/settings/settings_store.dart'; + +typedef OpenInChat = Future Function(BuildContext context); + +String runChatReference(JsonMap run) { + final id = run['id']; + // A run summary names its pipeline in `name`; `title` is the run's own + // title, empty for an untitled run. + final title = '${run['title'] ?? ''}'.trim(); + final pipeline = + '${run['pipeline_name'] ?? run['pipeline'] ?? run['name'] ?? ''}'.trim(); + final version = '${run['pipeline_version'] ?? run['version'] ?? ''}'.trim(); + final status = '${run['status'] ?? ''}'.trim(); + return 'About Pipelines run #$id "${title.isEmpty ? 'Run $id' : title}" ' + '(pipeline "${pipeline.isEmpty ? 'unknown' : pipeline}" ' + 'v${version.isEmpty ? '?' : version}, status $status). ' + 'Inspect it with `pipelines inspect $id`.'; +} + +String pipelineChatReference(int id, String name, int version) => + 'About pipeline "$name" (id $id, version $version). ' + 'Show it with `pipelines show "$name"`; to change it, draft with ' + '`pipelines edit` and publish with `pipelines submit`.'; + +/// Creates and opens a chat without showing the general-purpose create dialog. +/// The caller supplies the already-resolved directory so run and pipeline +/// screens can apply their own workspace provenance rules. +Future openReferenceInChat({ + required BuildContext context, + required ChatRuntime runtime, + required ValueChanged selectChat, + required String directory, + required String title, + required String draft, +}) async { + try { + // Match the New chat dialog: prefer OpenCode when it is available, but + // use the first server-advertised harness on installations where it is + // not. Do not invent a backend when the catalog cannot be read. + final backends = await runtime.sessions.repository.backends(); + final backend = backends.contains('opencode') ? 'opencode' : backends.first; + final session = await runtime.sessions.createOrThrow( + title: title, + directory: directory.trim().isEmpty ? chatHomeDirectory : directory, + backend: backend, + instructions: '', + operationId: 'open-in-chat-${DateTime.now().microsecondsSinceEpoch}', + ); + final id = '${session['id'] ?? ''}'; + if (id.isEmpty) throw StateError('The new chat has no id.'); + runtime.opened[id] = session; + runtime.pendingDrafts[id] = draft; + selectChat(id); + runtime.composerFocus.request(id); + } catch (error) { + if (context.mounted) { + ScaffoldMessenger.of( + context, + ).showSnackBar(SnackBar(content: Text('Could not open in chat: $error'))); + } + } +} + +Future settingsWorkspace(String serverId) async { + final values = await SharedPreferencesSettingsStore( + serverId: serverId, + ).load(); + return values.workspace.trim(); +} diff --git a/app/lib/application/pipelines_app.dart b/app/lib/application/pipelines_app.dart index 9be09ded..0dc0f545 100644 --- a/app/lib/application/pipelines_app.dart +++ b/app/lib/application/pipelines_app.dart @@ -7,7 +7,7 @@ import '../features/runs/domain/run_tab_counts.dart'; import 'package:flutter/foundation.dart'; import 'package:flutter/scheduler.dart'; -import 'package:flutter/widgets.dart'; +import 'package:flutter/material.dart'; import '../core/api_gateway.dart'; import '../core/servers/server_scope.dart'; @@ -48,6 +48,8 @@ import '../shell/windows/window_store.dart'; import 'app_terminals.dart'; import '../features/chat/chat_runtime.dart'; import '../features/chat/windows/chat_windows.dart'; +import 'open_in_chat.dart'; +import '../features/pipelines/pipeline_models.dart'; import '../features/chat/workspace/chat_float_store.dart'; import '../features/terminal/terminal_layout.dart'; import 'app_route.dart'; @@ -144,6 +146,63 @@ class PipelinesApp extends StatefulWidget { class _PipelinesAppState extends State with WidgetsBindingObserver { + Future _openRunInChat(BuildContext context, JsonMap run) async { + try { + final directory = '${run['workspace'] ?? run['directory'] ?? ''}'.trim(); + final fallback = directory.isEmpty + ? await settingsWorkspace(serverIdentity(_session.gateway) ?? '') + : directory; + if (!context.mounted) return; + await openReferenceInChat( + context: context, + runtime: _chatRuntime, + selectChat: (id) => _delegate.goTo(AppRoute.chatSession(id)), + directory: fallback, + title: + 'Run #${run['id']}: ${'${run['title'] ?? run['name'] ?? ''}'.trim()}', + draft: runChatReference(run), + ); + } catch (error) { + if (context.mounted) { + ScaffoldMessenger.of(context).showSnackBar( + SnackBar(content: Text('Could not open in chat: $error')), + ); + } + } + } + + Future _openPipelineInChat( + BuildContext context, + PipelineSummary pipeline, + PipelineRun? latestRun, + ) async { + try { + final directory = latestRun?.workspace.trim() ?? ''; + final fallback = directory.isEmpty + ? await settingsWorkspace(serverIdentity(_session.gateway) ?? '') + : directory; + if (!context.mounted) return; + await openReferenceInChat( + context: context, + runtime: _chatRuntime, + selectChat: (id) => _delegate.goTo(AppRoute.chatSession(id)), + directory: fallback, + title: 'Pipeline: ${pipeline.displayName}', + draft: pipelineChatReference( + pipeline.id, + pipeline.displayName, + pipeline.version, + ), + ); + } catch (error) { + if (context.mounted) { + ScaffoldMessenger.of(context).showSnackBar( + SnackBar(content: Text('Could not open in chat: $error')), + ); + } + } + } + late final AppSession _session; late final AppRouterDelegate _delegate; late final ElevationPrompt _elevationPrompt = elevationDialogPrompt( @@ -941,6 +1000,10 @@ class _PipelinesAppState extends State _delegate.goTo(AppRoute.runsForPipeline(id)), onOpenSchedules: _delegate.openSchedules, onOpenSettings: () => _delegate.goTo(AppRoute.settings), + onOpenInChat: (context, detail, run) => + _openPipelineInChat(context, detail, run), + onOpenPipelineInChat: (context, summary, run) => + _openPipelineInChat(context, summary, run), // The open pipeline is part of the route, so Back steps out of it. onSelectionChanged: (id) { final current = _delegate.route; @@ -983,6 +1046,7 @@ class _PipelinesAppState extends State ), onOpenPipeline: (id, version) => _delegate.goTo(AppRoute.pipeline(id, version: version)), + onOpenInChat: _openRunInChat, ), ), AppDestination.chat: (_) => ChatDestination( diff --git a/app/lib/application/pipelines_destination.dart b/app/lib/application/pipelines_destination.dart index 52dc3774..004c5777 100644 --- a/app/lib/application/pipelines_destination.dart +++ b/app/lib/application/pipelines_destination.dart @@ -1,6 +1,7 @@ import 'package:flutter/material.dart'; import '../features/pipelines/screen.dart'; +import '../features/pipelines/pipeline_models.dart'; import '../ui/adaptive/top_bar_notices.dart'; import 'app_session.dart'; import 'connection_status.dart'; @@ -29,6 +30,8 @@ class PipelinesDestination extends StatelessWidget { this.initialVersion = 0, this.initialStageKey, this.legacyPendingEndpoints = const [], + this.onOpenInChat, + this.onOpenPipelineInChat, }); final AppSession session; @@ -58,6 +61,10 @@ class PipelinesDestination extends StatelessWidget { /// The definition stage a deep link names, or null for no stage request. final String? initialStageKey; final List legacyPendingEndpoints; + final Future Function(BuildContext, PipelineDetail, PipelineRun?)? + onOpenInChat; + final Future Function(BuildContext, PipelineSummary, PipelineRun?)? + onOpenPipelineInChat; @override Widget build(BuildContext context) => AnimatedBuilder( @@ -91,6 +98,8 @@ class PipelinesDestination extends StatelessWidget { onOpenSchedules: onOpenSchedules, onOpenSettings: onOpenSettings, onSelectionChanged: onSelectionChanged, + onOpenInChat: onOpenInChat, + onOpenPipelineInChat: onOpenPipelineInChat, initialPipelineId: initialPipelineId, initialVersion: initialVersion, initialStageKey: initialStageKey, diff --git a/app/lib/application/runs_destination.dart b/app/lib/application/runs_destination.dart index afde6946..a66271c2 100644 --- a/app/lib/application/runs_destination.dart +++ b/app/lib/application/runs_destination.dart @@ -10,6 +10,7 @@ import 'app_session.dart'; import 'connection_status.dart'; import 'pending_run_scope.dart'; import 'server_endpoint.dart'; +import '../core/api_gateway.dart'; /// The Runs destination: the loaded screen plus an honest connection status. /// @@ -34,6 +35,7 @@ class RunsDestination extends StatelessWidget { this.listRefreshToken = 0, this.notifications, this.attention, + this.onOpenInChat, }); final AppSession session; @@ -65,6 +67,7 @@ class RunsDestination extends StatelessWidget { /// The app-level attention controller the shell's Runs tab badge reads. final AttentionController? attention; + final Future Function(BuildContext, JsonMap)? onOpenInChat; @override Widget build(BuildContext context) => AnimatedBuilder( @@ -109,5 +112,6 @@ class RunsDestination extends StatelessWidget { onBack: onBack, onPipelineFilterChanged: onPipelineFilterChanged, onOpenPipeline: onOpenPipeline, + onOpenInChat: onOpenInChat, ); } diff --git a/app/lib/features/chat/chat_pane_content.dart b/app/lib/features/chat/chat_pane_content.dart index ee3486ca..86d06e4a 100644 --- a/app/lib/features/chat/chat_pane_content.dart +++ b/app/lib/features/chat/chat_pane_content.dart @@ -91,6 +91,7 @@ Widget buildChatPaneContent({ sessionId: sessionId, title: '${row?['title'] ?? ''}'.trim(), session: row, + initialDraft: runtime.pendingDrafts.remove(sessionId), syncToken: placement.syncToken, scrollPositions: runtime.scrollPositions, transcripts: runtime.transcripts, diff --git a/app/lib/features/chat/chat_runtime.dart b/app/lib/features/chat/chat_runtime.dart index 3c71cdc5..8b8585f2 100644 --- a/app/lib/features/chat/chat_runtime.dart +++ b/app/lib/features/chat/chat_runtime.dart @@ -96,6 +96,10 @@ class ChatRuntime extends ChangeNotifier { /// link) resolves the same row without a second list request. final Map opened = {}; + /// Drafts seeded by an external action such as Open in chat. They are + /// consumed by the first composer for that session. + final Map pendingDrafts = {}; + /// Each row as the list last reported it (without its live `running`), so /// [adoptRows] adopts only what a re-read changed. final Map _listed = {}; diff --git a/app/lib/features/chat/conversation/chat_thread_view.dart b/app/lib/features/chat/conversation/chat_thread_view.dart index d5420a5a..9c923312 100644 --- a/app/lib/features/chat/conversation/chat_thread_view.dart +++ b/app/lib/features/chat/conversation/chat_thread_view.dart @@ -114,6 +114,7 @@ class ChatThreadView extends StatefulWidget { this.scrollPositions, this.transcripts, this.initialNotice, + this.initialDraft, this.onNewSession, this.onSessionRenamed, this.onSessionClosed, @@ -157,6 +158,9 @@ class ChatThreadView extends StatefulWidget { /// the `/new` notice for a session it just created and opened. final String? initialNotice; + /// A draft supplied by an external deep action; it is never sent. + final String? initialDraft; + /// `/new` moved this chat to a fresh native session; the destination swaps /// the row in place, opens the new id with the notice and refreshes the /// list. Without a destination the notice shows here instead. @@ -528,6 +532,9 @@ class _ChatThreadViewState extends State { onAccepted: (send, queued) => _controller.promptAccepted(send.operationId, queued: queued), ); + if (widget.initialDraft != null) { + unawaited(composer.setDraft(widget.initialDraft!)); + } // A message a previous visit sent but never saw accepted comes back as // "Not sent" unless the history read shows the server has it. unawaited( diff --git a/app/lib/features/pipelines/pipeline_models.dart b/app/lib/features/pipelines/pipeline_models.dart index ad0d2b49..09c97847 100644 --- a/app/lib/features/pipelines/pipeline_models.dart +++ b/app/lib/features/pipelines/pipeline_models.dart @@ -224,6 +224,7 @@ class PipelineRun { required this.createdAt, required this.finishedAt, required this.executing, + this.workspace = '', }); factory PipelineRun.fromJson(PipelineJson json) => PipelineRun( @@ -233,6 +234,7 @@ class PipelineRun { createdAt: _string(json['created_at']), finishedAt: _string(json['finished_at']), executing: json['executing'] == true, + workspace: '${json['workspace'] ?? ''}', ); final int id; @@ -241,6 +243,7 @@ class PipelineRun { final String createdAt; final String finishedAt; final bool executing; + final String workspace; } /// Timestamps decide recency; a higher run id breaks an exact tie or two bad diff --git a/app/lib/features/pipelines/screen.dart b/app/lib/features/pipelines/screen.dart index 55188ee9..523ae975 100644 --- a/app/lib/features/pipelines/screen.dart +++ b/app/lib/features/pipelines/screen.dart @@ -41,6 +41,8 @@ class PipelinesScreen extends StatefulWidget { this.initialPipelineId, this.initialVersion = 0, this.initialStageKey, + this.onOpenInChat, + this.onOpenPipelineInChat, }); final ApiGateway gateway; @@ -87,6 +89,10 @@ class PipelinesScreen extends StatefulWidget { /// pane; a key the pinned version does not declare opens the Graph tab with /// nothing selected. Null keeps the ordinary default tab. final String? initialStageKey; + final Future Function(BuildContext, PipelineDetail, PipelineRun?)? + onOpenInChat; + final Future Function(BuildContext, PipelineSummary, PipelineRun?)? + onOpenPipelineInChat; @override State createState() => _PipelinesScreenState(); @@ -235,6 +241,7 @@ class _PipelinesScreenState extends State { showBack: false, onRunStarted: widget.onRunStarted, onViewPipelineRuns: widget.onViewPipelineRuns, + onOpenInChat: widget.onOpenInChat, stageKey: stageKey, stagePipelineId: widget.initialPipelineId, stageVersion: widget.initialVersion, @@ -252,12 +259,18 @@ class _PipelinesScreenState extends State { ); if (!wide) { return ContentWidth( - child: PipelineListPanel(controller: _controller), + child: PipelineListPanel( + controller: _controller, + onOpenInChat: widget.onOpenPipelineInChat, + ), ); } return ListDetailPanes( list: ContentWidth( - child: PipelineListPanel(controller: _controller), + child: PipelineListPanel( + controller: _controller, + onOpenInChat: widget.onOpenPipelineInChat, + ), ), detailIdentity: _controller.selectedId, detail: _controller.hasSelection diff --git a/app/lib/features/pipelines/widgets/pipeline_archive_action.dart b/app/lib/features/pipelines/widgets/pipeline_archive_action.dart index 59919ad2..18e7e06f 100644 --- a/app/lib/features/pipelines/widgets/pipeline_archive_action.dart +++ b/app/lib/features/pipelines/widgets/pipeline_archive_action.dart @@ -18,17 +18,29 @@ String archiveConfirmation(String name) => Widget pipelineActionsMenu( BuildContext context, PipelinesController controller, - PipelineDetail detail, -) { + PipelineDetail detail, { + Future Function(BuildContext, PipelineDetail, PipelineRun?)? + onOpenInChat, +}) { final archived = detail.archived; final label = archived ? 'Unarchive' : 'Archive…'; void run(BuildContext context) => archiveOrUnarchive(context, controller, detail); return SegmentedOverflowAction( overflowEntry: SegmentedOverflowEntry( - label: archived ? 'Unarchive pipeline' : 'Archive pipeline…', + label: 'Pipeline actions', icon: Icons.archive_outlined, - onPressed: () => run(context), + choices: [ + SegmentedMenuChoice( + label: archived ? 'Unarchive pipeline' : 'Archive pipeline…', + onSelected: () => run(context), + ), + if (onOpenInChat != null) + SegmentedMenuChoice( + label: 'Open in chat', + onSelected: () => onOpenInChat(context, detail, null), + ), + ], ), child: AppOverflowMenu( key: const Key('pipeline-actions-menu'), @@ -40,8 +52,15 @@ Widget pipelineActionsMenu( value: true, label: label, ), + if (onOpenInChat != null) + const AppMenuAction( + value: false, + label: 'Open in chat', + icon: Icons.chat_bubble_outline, + ), ], - onSelected: (context, _) => run(context), + onSelected: (context, value) => + value ? run(context) : onOpenInChat!(context, detail, null), ), ); } diff --git a/app/lib/features/pipelines/widgets/pipeline_detail_panel.dart b/app/lib/features/pipelines/widgets/pipeline_detail_panel.dart index 9a26ecc0..d4b5ec37 100644 --- a/app/lib/features/pipelines/widgets/pipeline_detail_panel.dart +++ b/app/lib/features/pipelines/widgets/pipeline_detail_panel.dart @@ -45,6 +45,7 @@ class PipelineDetailPanel extends StatefulWidget { this.stagePipelineId, this.stageVersion = 0, this.stageRequest = 0, + this.onOpenInChat, }) : assert( stageKey == null || stagePipelineId != null, 'a routed stage names the pipeline it belongs to', @@ -77,6 +78,8 @@ class PipelineDetailPanel extends StatefulWidget { /// definition pane even though the pinned detail may be re-read in place. A /// later version switch from this screen is not a new route request. final int stageRequest; + final Future Function(BuildContext, PipelineDetail, PipelineRun?)? + onOpenInChat; @override State createState() => _PipelineDetailPanelState(); @@ -420,7 +423,18 @@ class _PipelineDetailPanelState extends State { onRunStarted: widget.onRunStarted, inBar: true, ), - pipelineActionsMenu(context, _controller, detail), + pipelineActionsMenu( + context, + _controller, + detail, + onOpenInChat: widget.onOpenInChat == null + ? null + : (context, detail, _) => widget.onOpenInChat!( + context, + detail, + _controller.latestRuns[detail.id], + ), + ), ]; Widget _source(BuildContext context, PipelineDetail detail) { diff --git a/app/lib/features/pipelines/widgets/pipeline_list_panel.dart b/app/lib/features/pipelines/widgets/pipeline_list_panel.dart index 20cb037d..95d0896a 100644 --- a/app/lib/features/pipelines/widgets/pipeline_list_panel.dart +++ b/app/lib/features/pipelines/widgets/pipeline_list_panel.dart @@ -14,6 +14,7 @@ import '../pipelines_controller.dart'; import 'pipeline_controls.dart'; import 'pipeline_filter_page.dart'; import 'pipeline_scope_control.dart'; +import '../../../ui/layout/app_overflow_menu.dart'; /// The list's horizontal rhythm, matching the web's toolbar and row inset /// (`var(--space-s)`: 12px). The detail pane keeps its own content padding. @@ -21,9 +22,15 @@ const double kPipelineListInset = 12; /// The left/top pane: filter and sort controls, then the truthful list states. class PipelineListPanel extends StatelessWidget { - const PipelineListPanel({super.key, required this.controller}); + const PipelineListPanel({ + super.key, + required this.controller, + this.onOpenInChat, + }); final PipelinesController controller; + final Future Function(BuildContext, PipelineSummary, PipelineRun?)? + onOpenInChat; @override Widget build(BuildContext context) { @@ -264,6 +271,22 @@ class PipelineListPanel extends StatelessWidget { : Text( ServerContext.metadata(context, runStateLabel(badge.state)), ), + menu: onOpenInChat == null + ? null + : AppOverflowMenu( + key: Key('pipeline-row-more-menu-${pipeline.id}'), + label: 'Pipeline actions', + sheetTitle: pipeline.displayName, + actions: const [ + AppMenuAction( + value: true, + label: 'Open in chat', + icon: Icons.chat_bubble_outline, + ), + ], + onSelected: (context, _) => + onOpenInChat!(context, pipeline, run), + ), ); }, ); diff --git a/app/lib/features/runs/screen.dart b/app/lib/features/runs/screen.dart index e3dbcde1..bd2f3229 100644 --- a/app/lib/features/runs/screen.dart +++ b/app/lib/features/runs/screen.dart @@ -53,6 +53,7 @@ class RunsScreen extends StatefulWidget { this.attention, this.sortStore = const SharedPreferencesRunsSortStore(), this.pendingRunStore = const SharedPreferencesPendingRunStore(''), + this.onOpenInChat, }); final ApiGateway gateway; @@ -103,6 +104,7 @@ class RunsScreen extends StatefulWidget { /// Where a New run's pending launch intent persists, under the same endpoint /// scope the Pipelines tab uses. Tests inject a memory store. final PendingRunStore pendingRunStore; + final Future Function(BuildContext, JsonMap)? onOpenInChat; @override State createState() => _RunsScreenState(); @@ -300,6 +302,7 @@ class _RunsScreenState extends State { onBack: onBack, onRunOpened: _select, onOpenPipeline: widget.onOpenPipeline, + onOpenInChat: widget.onOpenInChat, initialStageKey: widget.initialStageKey, initialVisit: widget.initialVisit, ); @@ -354,6 +357,7 @@ class _RunsScreenState extends State { attentionNow: widget.attentionNow, notifications: widget.notifications, attention: widget.attention, + onOpenInChat: widget.onOpenInChat, ), ), ); diff --git a/app/lib/features/runs/ui/run_detail_view.dart b/app/lib/features/runs/ui/run_detail_view.dart index 7bb0fa11..305e2ab8 100644 --- a/app/lib/features/runs/ui/run_detail_view.dart +++ b/app/lib/features/runs/ui/run_detail_view.dart @@ -24,6 +24,7 @@ class RunDetailView extends StatefulWidget { this.onOpenPipeline, this.initialStageKey, this.initialVisit, + this.onOpenInChat, }); final RunsController controller; @@ -44,6 +45,7 @@ class RunDetailView extends StatefulWidget { /// plain detail. final String? initialStageKey; final int? initialVisit; + final Future Function(BuildContext, JsonMap)? onOpenInChat; @override State createState() => _RunDetailViewState(); @@ -114,6 +116,7 @@ class _RunDetailViewState extends State { onRunChanged: widget.controller.acceptRunDetail, onRunOpened: widget.onRunOpened, onDeleted: widget.controller.applyDeletion, + onOpenInChat: widget.onOpenInChat, ); if (inShellBar) { return ShellBar( diff --git a/app/lib/features/runs/ui/run_list_row.dart b/app/lib/features/runs/ui/run_list_row.dart index a7f50114..1d23e96e 100644 --- a/app/lib/features/runs/ui/run_list_row.dart +++ b/app/lib/features/runs/ui/run_list_row.dart @@ -35,6 +35,7 @@ class RunListRow extends StatelessWidget { this.checked = false, this.onToggle, this.onLongPress, + this.onOpenInChat, }); final JsonMap run; @@ -56,6 +57,7 @@ class RunListRow extends StatelessWidget { /// Enters select mode from a touch long-press. final VoidCallback? onLongPress; + final Future Function(BuildContext, JsonMap)? onOpenInChat; @override Widget build(BuildContext context) { @@ -140,13 +142,18 @@ class RunListRow extends StatelessWidget { !selecting && gateway != null && onRunChanged != null && - showRunMoreMenu(run, deletable: onDeleted != null) + showRunMoreMenu( + run, + deletable: onDeleted != null, + canOpenInChat: onOpenInChat != null, + ) ? RunMoreMenu( run: run, gateway: gateway!, onRunChanged: onRunChanged!, onRunOpened: onRunOpened, onDeleted: onDeleted, + onOpenInChat: onOpenInChat, menuKey: ValueKey('run-list-more-menu-$id'), ) : null, diff --git a/app/lib/features/runs/ui/run_more_menu.dart b/app/lib/features/runs/ui/run_more_menu.dart index 7c7f9a1e..b312161b 100644 --- a/app/lib/features/runs/ui/run_more_menu.dart +++ b/app/lib/features/runs/ui/run_more_menu.dart @@ -16,14 +16,21 @@ import '../domain/run_models.dart' show runIdentity; const runMoreMenuKey = ValueKey('run-more-menu'); const deleteRunActionKey = ValueKey('run-delete-action'); const deleteRunActionLabel = 'Delete run'; +const openRunInChatActionKey = ValueKey('run-open-in-chat-action'); +const openRunInChatActionLabel = 'Open in chat'; /// Whether the run has anything for its more menu. [deletable] says the host /// can apply a deletion, so a finished run offers Delete run. -bool showRunMoreMenu(JsonMap run, {bool deletable = false}) => +bool showRunMoreMenu( + JsonMap run, { + bool deletable = false, + bool canOpenInChat = false, +}) => runTitleId(run) != null || canScheduleRun(run) || _canRetry(run) || - (deletable && runIsDeletable(run)); + (deletable && runIsDeletable(run)) || + canOpenInChat; /// The run's own name for its action sheet: its title or pipeline, else /// `Run `, as its list row shows it. @@ -34,7 +41,7 @@ String runMoreMenuTitle(JsonMap run) { bool _canRetry(JsonMap run) => retryRunId(run) != null && canRetryRun(run); -enum _RunMoreItem { retry, rename, schedule, delete } +enum _RunMoreItem { retry, rename, schedule, delete, openInChat } /// Each item keeps the key its standalone button had. Key _keyOf(_RunMoreItem item) => switch (item) { @@ -42,6 +49,7 @@ Key _keyOf(_RunMoreItem item) => switch (item) { _RunMoreItem.rename => runTitleActionKey, _RunMoreItem.schedule => scheduleRunActionKey, _RunMoreItem.delete => deleteRunActionKey, + _RunMoreItem.openInChat => openRunInChatActionKey, }; /// The run detail's more menu: Retry (failed runs only), Rename and Schedule @@ -56,6 +64,7 @@ class RunMoreMenu extends StatefulWidget { required this.onRunChanged, this.onRunOpened, this.onDeleted, + this.onOpenInChat, this.menuKey = runMoreMenuKey, }); @@ -68,6 +77,7 @@ class RunMoreMenu extends StatefulWidget { /// Applies an answered deletion; without it the menu offers no Delete run. final ValueChanged? onDeleted; + final Future Function(BuildContext, JsonMap)? onOpenInChat; /// Detail menus retain the shared key; list rows supply a per-run key. final Key menuKey; @@ -86,6 +96,8 @@ class _RunMoreMenuState extends State { if (canScheduleRun(run)) (_RunMoreItem.schedule, scheduleRunActionLabel), if (widget.onDeleted != null && runIsDeletable(run)) (_RunMoreItem.delete, deleteRunActionLabel), + if (widget.onOpenInChat != null) + (_RunMoreItem.openInChat, openRunInChatActionLabel), ]; void _pick(BuildContext context, _RunMoreItem item) { @@ -117,6 +129,8 @@ class _RunMoreMenuState extends State { gateway: widget.gateway, onDeleted: widget.onDeleted!, ); + case _RunMoreItem.openInChat: + widget.onOpenInChat!(context, run); } } @@ -131,6 +145,9 @@ class _RunMoreMenuState extends State { key: _keyOf(item), value: item, label: label, + icon: item == _RunMoreItem.openInChat + ? Icons.chat_bubble_outline + : null, destructive: item == _RunMoreItem.delete, ), ], diff --git a/app/lib/features/runs/ui/runs_list.dart b/app/lib/features/runs/ui/runs_list.dart index 00817b55..65223fab 100644 --- a/app/lib/features/runs/ui/runs_list.dart +++ b/app/lib/features/runs/ui/runs_list.dart @@ -32,10 +32,12 @@ class RunsList extends StatelessWidget { this.notifications, this.attention, this.active = true, + this.onOpenInChat, }); /// False while a run detail covers the list; the bar is then the run's. final bool active; + final Future Function(BuildContext, JsonMap)? onOpenInChat; final RunsController controller; final ValueChanged onSelected; @@ -166,7 +168,8 @@ class RunsList extends StatelessWidget { // A server with no runs at all is not a filter problem: say what the list // is for and where its first run comes from. A free-text query counts as // a filter too, so a search on an empty server reads as "nothing found". - final noRunsAtAll = controller.runs.isEmpty && + final noRunsAtAll = + controller.runs.isEmpty && controller.activeFilterCount == 0 && controller.query.trim().isEmpty; return BelowTopBar( @@ -340,6 +343,7 @@ class RunsList extends StatelessWidget { gateway: controller.repository.gateway, onRunChanged: controller.acceptRunDetail, onRunOpened: onSelected, + onOpenInChat: onOpenInChat, ); } } diff --git a/app/notes/open-in-chat.md b/app/notes/open-in-chat.md new file mode 100644 index 00000000..6b14e713 --- /dev/null +++ b/app/notes/open-in-chat.md @@ -0,0 +1,21 @@ +# Open in chat + +Runs and pipelines expose **Open in chat** in their overflow menus. The action +creates a chat using the New chat backend catalog rule (OpenCode when +available, otherwise the first advertised harness) in the run/latest-run +workspace, or the saved Settings workspace and finally `~`, then routes to the +Chat tab. The generated reference is seeded as an unsent composer draft and +requests composer focus. Settings and create failures show an error without +changing chat state. On narrow pipeline detail layouts, the segmented More +sheet includes both Archive/Unarchive and Open in chat. Settings fallback reads +the workspace for the active server identity rather than an unscoped preference. + +Focused regression coverage is in `test/application/open_in_chat_test.dart`: +run list desktop menu, run detail phone sheet, pipeline list row menu, and +pipeline detail phone overflow all assert selection reaches the callback with +the expected entity and latest run. The existing schedule/menu and pipeline +destination tests also pass. The full-app browser probe now supports stateful +`chat_create`, catalog, session, and transcript replies, so a rendered menu +selection can show the created chat and seeded composer rather than stopping at +an unsupported-request error. Browser and phone/desktop captures were not run +in this implementation stage. diff --git a/app/test/application/open_in_chat_test.dart b/app/test/application/open_in_chat_test.dart new file mode 100644 index 00000000..1b46a293 --- /dev/null +++ b/app/test/application/open_in_chat_test.dart @@ -0,0 +1,296 @@ +import 'package:flutter/material.dart'; +import 'package:flutter_test/flutter_test.dart'; + +import 'package:pipelines_app/core/api_gateway.dart'; +import 'package:pipelines_app/application/open_in_chat.dart'; +import 'package:pipelines_app/features/chat/chat_runtime.dart'; +import 'package:pipelines_app/features/chat/ui/sessions/chat_create_fields.dart'; +import 'package:pipelines_app/features/pipelines/pipeline_models.dart'; +import 'package:pipelines_app/features/pipelines/pipeline_repository.dart'; +import 'package:pipelines_app/features/pipelines/pipelines_controller.dart'; +import 'package:pipelines_app/features/pipelines/widgets/pipeline_archive_action.dart'; +import 'package:pipelines_app/features/pipelines/widgets/pipeline_list_panel.dart'; +import 'package:pipelines_app/features/runs/ui/run_list_row.dart'; +import 'package:pipelines_app/features/runs/ui/run_more_menu.dart'; + +import '../features/chat/ui/sessions/fake_chat_gateway.dart'; +import '../features/pipelines/fixtures.dart'; +import '../features/pipelines/test_helpers.dart'; + +void main() { + test('a run summary names its pipeline in name', () { + final draft = runChatReference({ + 'id': 7, + 'name': 'release', + 'title': 'Ship notes', + 'version': 3, + 'status': 'failed', + }); + expect( + draft, + 'About Pipelines run #7 "Ship notes" (pipeline "release" v3, ' + 'status failed). Inspect it with `pipelines inspect 7`.', + ); + final untitled = runChatReference({ + 'id': 8, + 'name': 'release', + 'version': 3, + 'status': 'succeeded', + }); + expect(untitled, contains('run #8 "Run 8" (pipeline "release" v3')); + }); + + test('run references contain the exact inspect command', () { + expect( + runChatReference({ + 'id': 42, + 'title': 'Nightly build', + 'pipeline_name': 'Deploy', + 'pipeline_version': 3, + 'status': 'failed', + }), + 'About Pipelines run #42 "Nightly build" (pipeline "Deploy" v3, ' + 'status failed). Inspect it with `pipelines inspect 42`.', + ); + }); + + test('pipeline references contain show and edit guidance', () { + expect( + pipelineChatReference(7, 'Deploy', 4), + 'About pipeline "Deploy" (id 7, version 4). Show it with ' + '`pipelines show "Deploy"`; to change it, draft with `pipelines edit` ' + 'and publish with `pipelines submit`.', + ); + }); + + test('open in chat keeps the more menu available', () { + expect(showRunMoreMenu({'id': 42}, canOpenInChat: true), isTrue); + }); + + test('pipeline latest run retains its workspace', () { + final run = PipelineRun.fromJson({ + 'id': 9, + 'pipeline_id': 7, + 'workspace': '/work/deploy', + }); + expect(run.workspace, '/work/deploy'); + }); + + testWidgets( + 'open in chat uses the catalog backend, draft, route, and focus', + (tester) async { + final gateway = FakeChatGateway() + ..backendsHandler = () async => const { + 'chat_backends': ['codex', 'claude'], + }; + final runtime = ChatRuntime(gateway: gateway); + String? selected; + + await tester.pumpWidget(const MaterialApp(home: Scaffold())); + await openReferenceInChat( + context: tester.element(find.byType(Scaffold)), + runtime: runtime, + selectChat: (id) => selected = id, + directory: '/work/run', + title: 'Run #42: Build', + draft: 'About Pipelines run #42.', + ); + + final create = gateway.lastFields('chat_create')!['chat_create'] as Map; + expect(create['backend'], 'codex'); + expect(create['directory'], '/work/run'); + expect(selected, 'created'); + expect(runtime.pendingDrafts['created'], 'About Pipelines run #42.'); + expect(runtime.composerFocus.take('created'), isTrue); + runtime.dispose(); + }, + ); + + testWidgets('open in chat falls back to the default folder', (tester) async { + final gateway = FakeChatGateway(); + final runtime = ChatRuntime(gateway: gateway); + + await tester.pumpWidget(const MaterialApp(home: Scaffold())); + await openReferenceInChat( + context: tester.element(find.byType(Scaffold)), + runtime: runtime, + selectChat: (_) {}, + directory: '', + title: 'Pipeline: Deploy', + draft: 'About pipeline "Deploy".', + ); + + final create = gateway.lastFields('chat_create')!['chat_create'] as Map; + expect(create['directory'], chatHomeDirectory); + runtime.dispose(); + }); + + testWidgets('create failure leaves navigation and chat state unchanged', ( + tester, + ) async { + final gateway = FakeChatGateway()..failures['chat_create'] = 'refused'; + final runtime = ChatRuntime(gateway: gateway); + String? selected; + + await tester.pumpWidget(const MaterialApp(home: Scaffold())); + await openReferenceInChat( + context: tester.element(find.byType(Scaffold)), + runtime: runtime, + selectChat: (id) => selected = id, + directory: '/work/run', + title: 'Run #42: Build', + draft: 'About Pipelines run #42.', + ); + await tester.pump(); + + expect(selected, isNull); + expect(runtime.opened, isEmpty); + expect(find.textContaining('Could not open in chat'), findsOneWidget); + runtime.dispose(); + }); + + testWidgets('run list More selects Open in chat on desktop', (tester) async { + final run = { + 'id': 42, + 'title': 'Build', + 'status': 'failed', + 'created_at': '2026-10-17T19:00:00', + }; + JsonMap? selected; + final gateway = FakeChatGateway(); + + tester.view.physicalSize = const Size(900, 700); + tester.view.devicePixelRatio = 1; + addTearDown(tester.view.resetPhysicalSize); + addTearDown(tester.view.resetDevicePixelRatio); + await tester.pumpWidget( + MaterialApp( + home: Scaffold( + body: RunListRow( + run: run, + now: DateTime(2026, 10, 18), + gateway: gateway, + onRunChanged: (_) {}, + onOpenInChat: (context, value) async => selected = value, + ), + ), + ), + ); + + await tester.tap(find.byKey(const Key('run-list-more-menu-42'))); + await tester.pumpAndSettle(); + expect(find.text('Open in chat'), findsOneWidget); + await tester.tap(find.text('Open in chat')); + expect(selected, same(run)); + }); + + testWidgets('run detail More selects Open in chat from the phone sheet', ( + tester, + ) async { + final run = {'id': 42, 'title': 'Build'}; + JsonMap? selected; + final gateway = FakeChatGateway(); + + tester.view.physicalSize = const Size(390, 844); + tester.view.devicePixelRatio = 1; + addTearDown(tester.view.resetPhysicalSize); + addTearDown(tester.view.resetDevicePixelRatio); + await tester.pumpWidget( + MaterialApp( + home: Scaffold( + appBar: AppBar( + actions: [ + RunMoreMenu( + run: run, + gateway: gateway, + onRunChanged: (_) {}, + onOpenInChat: (context, value) async => selected = value, + ), + ], + ), + ), + ), + ); + + await tester.tap(find.byTooltip('More actions')); + await tester.pumpAndSettle(); + expect(find.text('Open in chat'), findsOneWidget); + await tester.tap(find.text('Open in chat')); + expect(selected, same(run)); + }); + + testWidgets('pipeline list row More selects Open in chat with latest run', ( + tester, + ) async { + final fixture = PipelineFixture(); + final gateway = gatewayFor(fixture); + final controller = PipelinesController(PipelinesRepository(gateway)); + addTearDown(controller.dispose); + await controller.load(); + PipelineSummary? selected; + PipelineRun? selectedRun; + + tester.view.physicalSize = const Size(900, 700); + tester.view.devicePixelRatio = 1; + addTearDown(tester.view.resetPhysicalSize); + addTearDown(tester.view.resetDevicePixelRatio); + await tester.pumpWidget( + MaterialApp( + home: Scaffold( + body: PipelineListPanel( + controller: controller, + onOpenInChat: (context, pipeline, run) async { + selected = pipeline; + selectedRun = run; + }, + ), + ), + ), + ); + await tester.pumpAndSettle(); + + await tester.tap(find.byKey(const Key('pipeline-row-more-menu-1'))); + await tester.pumpAndSettle(); + expect(find.text('Open in chat'), findsOneWidget); + await tester.tap(find.text('Open in chat')); + expect(selected?.id, 1); + expect(selectedRun?.id, 42); + }); + + testWidgets( + 'pipeline detail actions select Open in chat from phone overflow', + (tester) async { + final fixture = PipelineFixture(); + final gateway = gatewayFor(fixture); + final controller = PipelinesController(PipelinesRepository(gateway)); + addTearDown(controller.dispose); + final detail = PipelineDetail.fromJson(fixture.details.first); + PipelineDetail? selected; + + tester.view.physicalSize = const Size(390, 844); + tester.view.devicePixelRatio = 1; + addTearDown(tester.view.resetPhysicalSize); + addTearDown(tester.view.resetDevicePixelRatio); + await tester.pumpWidget( + MaterialApp( + home: Scaffold( + body: Builder( + builder: (context) => pipelineActionsMenu( + context, + controller, + detail, + onOpenInChat: (context, value, run) async => selected = value, + ), + ), + ), + ), + ); + + await tester.tap(find.byTooltip('Pipeline actions')); + await tester.pumpAndSettle(); + expect(find.text('Open in chat'), findsOneWidget); + await tester.tap(find.text('Open in chat')); + expect(selected?.id, detail.id); + }, + ); +} diff --git a/app/tool/search_selection_probe_entry.dart b/app/tool/search_selection_probe_entry.dart index b25a7e7a..d08f7441 100644 --- a/app/tool/search_selection_probe_entry.dart +++ b/app/tool/search_selection_probe_entry.dart @@ -170,6 +170,12 @@ bool _warnings = false; /// visit (group `debug`) to run 7's build visit, so the Artifacts tab's hidden /// Debugging files group can be reviewed. bool _turnFiles = false; + +/// Chats created during a rendered probe. Keeping these in the fixture makes +/// the real Open in chat flow observable instead of turning the create request +/// into the same "unsupported request" error as an incomplete server. +final _probeChats = {}; +int _probeChatSequence = 0; const List _turnFileNames = [ 'input.md', 'memory.md', @@ -549,6 +555,78 @@ JsonMap? probeReply(JsonMap request) { 'type': 'pipeline', 'detail': probePipelineDetail(pipelineId, version is int ? version : 0), }; + case 'chat_backends': + return { + 'id': id, + 'type': 'chat_backends', + 'chat_backends': ['opencode'], + }; + case 'chat_directories': + return { + 'id': id, + 'type': 'chat_directories', + 'chat_directories': ['/Users/fixture/workspace'], + }; + case 'chat_sessions': + return { + 'id': id, + 'type': 'chat_sessions', + 'chat_sessions': _probeChats.values.toList(), + }; + case 'chat_create': + final body = request['chat_create']; + if (body is! Map) { + return error('Fixture refused a malformed chat create.'); + } + final chatId = 'probe-chat-${++_probeChatSequence}'; + final session = { + 'id': chatId, + 'title': '${body['title'] ?? ''}', + 'directory': '${body['directory'] ?? ''}', + 'backend': '${body['backend'] ?? 'opencode'}', + 'model': 'fixture-model', + 'created_at': '2026-10-20T09:00:00Z', + 'closed_at': null, + }; + _probeChats[chatId] = session; + return {'id': id, 'type': 'chat_created', 'chat_session': session}; + case 'chat_models': + return { + 'id': id, + 'type': 'chat_models', + 'chat_models': [ + {'provider': 'fixture', 'model': 'fixture-model'}, + ], + }; + case 'chat_modes': + return { + 'id': id, + 'type': 'chat_modes', + 'chat_modes': const [ + {'mode': 'default', 'name': 'Default'}, + ], + 'chat_mode': const {'mode': 'default'}, + }; + case 'chat_messages': + return { + 'id': id, + 'type': 'chat_messages', + 'chat_history': const { + 'messages': [], + 'next_cursor': '', + 'has_more': false, + }, + }; + case 'chat_subscribe': + return {'id': id, 'type': 'chat_subscribed'}; + case 'chat_shells': + return {'id': id, 'type': 'chat_shells', 'chat_shells': const []}; + case 'chat_automations': + return { + 'id': id, + 'type': 'chat_automations', + 'chat_automations': const [], + }; case 'archive_pipeline': case 'unarchive_pipeline': // Mirrors the server: an enabled schedule blocks archiving.