Merge commit '6569908f9139eef75c52e73db3402bebc2e2f5b6' into pipelines/run-20261112-1022-obvious-ways-to-start-a-run-f077

This commit is contained in:
2026-11-12 11:04:22 +00:00
31 changed files with 1396 additions and 276 deletions
+41
View File
@@ -0,0 +1,41 @@
# Background tasks ring (composer)
Replaces the rotating layers icon in the composer's background-tasks button.
## Behaviour
- `chat_task_spinner.dart`: `ChatTaskSpinner(running:)`, 16 px square in every state.
- `running > 0`: Material `CircularProgressIndicator` (indeterminate, stroke 2,
primary colour) with the running count centred inside (`FittedBox` scales
the digit down under large text scaling).
- reduced motion (`MediaQuery.disableAnimations`): the same ring holds one
static quarter segment (`value: 0.25`) instead of spinning.
- `running == 0`: static `Icons.layers_outlined`, no ring.
- `chat_background_tasks.dart`: automation-only state keeps its static schedule
icon. Tooltip with running tasks is `Background tasks (N running)`; without
running tasks it keeps the caption label (e.g. `1 automation`, `Tasks`).
Semantics label is unchanged.
- Button size, padding and caption are unchanged.
## Tests (memwatch, from app/)
| Run | Paths | Result |
|---|---|---|
| 1 | `chat_task_spinner_test`, `chat_background_tasks_test`, `chat_background_tasks_modal_test`, `chat_background_task_metadata_test`, `chat_background_tasks_gui_test`, `chat_background_tasks_controller_test`, `chat_automation_lifecycle_test` | FAIL 37/38 (`chat_background_tasks_test` "combined caption..." — my test's `find.descendant` on the count key; fixed) |
| 2 | same seven paths | PASS 38/38, exit 0 |
`tool/analyze.sh`: clean, exit 0.
Test expectation changes (all from the requested behaviour):
- `chat_task_spinner_test.dart` rewritten for the ring: indeterminate value,
stroke 2, primary colour (light and dark), count text, same 16 px size in
every state, reduced-motion static segment, tooltip on the composer button.
- `chat_background_tasks_test.dart`: tooltip `2 tasks, 12 automations` became
`Background tasks (2 running)`; the composer count now also appears inside the
ring, so the caption check expects two `2` texts and the ring's count is checked
by its key.
## Not verified here
- Light/dark captures and rendered checks were not done in this stage; ui-review owns them.
- No device or browser run.
+3 -3
View File
@@ -21,9 +21,9 @@
- **More menu Stop.** `chat_thread_view.dart` adds a `Stop` item to the header's
More menu while a turn runs (`key chat-thread-stop-menu`). It is shown on every
platform, so touch devices without a keyboard can stop.
- **Tasks spinner.** `chat_task_spinner.dart` turns the layers icon once per
2.5 s while at least one background task runs; static otherwise and under
reduced motion. Automation-only state keeps its static schedule icon.
- **Tasks spinner.** Superseded: `chat_task_spinner.dart` now draws a progress
ring with the running count instead of turning the layers icon. See
`notes/background-tasks-ring.md`.
## Focused tests (memwatch, from app/)
+40
View File
@@ -0,0 +1,40 @@
# Dim inactive chat panes
## Change
- `lib/features/chat/workspace/chat_pane_dim.dart` (new): `ChatPaneDim` lays an
`IgnorePointer` surface scrim over a pane's content. The scrim is the theme's
`colorScheme.surface` at `chatPaneDimOpacity` (0.35), so content reads at
about 65% emphasis in light and dark. Its colour fades over `Motion.standard`;
`Motion.of` returns zero under reduced motion, so the change is immediate.
- `lib/features/chat/workspace/chat_workspace.dart`: `_paneContent` wraps each
pane's built content in `ChatPaneDim(dimmed: paneCount > 1 && !active)`.
Pointer activation (the pane `Listener`), focus and the action bar's
existing tint (`ChatPaneActivity`) are unchanged. The scrim ignores pointers,
so a tap reaches the content beneath it and still activates the pane.
- The optional primary outline is not added. The active pane already has its
chat-coloured foreground border (`chat_screen_workspace.dart`).
## Tests
- `test/features/chat/workspace/chat_pane_dim_test.dart` (new, 7 tests):
two panes dim only the inactive one; three panes dim both inactive panes;
a single pane is never dimmed; a tap on an inactive input activates it and
focuses its editable text; a tap on bare space in an inactive pane activates
it; reduced motion gives a zero duration and an immediate switch; default
motion uses `Motion.standard`.
- Existing users of `ChatWorkspace` also run: `chat_workspace_test`,
`chat_pane_move_test`, `chat_center_stage_test`, `chat_switch_styles_test`,
`chat_mobile_panes_test`, `chat_peek_identity_test`, and
`test/features/settings/quick_switch_preview_test.dart`.
Command (from `app/`):
`tool/memwatch/full.sh 'test/features/chat/workspace/chat_pane_dim_test.dart test/features/chat/workspace/chat_workspace_test.dart test/features/chat/workspace/chat_pane_move_test.dart test/features/chat/workspace/chat_center_stage_test.dart test/features/chat/workspace/chat_switch_styles_test.dart test/features/chat/workspace/chat_mobile_panes_test.dart test/features/chat/workspace/chat_peek_identity_test.dart test/features/settings/quick_switch_preview_test.dart'`
Result: `PASS: 70 passed, 0 failed, 0 skipped; peak 1329 MB; 11s; exit 0`.
Analyzer (`tool/analyze.sh`): clean, exit 0.
## Not done here
- No captures. The 2- and 3-pane light and dark captures belong to ui-review
(`tool/capture/`), and no UI was built or run in this stage.
- No test or capture covers the chat screen's full path (`chat_screen_workspace.dart`).
The dim comes from `ChatWorkspace`, which that screen uses, so it applies there too.
@@ -0,0 +1,67 @@
# Phone chat list: terminal button over the Chats header
## Defect
At 430px the floating terminal shortcut (`TerminalShortcutBubble`, end 12,
top = safe top + 64) sat on the chat list's `Chats` section header at
[370,64,48,48]. It hid the header's count and collapse chevron and left a
stray glyph beside it. Evidence: `/tmp/ui-review/base-light-430x900/07-chat.png`,
`/tmp/ui-review/chatmenus-light-430x900/01-chatlist-more.png`.
Run 393 had removed a duplicate terminal icon from the narrow list bar, so the
list had only the floating bubble.
## Change
- `lib/features/chat/ui/sessions/chat_sessions_screen.dart`: `_actions(context)`
now appends `terminalChatBarAction(context)` after New chat and Refresh. It is
null on wide layouts (the shell bar keeps Terminal there) and with no
terminal surface, so it appears only on a narrow layout with a surface.
- `lib/application/pipelines_app.dart`: the floating bubble's `onChat` is now
`false` on every route. On a narrow layout every Chat-tab bar carries Terminal
itself (the list's top bar, and an open chat's bar via
`chat_thread_view.dart`'s `terminalChatBarAction`), so the bubble has no
remaining place. The earlier rule (`kind == chat && chatSessionId != null`)
still showed it on an open chat, duplicating that chat's Terminal entry.
- `lib/application/app_terminals.dart`: doc comment for `surround(onChat:)`
now says pages whose own bar carries Terminal pass false. No behaviour change.
Result on a phone: exactly one terminal entry on the chat list (top bar) and on
an open chat (its bar), and no floating control over any header.
## Focused tests (memwatch, from app/)
- `test/application/phone_chat_terminal_entries_test.dart`: new, 2 tests at
430x900 through the app shell. `/chat` and `/chat/abc123` each have no
`TerminalShortcutBubble` and exactly one Terminal `ChatBarAction`.
Against the previous `onChat` rule the open-chat test FAILS (the bubble is
shown), so it guards the reviewer's finding. Restored after that check.
- `test/features/chat/ui/sessions/chat_list_terminal_action_test.dart`: 4 tests.
Narrow top bar carries Terminal beside New chat and Refresh, and tapping it
toggles. The Chats heading sits below the bar. Wide has no list terminal.
No terminal surface has no list terminal.
- Users of the changed wiring, all in the same run:
- `test/application/pipelines_app_test.dart`
- `test/features/terminal/terminal_surface_test.dart`
- `test/features/chat/ui/sessions/chat_sessions_floating_bar_test.dart`
- `test/features/chat/ui/sessions/chat_sessions_screen_test.dart`
Combined run of these six plus the list test: PASS 28/28 (`memwatch: PASS`,
exit 0), run after the final edit.
- Not re-run in this pass: `test/features/chat/shell/chat_shell_terminal_test.dart`
and `chat_shell_terminal_session_test.dart` (listed as users in an earlier
pass). The `onChat` change does not touch the shell's wide path.
- `tool/analyze.sh`: clean (0 errors, 0 warnings, 0 infos) after the final edit.
## Not verified here
- No rendered capture. The before/after screenshots at 430x900 are for ui-review.
- The open-chat test checks the Terminal action by label, not by semantics
identifier. In the open chat's bar the identifier lookup found nothing even
though the action is present, so this is a limit of the probe, not evidence
of a missing entry. A capture is needed to confirm what is drawn.
## Open limitations
- `TerminalShortcutBubble` is now never shown by the app shell (`onChat` is
always false). It and `TerminalSurface`'s shortcut code remain, with their
own tests. Removing them is a follow-up if the owner agrees.
- A narrow Chat-tab route with no chat bar would now have no terminal entry at
all. None was found in the code, but this was not exhaustively checked.
- The bubble's old top edge on an open chat was not checked against that chat's
bar; with the bubble gone that check is moot.
+73
View File
@@ -0,0 +1,73 @@
# Rail top strip and empty top-right island
Two shell chrome defects on the wide layout (run 20261112-1022).
## Causes
- **White strip above the rail (96x8 at y=0).** On a wide window
`WindowMargins` adds `wideExtraTop` (16 - 8 = 8 px) to `MediaQuery` top
padding. `ShellNavigationRail` pads its rail by that top inset with a plain
`Padding`, so the 8 px above the rail's Material surface was never painted
and showed the canvas behind it (white in both themes).
- **Empty circular pill (top right of Search and Settings).**
`pipelines_app.dart` put `WindowsMenuButton` in `barActions` on every tab.
The button returns `SizedBox.shrink()` with no open window, but
`SegmentedBar` counted it as an action, so the trailing island was drawn
around nothing.
## Changes (app/)
- `lib/shell/navigation_rail.dart`: the rail is wrapped in a `ColoredBox`
(key `shell.navigation-rail.surface`) in the theme surface, and the
`NavigationRail` gets the same `backgroundColor`. The top inset still moves
the rail's content down; the inset itself is painted.
- `lib/shell/windows/windows_menu_button.dart`: new static
`WindowsMenuButton.hasWindows(manager)`, the single predicate for "a window
is listed".
- `lib/shell/adaptive_shell.dart`: new optional `windowManager` parameter.
The shell adds the Windows button to the bar's actions only when
`hasWindows` is true, and merges the manager into the top bar's listenable
so the island appears and disappears with windows.
- `lib/application/pipelines_app.dart`: the Windows button is no longer in
`barActions`; `windowManager: _windows` is passed to the shell instead.
## Tests (focused, run through tool/memwatch/full.sh)
Paths: `test/shell/navigation_rail_surface_test.dart`,
`test/shell/shell_bar_empty_actions_test.dart`,
`test/shell/navigation_rail_test.dart` (existing, affected by the rail
change), `test/shell/windows/window_conveniences_test.dart` (existing, uses
`WindowsMenuButton` directly).
- Result: `PASS: 28 passed, 0 failed, 0 skipped; peak 1128 MB; 4s; exit 0`.
- Rail surface, light and dark: the cover is at y=0, its colour equals the
theme surface, the rail's background equals it, the rail content starts at
the 8 px inset, and the strip above it is inside the cover.
- Action island: Search, Settings and Pipelines at 1000 px and 430 px draw no
`segmented.actions` island with no window; a shell with no window manager
draws none; the Windows button is the island only while a window is open
and goes away when it closes.
`tool/analyze.sh`: clean, exit 0.
Not run: the land gate and the full app suite (owned by the gate stage).
Pre-existing failures listed in the memory note were not checked here.
## Affected UI states (for ui-review to capture)
- Wide window (1600x1000), light and dark: rail top (should now be the
surface colour, not white), on every tab and on Settings.
- Wide and narrow (430x900), Search and Settings: no empty pill at top right.
- Wide window with one or more floating windows open: the Windows button is
shown in the top-right island.
Before-captures exist in `/tmp/ui-review/` (`base-dark-1600x1000/12-settings.png`,
`base-light-430x900/11-search.png`, and others). No after-captures were
taken in this stage, per the stage rules; ui-review owns capture.
## Limitations
- The "rail top colour equals rail surface" check is a widget-tree check
(colour and rect), not a pixel read from a rendered frame.
- `WindowMargins` (the source of the 8 px) is untouched; the fix is at the
rail, so the rail's content position is unchanged.
+72
View File
@@ -0,0 +1,72 @@
# Settings destination: Back only when pushed; one Settings entry per screen
Run 20261112-1022 (stage 01-implement). Not committed.
## Rule
- Settings opened from a shell control (rail item, phone bar item) is a
destination: no Back arrow. The Pipelines item leaves it for the Pipelines body.
- Settings opened any other way (a first load / deep link to `/settings`, a route
change that is not a shell control, the Pipelines gear) is a pushed page: Back
returns to Pipelines.
- The Pipelines bar's gear is kept only where the floating tab bar is the shell's
sole navigation (window width at least 600 and below the rail's 697; see
`showsFloatingTabBarOnly`). There the floating bar lists tabs only, so the gear
is the one Settings entry. The phone bar and the rail both offer Settings, so the
gear is gone there.
## Changed paths (app/)
- `lib/shell/adaptive_shell.dart`: `_navigatingTo` / `_settingsPushed`; `_noteShown`
is called on a shown-destination change; Back is built only when Settings is
pushed.
- `lib/shell/navigation_rail.dart`: `showsFloatingTabBarOnly(context)`.
- `lib/shell/destination.dart`: doc comment only.
- `lib/features/pipelines/screen.dart`: the bar's gear is shown only when
`showsFloatingTabBarOnly`; the rail check is gone. The non-shell paths keep the gear.
- `lib/application/pipelines_app.dart`: `_selectDestination` leaves Settings for the
Pipelines body (`_bodyRoutes`) instead of re-selecting the Settings route filed
under the Pipelines tab (the nav-only Settings has no Back, so without this the
Pipelines item would trap the user on Settings).
- Tests, new: `test/shell/settings_back_test.dart` (nav selection has no Back; route
push has Back and returns; first load has Back; nav after pushed clears Back);
`test/features/pipelines/pipelines_settings_gear_test.dart` (phone and rail: no
gear; floating band: gear present and its handler opens Settings).
- Tests, changed: `test/application/settings_page_test.dart`,
`test/application/tab_location_navigation_test.dart`,
`test/application/settings_registration_test.dart`,
`test/shell/navigation_rail_test.dart`. They now tap the nav item instead of the gear
and expect no Back on nav-opened Settings.
## Focused results (memwatch, from app/)
- New shell + gear tests and shell/rail/bar files: 54 passed, 0 failed.
(`settings_back_test`, `pipelines_settings_gear_test`, `navigation_rail_test`,
`shell_bar_test`, `tab_history_back_test`, `shell_navigation_bar_test`,
`split_destination_bar_test`, `pipelines_screen_filter_test`)
- Final run over all affected files (12 paths): 60 passed, 7 failed. The 7 are all
app-level tests that fail on HEAD for the same reason (see below). None is new.
- `settings_page_test`: "390 ... no gear ..." and "1200 ... rail ..."
- `tab_location_navigation_test`: "Settings is retained ...", "a delayed read ...",
"an explicit root URL ...", "Settings does not clear ..."
- `settings_registration_test`: "Settings shares socket and one native bar"
- Baseline check: a copy of app/ with HEAD's versions of the edited files fails the
same tests in the same way (`Expected: '/settings' Actual: '/pipelines'` after a
nav tap, and `Found 0 widgets with key 'segmented.more'` for the gear at 390).
`templates_wiring_test` passes on both.
- `tool/analyze.sh`: clean (0 errors, 0 warnings, 0 infos).
## Limitations
- App-level Settings navigation is not verified by these tests: a tap on the Settings
nav item does not change the route in this harness, on HEAD or on this change. The
behaviour is covered at shell level (`settings_back_test`) and by the gear test.
- System Back on a nav-opened Settings still closes to Pipelines (the shell's
PopScope is unchanged).
- The mid-width band keeps the gear by design (the floating bar has no Settings
entry). Adding Settings to the floating bar would remove it; not done here.
- Not built or captured here (ui-review owns that). States to re-capture:
- `base-light-430x900/12-settings.png` and `circle/01-hover.png`: Settings from the
nav has no Back arrow.
- `base-light-430x900/01-pipelines.png`: no Settings gear in the Pipelines header.
- A width between 600 and 696: the gear stays, and it opens Settings with Back.