From e0e8ca68f385de94405a0e279a1cd09efeefff1c Mon Sep 17 00:00:00 2001 From: Alan Silva Date: Tue, 10 Nov 2026 20:10:02 +0000 Subject: [PATCH] Make the app Material-only in the rules The app builds one Material UI for every platform. Cupertino code, tests and captures are being removed, so the agreement, the capture recipe and the floating-windows plan no longer ask for them. --- app/AGENTS.md | 2 +- app/tool/capture/README.md | 14 ++++++-------- docs/plans/floating-windows.md | 7 +++---- 3 files changed, 10 insertions(+), 13 deletions(-) diff --git a/app/AGENTS.md b/app/AGENTS.md index bb3360c6..89b8d622 100644 --- a/app/AGENTS.md +++ b/app/AGENTS.md @@ -4,7 +4,7 @@ - Only change source files under `app/`. The Go server, web proxy (`web/`) and installation scripts are read-only. User-requested web/server deployment and APK publication are allowed through the installer after checking quiescence and preserving a rollback. Never restart shared services merely for client tests or manipulate real operator chats/runs for testing. - This Flutter app is the only client: it replaced the former JavaScript web client and the Kotlin Android app. - No backend changes; report missing capabilities. -- Standard Material and Cupertino controls, including buttons/menus in custom graphs/diffs/chat. System typography, theme colors, light/dark, content-driven layout and text scaling. No fixed row/bubble/button dimensions, bespoke palette or CSS token port. Platform differences are intentional. Centralize necessary layout constraints; do not ban legitimate native default spacing or graph coordinates. +- One Material UI on every platform: standard Material controls, including buttons/menus in custom graphs/diffs/chat. No Cupertino widgets, `cupertino` flags, Cupertino tests or Cupertino captures; remove Cupertino branches you touch rather than extend them. System typography, theme colors, light/dark, content-driven layout and text scaling. No fixed row/bubble/button dimensions, bespoke palette or CSS token port. Centralize necessary layout constraints; do not ban legitimate native default spacing or graph coordinates. - Develop and test on web by default; user-requested Android release APK builds and publication are allowed. When the user authorizes device installation or testing, perform it directly on the named device; no pipeline stage or resource lease is required. Keep source portable to all three targets. Distinguish APK build/publication from on-device verification; report mobile behavior as unverified when no device test ran. - Small cohesive files (aim below 250 lines; split by responsibility, not arbitrary fragments). Each task owns a directory and its tests. Do not edit another lane or root pubspec/main unless assigned. - Code quality is a delivery requirement. No minified implementations, silent capability fallbacks, fake data masking missing features, or workarounds that bypass the real defect. A pipeline success does not waive missing behavior, native controls, regression coverage or rendered evidence. Label incomplete work honestly and complete it before claiming parity. diff --git a/app/tool/capture/README.md b/app/tool/capture/README.md index fba6e78d..8d1fe49e 100644 --- a/app/tool/capture/README.md +++ b/app/tool/capture/README.md @@ -83,16 +83,14 @@ Its bytes are served from the build, so copy the fixture in after building: ## Recipes (run from `app/` after building `build/probe-app`) -Capture a page at phone and fold widths, in Material and in Cupertino. Use 560 -for phone: headless Chrome misrenders Flutter below about 500 px. +Capture a page at phone and fold widths. Use 560 for phone: headless Chrome +misrenders Flutter below about 500 px. The app has one Material UI; do not +capture `platform=cupertino`. ```sh -for platform in material cupertino; do - for size in 560x1000 880x1000; do - node tool/capture/capture.mjs --build build/probe-app \ - --out /tmp/review/runs-$platform-$size --platform $platform --size $size \ - open=/runs/7 shot=run7 - done +for size in 560x1000 880x1000; do + node tool/capture/capture.mjs --build build/probe-app \ + --out /tmp/review/runs-$size --size $size open=/runs/7 shot=run7 done ``` diff --git a/docs/plans/floating-windows.md b/docs/plans/floating-windows.md index 469a24e9..051081e3 100644 --- a/docs/plans/floating-windows.md +++ b/docs/plans/floating-windows.md @@ -145,7 +145,7 @@ new kind. - **Chrome:** one `WindowFrame` widget, generalized from `ChatFloatWindow` + `terminalFloatChrome`. Title-bar drag, corner resize, double-click maximize, - min/max/close, reveal motion via `Motion.of`, Material/Cupertino variants, + min/max/close, reveal motion via `Motion.of`, Material only (no Cupertino variant), hover cursors and tooltips. - **Focus:** each window has a `FocusScope` under the host. One `WindowFocus` replaces `TerminalFocus` and the chat float's copy: remember on show, restore @@ -265,8 +265,7 @@ neighbours. 4. **Remove** `ChatFloatHost`, `ChatWorkspaceFloat`'s float list, `FloatingFocusRoot` and the chat use of `FloatingLayer`. - The workspace keeps only "this pane is out in a window". -5. **Real-browser acceptance** at 1280x800 and 1920x1080, light/dark, - Material/Cupertino: +5. **Real-browser acceptance** at 1280x800 and 1920x1080, light/dark: - Every popup in 1.1 from a floating chat, over Chat and over Runs. - Typing, paste (text and image), streaming spinner and elapsed time over Runs. @@ -372,7 +371,7 @@ and in a window: - inconsistent hover, tooltips and cursors - no shortcut overlay - The report was thin (4 Material captures); redo it with Cupertino and + The report was thin (4 Material captures); redo it with measurements before acting. - **Known failures excluded from the delivery gate:** 44 in `app/test/application`, and Go `internal/claude` and `internal/opencode`.