Float detail tabs at the bottom of the split detail pane and keep its bars below the status bar
This commit is contained in:
@@ -31,6 +31,46 @@ run and pipeline detail content.
|
||||
no split (Settings, Search, Schedules, Templates) it is compact and
|
||||
right-aligned. `floating_destination_bar.dart` needed no change.
|
||||
|
||||
## Detail tabs at the bottom (operator request)
|
||||
|
||||
Beside a list, run and pipeline detail used to float their tabs at the top
|
||||
of the pane, under its bar (`PageTabsEdge(top)` from
|
||||
`notes/app-chrome-fixes.md`). The shell's tab bar now stays over the list
|
||||
pane, which leaves the detail pane's bottom free. So `ListDetailPanes` now
|
||||
says `PageTabsEdge(edge: FloatingBarEdge.bottom)`, and the item's tabs float
|
||||
at the bottom of the detail pane, the same as on a phone page:
|
||||
|
||||
- At 1200 and 1600 they are sized to their tabs and sit at the pane's
|
||||
trailing edge.
|
||||
- They sit 16 above the system inset.
|
||||
- The content pads its last item clear of them.
|
||||
|
||||
The chat composer owns the chat pane's bottom in the same way. No pill sits
|
||||
on top of another pill. The stage page is always a pushed page, so its tabs
|
||||
were already at the bottom. `FloatingBarEdge.top` remains in the layout
|
||||
primitives, but nothing in the app uses it now.
|
||||
|
||||
## Status-bar inset in the detail pane (unfolded foldable)
|
||||
|
||||
On the Pixel Fold, the right pane drew its bar (chat header, run detail bar)
|
||||
under the status bar. The cause is that a Material `Scaffold` with an
|
||||
`appBar` and a `bottomNavigationBar` removes the top and bottom padding
|
||||
*and view padding* from its body. `ListDetailPanes` rebuilt the detail's
|
||||
insets from `viewPadding`, and inside the Material shell that is zero.
|
||||
Cupertino was unaffected.
|
||||
|
||||
The fix is in two places:
|
||||
|
||||
- The shell publishes the system insets it saw before its scaffold:
|
||||
`ShellSystemInsets` in `list_detail.dart`, set in `adaptive_shell.dart`
|
||||
from `MediaQuery.paddingOf`.
|
||||
- `ListDetailPanes` gives the detail exactly those insets at the top and
|
||||
bottom. Outside a shell, `viewPadding` stands in.
|
||||
|
||||
The list side keeps the shell bar's height, so it was already correct.
|
||||
Headless Chrome has no status bar, so this is covered by widget tests only.
|
||||
It has not been verified on a device.
|
||||
|
||||
## P2-9: Schedules on a wide window
|
||||
|
||||
- The strip (`schedule_list_toolbar.dart`) now holds the field and the filter,
|
||||
@@ -88,6 +128,14 @@ New:
|
||||
- At 1200 unsplit, the pill is compact at the right edge.
|
||||
- At 390, the pill spans the phone.
|
||||
- At 600 and 840 split with 2x text, there is no overflow.
|
||||
- `test/shell/split_status_bar_test.dart` covers both hosts at 1200 with a
|
||||
40px status bar (`tester.view.padding` and `viewPadding`):
|
||||
- The list bar, the detail pane bar and a self-drawn header (like the
|
||||
chat thread's `SegmentedBarOverlay`) all start at y ≥ 40.
|
||||
- The list and the item content still start at y=0.
|
||||
- The item tabs float at the pane's bottom, inside the detail pane, and do
|
||||
not overlap the shell tabs; the list clears them.
|
||||
- Before the fix, Material failed with the bar at y=8.
|
||||
- `test/ui/layout/reading_width_test.dart`:
|
||||
- The cap applies from the leading edge, and the body is not remounted
|
||||
across the cap.
|
||||
@@ -107,6 +155,8 @@ Updated:
|
||||
- The pipelines tests (placeholder wording).
|
||||
- `chat_list_detail_test.dart`, `pipelines_screen_test.dart` and
|
||||
`runs_screen_test.dart` now assert `EmptyDetailPane`.
|
||||
- `pane_bar_row_test.dart`: the item tabs are now at the bottom of the pane
|
||||
(they were under the pane bar).
|
||||
- `run_detail_tabs_test.dart`: at 1000 the Summary body is now
|
||||
`kReadingMaxWidth` wide from x=0 instead of spanning the window.
|
||||
|
||||
|
||||
Reference in New Issue
Block a user