android: show the run title whole in the run view, two lines in the list
A run's title is derived from its prompt, so it is often long. Give it the room it needs where the operator reads the run, and a deliberate clamp where it is one of many. Android only; no new dependency (the declared material-icons-extended only), no Pipelines server/Go/installer/Docker file touched, and no run started from the app. - Run view shows the whole title. The run-summary title line states its intent with RUN_VIEW_TITLE_LINES (Int.MAX_VALUE) and TextOverflow.Clip, so it wraps over as many lines as it needs and is never ellipsised; the fixed-height M3 app-bar copy stays a compact one-line label. - Runs-list rows grow, then clamp. RunRow's title went from maxLines = 1 to RUN_ROW_TITLE_LINES (2): a longer title takes a second line before it ellipsises, with the glyph, status chip and meta line still aligned and the selection highlight and tap target unchanged. - Stage-pane context line. StageDetailPane's run-label line went from maxLines = 1 to STAGE_RUN_LABEL_LINES (2); the pane is compact context, not where the whole title lives. - Named budgets. ui/RunIdentity.kt holds the three budgets so the choice is deliberate at each call site. RunTitlesTest (4 cases) pins them and asserts a clamping place is never more generous than the run view; RunIdentityTest gained a case that runLabel/runIdentity never shorten a long title. Checked for stale copies: android/README.md gained a dated section for this change (its existing "Run title beside the pipeline name" section still holds, it just did not describe line budgets). The top-level README and docs/ do not document the app's run-title rendering, and the packaged templates and internal/author/skill/references/ packaged skill describe Pipelines authoring and Android APK delivery, not this UI, so none of them needed updating. Evidence (JDK 17, Gradle 9.7.1 --offline --no-daemon): :app:testDebugUnitTest BUILD SUCCESSFUL, 57 classes / 513 tests / 0 failures / 0 errors / 0 skipped (RunTitlesTest 4/0, RunIdentityTest 6/0); :app:assembleDebug BUILD SUCCESSFUL, app-debug.apk 18,486,624 bytes sha256 2b23762b54f0..., published as this run's pipelines-debug-wip-2bc00a2.apk and served at http://10.0.0.75:8080/artifacts/278/4/pipelines-debug-wip-2bc00a2.apk.
This commit is contained in:
@@ -5848,3 +5848,53 @@ and the header on a device — the brief keeps implementation verification to th
|
||||
build and the unit tests, and visual review owns the operator's Pixel 9 Pro XL
|
||||
(captures: headings/list/fenced code/table, reasoning collapsed then expanded,
|
||||
and the header).
|
||||
|
||||
## Run title readability: whole in the run view, two lines in the list (17 Oct 2026)
|
||||
|
||||
A run's title is derived from its prompt, so it is often long. The run view now
|
||||
guarantees the operator can read it whole, while the places that are one of many
|
||||
clamp deliberately. `android/` only; no new dependency, no Pipelines
|
||||
server/Go/installer/Docker file touched and no run started from the app; the build
|
||||
and unit tests only, no device command run.
|
||||
|
||||
- **Run view shows the whole title.** The run-summary title line rendered
|
||||
`runLabel(run.title, run.name)` with the Compose default; it now states the
|
||||
intent with `RUN_VIEW_TITLE_LINES` (`Int.MAX_VALUE`) and `TextOverflow.Clip`, so
|
||||
it wraps over as many lines as it needs and is never ellipsised. The fixed-height
|
||||
M3 app-bar copy stays a compact one-line label; the summary's scrollable title is
|
||||
the complete one.
|
||||
- **Runs-list rows grow, then clamp.** `RunHistoryScreen.RunRow`'s title went from
|
||||
`maxLines = 1` to `RUN_ROW_TITLE_LINES` (2), so a longer title takes a second
|
||||
line before it ellipsises; the row's glyph, status chip and meta line keep their
|
||||
alignment and the selection highlight and tap target are unchanged.
|
||||
- **Stage-pane context line.** `StageDetailPane`'s run-label line went from
|
||||
`maxLines = 1` to `STAGE_RUN_LABEL_LINES` (2) — the pane is compact context, not
|
||||
the place the whole title lives.
|
||||
- **One named budget.** `ui/RunIdentity.kt` holds the three named line budgets so
|
||||
the choice is deliberate at each call site. `RunTitlesTest` (4 cases) pins them
|
||||
and asserts a clamping place is never more generous than the run view;
|
||||
`RunIdentityTest` gained a case that `runLabel`/`runIdentity` never shorten a
|
||||
long title, so re-introducing a truncating helper here fails.
|
||||
|
||||
Tests: the 57 result XMLs aggregate to **513 tests, 0 failures, 0 errors, 0
|
||||
skipped** (`RunTitlesTest` 4/0, `RunIdentityTest` 6/0).
|
||||
|
||||
Evidence (macOS, JDK 17 from Homebrew `openjdk@17`, Gradle 9.7.1 `--offline`,
|
||||
`--no-daemon`, `ANDROID_HOME=/Users/alan/Library/Android/sdk`):
|
||||
|
||||
- `gradle :app:testDebugUnitTest --no-daemon --offline --rerun` → `BUILD
|
||||
SUCCESSFUL`.
|
||||
- `gradle :app:assembleDebug --no-daemon --offline` → `BUILD SUCCESSFUL`;
|
||||
`app-debug.apk` 18,486,624 bytes, sha256
|
||||
`2b23762b54f011bbec680804a232f32bd43c244fb52c465a0f4b2c2c9a0148cb`.
|
||||
- **APK publish.** Copied to this run's artifacts directory as
|
||||
`pipelines-debug-wip-2bc00a2.apk` (`2bc00a2` = `git rev-parse --short HEAD`, the
|
||||
tree being uncommitted WIP on top of it), served at
|
||||
`http://10.0.0.75:8080/artifacts/278/4/pipelines-debug-wip-2bc00a2.apk`
|
||||
(`HTTP/1.1 200 OK`, `Content-Type: application/vnd.android.package-archive`; the
|
||||
downloaded bytes hash to the same sha256).
|
||||
|
||||
Not verified in this pass: how the wrapping summary title, the two-line list row
|
||||
and the two-line stage header actually render — that needs the device, which this
|
||||
build-and-unit-test pass did not use; visual review owns the operator's Pixel 9
|
||||
Pro XL.
|
||||
|
||||
Reference in New Issue
Block a user