merge(app): land changes-paging

This commit is contained in:
2026-10-22 16:15:50 +01:00
8 changed files with 637 additions and 65 deletions
@@ -3,6 +3,7 @@ import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:pipelines_app/features/changes/changes.dart';
import 'package:pipelines_app/features/changes/widgets/visit_pager.dart';
import 'fixtures.dart';
import 'widget_hosts.dart';
@@ -91,7 +92,7 @@ void main() {
expect(find.text(emptyCaptureDetail), findsNothing);
});
testWidgets('stage/visit sections keep partial status, counters and scope', (
testWidgets('stage/visit pages keep partial status, counters and scope', (
tester,
) async {
final diagnostic = 'Excluded protected files.';
@@ -121,11 +122,10 @@ void main() {
),
),
);
// The run-wide aggregate still counts the file this visit recorded.
expect(find.textContaining('1 file changed'), findsOneWidget);
expect(find.text('implementer'), findsOneWidget);
expect(find.text('Visit 1 · completed'), findsOneWidget);
// The reviewer's first visit is Visit 1, not the run-wide step ordinal 2.
expect(find.text('Visit 1 · failed'), findsOneWidget);
expect(find.text('Visit 2 · failed'), findsNothing);
expect(
find.text(
'partial (1 files), 1 skipped, 2 omitted · Excluded protected files.',
@@ -136,18 +136,24 @@ void main() {
find.text('Scope: Git tracked and nonignored files in the run directory'),
findsOneWidget,
);
// The second visit is its own page, not a second section.
expect(find.text('reviewer'), findsNothing);
expect(find.text(missingCaptureDetail), findsNothing);
await tester.tap(find.byKey(ChangesVisitPager.nextKey));
await tester.pump();
expect(find.text('implementer'), findsNothing);
expect(find.text('reviewer'), findsOneWidget);
// The reviewer's first visit is Visit 1, not the run-wide step ordinal 2.
expect(find.text('Visit 1 · failed'), findsOneWidget);
expect(find.text('Visit 2 · failed'), findsNothing);
expect(find.text(missingCaptureDetail), findsOneWidget);
expect(find.textContaining('partial capture'), findsWidgets);
});
testWidgets(
'repeated stages number their own visits and honour control.visit',
(tester) async {
// Tall enough that the lazy list builds every section.
tester.view.physicalSize = const Size(800, 1400);
tester.view.devicePixelRatio = 1;
addTearDown(tester.view.reset);
await tester.pumpWidget(
materialHost(
ChangesViewer(
@@ -177,11 +183,27 @@ void main() {
),
),
);
// Both stages' first recorded visits are Visit 1; the run-wide step
// ordinals (1-4) must not leak into the label.
expect(find.text('Visit 1 · completed'), findsNWidgets(2));
// Pages are in run order; each stage numbers its own visits, so the
// run-wide step ordinals (1-4) must not leak into the label.
expect(find.text('Visit 1 · completed'), findsOneWidget);
expect(find.text('Visit 2 · completed'), findsNothing);
expect(find.text('Visit 6 · completed'), findsNothing);
await tester.tap(find.byKey(ChangesVisitPager.nextKey));
await tester.pump();
// The reviewer's first recorded visit is Visit 1 too.
expect(find.text('reviewer'), findsOneWidget);
expect(find.text('Visit 1 · completed'), findsOneWidget);
await tester.tap(find.byKey(ChangesVisitPager.nextKey));
await tester.pump();
expect(find.text('implementer'), findsOneWidget);
expect(find.text('Visit 2 · completed'), findsOneWidget);
await tester.tap(find.byKey(ChangesVisitPager.nextKey));
await tester.pump();
// The resumed reviewer visit records control.visit 6.
expect(find.text('reviewer'), findsOneWidget);
expect(find.text('Visit 6 · completed'), findsOneWidget);
expect(find.text('Visit 3 · completed'), findsNothing);
expect(find.text('Visit 4 · completed'), findsNothing);
@@ -0,0 +1,222 @@
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:pipelines_app/core/api_gateway.dart';
import 'package:pipelines_app/features/changes/changes.dart';
import 'package:pipelines_app/features/changes/widgets/visit_pager.dart';
import 'fixtures.dart';
import 'widget_hosts.dart';
List<JsonMap> twoVisitRun() => [
stepFixture(
stage: 'implementer',
sequence: 1,
fileChanges: captureFixture(
files: [
fileChangeFixture(path: 'lib/a.dart'),
fileChangeFixture(path: 'lib/b.dart'),
],
),
),
stepFixture(
stage: 'reviewer',
sequence: 2,
fileChanges: captureFixture(
files: [
fileChangeFixture(path: 'lib/b.dart'),
fileChangeFixture(path: 'lib/c.dart'),
],
),
),
];
void main() {
testWidgets(
'Previous/Next page recorded visits while the aggregate stays run-wide',
(tester) async {
await tester.pumpWidget(
materialHost(ChangesViewer(steps: twoVisitRun())),
);
// The aggregate counts each path once across both visits, and does not
// change as the operator pages.
expect(find.text('3 files changed'), findsOneWidget);
expect(find.text('1 of 2 recorded visits'), findsOneWidget);
expect(find.text('implementer'), findsOneWidget);
expect(find.text('Visit 1 · completed'), findsOneWidget);
expect(find.text('lib/a.dart'), findsOneWidget);
expect(find.text('lib/c.dart'), findsNothing);
await tester.tap(find.byKey(ChangesVisitPager.nextKey));
await tester.pump();
// The shown page keeps its own visit identity in the heading.
expect(find.text('reviewer'), findsOneWidget);
expect(find.text('Visit 1 · completed'), findsOneWidget);
expect(find.text('lib/c.dart'), findsOneWidget);
expect(find.text('lib/a.dart'), findsNothing);
expect(find.text('3 files changed'), findsOneWidget);
expect(find.text('2 of 2 recorded visits'), findsOneWidget);
await tester.tap(find.byKey(ChangesVisitPager.previousKey));
await tester.pump();
expect(find.text('implementer'), findsOneWidget);
expect(find.text('lib/a.dart'), findsOneWidget);
expect(find.text('lib/c.dart'), findsNothing);
expect(find.text('1 of 2 recorded visits'), findsOneWidget);
},
);
testWidgets('paging stops at both ends instead of wrapping', (tester) async {
await tester.pumpWidget(materialHost(ChangesViewer(steps: twoVisitRun())));
TextButton previous() =>
tester.widget<TextButton>(find.byKey(ChangesVisitPager.previousKey));
TextButton next() =>
tester.widget<TextButton>(find.byKey(ChangesVisitPager.nextKey));
expect(previous().onPressed, isNull);
expect(next().onPressed, isNotNull);
await tester.tap(find.byKey(ChangesVisitPager.nextKey));
await tester.pump();
expect(previous().onPressed, isNotNull);
expect(next().onPressed, isNull);
// The disabled Next is inert; the page stays on the last visit.
await tester.tap(find.byKey(ChangesVisitPager.nextKey));
await tester.pump();
expect(find.text('reviewer'), findsOneWidget);
await tester.tap(find.byKey(ChangesVisitPager.previousKey));
await tester.pump();
expect(find.text('implementer'), findsOneWidget);
expect(previous().onPressed, isNull);
});
testWidgets('a run with one recorded visit offers no pager', (tester) async {
await tester.pumpWidget(
materialHost(
ChangesViewer(
steps: [
stepFixture(
fileChanges: captureFixture(
files: [fileChangeFixture(path: 'lib/only.dart')],
),
),
],
),
),
);
expect(find.text('Previous visit'), findsNothing);
expect(find.text('Next visit'), findsNothing);
expect(find.textContaining('recorded visits'), findsNothing);
// The single visit still keeps its identity heading.
expect(find.text('implementer'), findsOneWidget);
expect(find.text('Visit 1 · completed'), findsOneWidget);
expect(find.text('lib/only.dart'), findsOneWidget);
});
testWidgets('the filter and its aggregate counter survive paging', (
tester,
) async {
await tester.pumpWidget(materialHost(ChangesViewer(steps: twoVisitRun())));
await tester.enterText(find.byType(TextField), 'a.dart');
await tester.pump();
expect(find.text('1 of 3 changed paths match'), findsOneWidget);
expect(find.text('lib/a.dart'), findsOneWidget);
await tester.tap(find.byKey(ChangesVisitPager.nextKey));
await tester.pump();
// The filter still applies to the shown visit, and the counter still
// describes the whole run's changed paths.
expect(find.text('1 of 3 changed paths match'), findsOneWidget);
expect(find.text('No changed filenames match "a.dart".'), findsOneWidget);
expect(find.text('lib/c.dart'), findsNothing);
expect(find.text('reviewer'), findsOneWidget);
});
testWidgets('a shorter reply clamps the shown visit instead of overflowing', (
tester,
) async {
final first = twoVisitRun();
final second = [
stepFixture(
stage: 'implementer',
sequence: 1,
fileChanges: captureFixture(
files: [fileChangeFixture(path: 'lib/a.dart')],
),
),
];
await tester.pumpWidget(materialHost(ChangesViewer(steps: first)));
await tester.tap(find.byKey(ChangesVisitPager.nextKey));
await tester.pump();
expect(find.text('reviewer'), findsOneWidget);
await tester.pumpWidget(materialHost(ChangesViewer(steps: second)));
await tester.pump();
expect(tester.takeException(), isNull);
expect(find.text('implementer'), findsOneWidget);
expect(find.text('Visit 1 · completed'), findsOneWidget);
expect(find.text('Previous visit'), findsNothing);
});
testWidgets('the pager stays reachable at 320x720 with 2x text', (
tester,
) async {
tester.view.physicalSize = const Size(320, 720);
tester.view.devicePixelRatio = 1;
addTearDown(tester.view.reset);
await tester.pumpWidget(
materialHost(
ChangesViewer(steps: twoVisitRun()),
scaler: const TextScaler.linear(2),
),
);
expect(tester.takeException(), isNull);
expect(find.text('Previous visit'), findsOneWidget);
expect(find.text('Next visit'), findsOneWidget);
// At 2x text the fixed summary and filter leave a short scroll viewport;
// the pager is still reachable by scrolling the visit body.
await tester.ensureVisible(find.text('Next visit'));
await tester.pump();
await tester.tap(find.text('Next visit'));
await tester.pump();
expect(tester.takeException(), isNull);
expect(find.text('reviewer'), findsOneWidget);
expect(find.text('Visit 1 · completed'), findsOneWidget);
expect(find.text('lib/c.dart'), findsOneWidget);
});
testWidgets('Cupertino pages with native buttons at both ends', (
tester,
) async {
await tester.pumpWidget(cupertinoHost(ChangesViewer(steps: twoVisitRun())));
final previous = tester.widget<CupertinoButton>(
find.byKey(ChangesVisitPager.previousKey),
);
final next = tester.widget<CupertinoButton>(
find.byKey(ChangesVisitPager.nextKey),
);
expect(previous.onPressed, isNull);
expect(next.onPressed, isNotNull);
expect(find.text('Previous visit'), findsOneWidget);
expect(find.text('Next visit'), findsOneWidget);
await tester.tap(find.byKey(ChangesVisitPager.nextKey));
await tester.pump();
expect(find.text('reviewer'), findsOneWidget);
expect(
tester
.widget<CupertinoButton>(find.byKey(ChangesVisitPager.nextKey))
.onPressed,
isNull,
);
});
}
@@ -112,8 +112,19 @@ void main() {
find.text('1 file changed · +2 -2 · capture incomplete'),
findsOneWidget,
);
// Visit numbers are per stage, so both stages' first visits say Visit 1.
expect(find.text('Visit 1 · completed'), findsNWidgets(2));
// The page opens on the run's first recorded visit; its stage/visit
// heading identifies the evidence, and Next reaches the second visit.
expect(find.text('Visit 1 · completed'), findsOneWidget);
expect(find.text('implementer'), findsOneWidget);
expect(find.text('Next visit'), findsOneWidget);
await tester.tap(find.text('Next visit'));
await tester.pump();
expect(find.text('reviewer'), findsOneWidget);
expect(find.text('Visit 1 · completed'), findsOneWidget);
expect(find.text('lib/feature.dart'), findsNothing);
await tester.tap(find.text('Previous visit'));
await tester.pump();
expect(find.text('lib/feature.dart'), findsOneWidget);
await tester.tap(
find.byKey(const ValueKey('change-1-lib/feature.dart')),
@@ -2,6 +2,7 @@ import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:pipelines_app/core/api_gateway.dart';
import 'package:pipelines_app/features/changes/changes.dart';
import 'package:pipelines_app/features/runs/data/runs_repository.dart';
import 'package:pipelines_app/features/runs/ui/run_changes_action.dart';
import 'package:pipelines_app/features/runs/ui/run_detail_view.dart';
@@ -138,9 +139,15 @@ void main() {
find.textContaining('The summary counts each path once'),
findsNothing,
);
// The visit's own recorded capture stays reachable.
// The visit's own recorded capture stays reachable, one visit page at
// a time; the second visit's gap is reachable with Next.
expect(find.text('lib/feature.dart'), findsOneWidget);
expect(find.text('Visit 1 · completed'), findsNWidgets(2));
expect(find.text('implementer'), findsOneWidget);
expect(find.text('Visit 1 · completed'), findsOneWidget);
await tester.tap(find.text('Next visit'));
await tester.pump();
expect(find.text('reviewer'), findsOneWidget);
expect(find.text(missingCaptureDetail), findsOneWidget);
expect(tester.takeException(), isNull);
},
);