Merge commit 'f9eac4d6a3cc42a133ed74691d5cf2d6119633dc' into pipelines/run-20261112-0144-ctrl-tab-floating-chats-when-shown-else-c9bd

This commit is contained in:
2026-11-12 02:46:07 +00:00
115 changed files with 4484 additions and 677 deletions
@@ -0,0 +1,91 @@
# Android background delivery: survive Doze, sign-in, battery, diagnosis
Stage 01-implement, run 20261112-0157. Source only; not committed, not installed.
## What changed
- **Reconnects are alarms, not handler delays.** `ReconnectAlarms` schedules
`setExactAndAllowWhileIdle` when `canScheduleExactAlarms()`, otherwise
`setAndAllowWhileIdle`. The alarm PendingIntent is a foreground-service intent
to `NotificationService` (`ACTION_RECONNECT`). The `Handler.postDelayed`
reconnect is gone.
- **Watchdog.** `NotificationWatchdog` (JobScheduler, periodic 15 min,
persisted) restarts the service when delivery is enabled and the socket is
down with no reconnect pending. It does not restart while signed out or
waiting for a network. Also scheduled by `NotificationService.start`.
- **Connect wake lock.** `ConnectWakeLock` holds a partial wake lock for 30 s
from `connect()` until the socket opens or fails.
- **Swipe away.** `onTaskRemoved` logs and queues a watchdog check 2 s later.
- **Battery exemption.** `SettingsDeviceDeliverySection` shows a persistent
warning row while delivery is on and the exemption is missing, with the
Samsung "Never sleeping apps" note. `setEnabled(true)` requests the
exemption before starting the service. Opening Settings with delivery already
on and the exemption missing asks once per open (`NotificationServiceController.open`);
resume refreshes never ask again.
- **HTTP 401/403.** The retry loop stops, status becomes `sign_in_required`,
and a "Sign in to Pipelines again to keep notifications" notice is posted
(channel `pipelines.account`, id 2). `configure` with a fresh cookie restarts
the service.
- **Connection log.** `ConnectionLog` keeps the last 50 events (time, event,
error, HTTP code) in the service preferences. The channel method
`connectionEvents` returns them. Settings shows them in an expandable
"Connection log" row.
## Files
- Kotlin (new): `ReconnectPolicy.kt`, `ReconnectAlarms.kt`,
`NotificationWatchdog.kt`, `ConnectWakeLock.kt`, `ConnectionLog.kt`
- Kotlin (changed): `NotificationService.kt`, `NotificationPresenter.kt`,
`NotificationServiceChannel.kt`, `ServiceSettings.kt`, `AndroidManifest.xml`
(WAKE_LOCK, SCHEDULE_EXACT_ALARM, watchdog service)
- Kotlin tests (new): `ConnectionLogTest.kt` (5), `ReconnectPolicyTest.kt` (3)
- Dart (new): `lib/features/notification_service/notification_service_events.dart`
- Dart (changed): `notification_service_bridge.dart`,
`notification_service_controller.dart`, `notification_service_status.dart`,
`lib/features/settings/settings_device_delivery_section.dart`
- Dart tests (changed): `test/features/settings/settings_device_delivery_section_test.dart`
(+8 cases), `test/features/notification_service/notification_service_bridge_test.dart`
(+3 cases), `test/features/notification_service/fake_notification_service.dart`
## Focused results
- Kotlin: `gradle :app:testDebugUnitTest --tests 'net.awan.pipelines_app.notify.*'`
BUILD SUCCESSFUL. 28 of 28 pass: ConnectionLogTest 5, ReconnectPolicyTest 3,
DeliveryLedgerTest 8, NotificationProtocolTest 12. Includes main-source compile.
- Flutter: `tool/memwatch/full.sh` on the four files below, PASS 35 passed,
0 failed (run twice, once after formatting):
- test/features/settings/settings_device_delivery_section_test.dart
- test/features/notification_service/notification_service_bridge_test.dart
- test/features/notification_service/notification_service_handoff_test.dart
- test/features/attention/notify/notification_delivery_test.dart
- `tool/analyze.sh`: clean (run twice).
## Affected UI states (for ui-review, not captured here)
- Delivery on, exemption missing: warning row visible with Samsung note.
- Delivery on, exemption granted: warning row gone; battery row says "Allowed".
- Delivery off: no battery row, no warning row.
- Status "Sign in to Pipelines again to keep notifications".
- Connection log collapsed, expanded with events, expanded empty
("No connection events yet"). Expansion needs an interactive check.
## Limitations and decisions
- **Not verified on a device.** Doze timing, alarm delivery, the
foreground-start exemption from alarms and the watchdog job, the swipe
restart, and the sign-in notice were not run. The Fold was not touched.
- **Exact alarms.** SCHEDULE_EXACT_ALARM is declared, but the app does not
send the user to grant it. Without the grant, reconnects use
idle-tolerant alarms.
- **Upgrade users are prompted when Settings opens, not at app start.** The
exemption is requested on switch-on, and on opening Settings while delivery
is on and the exemption is missing. The prompt is not fired from app start
because the section is the only place with the request context. A user who
declines is prompted again the next time Settings opens, then sees the
warning row. Users who never open Settings are not prompted.
- **JobScheduler is deferred in Doze**, so the watchdog is a backstop; the
alarms are the primary path.
- NotificationService.kt is 387 lines (aim is under 250; it was 293 before).
The reconnect alarms, watchdog, wake lock and log are in separate files,
but the socket state machine remains in the service; splitting it further is
a follow-up.
+54
View File
@@ -0,0 +1,54 @@
# Chat Back starts immediately (phone)
## Finding
Static reading of the phone chat path (`DetailPageHost`, `ContainerTransformPageRoute`,
`ContainerTransformFlight`, the chat screen's `_back`, the shell's back handling) found no
awaited work before the pop. Draft, scroll and transcript saves run fire-and-forget or in
`dispose`, after the reverse animation. `DetailPageHost`'s `onClosed` runs when the route is
disposed, so it cannot delay the pop.
The delay the user sees is the close curve. Closing used `Curves.fastOutSlowIn.flipped`
against the animation value, which barely moves for its first ~60 ms. The page sat still
after Back, then began to shrink.
## Change
`lib/ui/motion/container_transform_flight.dart`: the closing shrink uses
`Curves.easeInCubic.transform(t)` on the reverse animation value. That is a shrink that starts
on the first frame and decelerates into the row. Opening is unchanged. The reverse duration
stays at `Motion.containerTransformReverse` = 250 ms (≤300 ms).
## Measured (widget test, fake frame clock, 390x844, 16 ms per frame)
Share of the page's shrink travel completed after each frame following the system Back
(`handlePopRoute` then `pump`). The first frame after the pop only starts the ticker, so it
reads 0 in both builds.
| Elapsed after pop | Before | After |
| --- | ---: | ---: |
| 16 ms | 0.0% | 0.0% |
| 32 ms | 1.0% | 15.7% |
| 48 ms | 4.6% | 30.7% |
| 64 ms | 12.1% | 44.1% |
| 80 ms | 25.2% | 56.4% |
The Back route is no longer current, and its animation is `reverse`, after the first pump
in both builds. Route change was already synchronous.
## Focused tests
Command: `tool/memwatch/full.sh 'test/ui/motion/container_transform_back_start_test.dart test/ui/motion/container_transform_route_test.dart test/shell/detail_page_test.dart test/features/chat/chat_open_transition_test.dart'`
Result: 15 passed, 0 failed (peak 1284 MB, 11 s).
- New regression `container_transform_back_start_test.dart`: system Back changes the route
in one pump, and the page is more than 10% shrunk 16 ms later. The owner's close work
awaits a future that never completes, and Back still starts. Against the old curve this
test fails (shrink 0.99%).
- `tool/analyze.sh`: clean.
## Not verified
- `tool/chat_back_latency_probe.mjs` (browser) was not run; UI capture belongs to ui-review.
- Phone device timing was not measured (no device test ran).
- Leaving the chat list (tab-root Back) was read, not measured: it calls `_select` synchronously.
+6 -5
View File
@@ -15,13 +15,14 @@ every destination and come back at app start without Chat being opened.
chat's window last was, else at the default frame stepped 32 px per chat
window already open.
- **Window**: drag the title bar to move, the lower right corner to resize,
double click the title to maximise. The title bar has Dock, Minimise,
Maximise and Close.
double click the title to maximise. The title bar has Dock, Maximise and
the X.
- **Dock** puts the chat back into the tiling, right of the active pane. When
the Chat destination is not built it opens the chat there instead.
- **Minimise** hides that window; the chord brings it back.
- **Close (X)** closes the window and returns nothing to the tiling. The chat
itself is not closed on the server.
- **X** (tooltip and semantics: Minimise) hides that window, keeping its state;
it stays listed in the Windows menu and the chord brings it back. It never
closes the window, the chat or the tiling: nothing returns to the tiling.
The chat itself is not closed on the server.
- **Chord**: Alt+Y, Ctrl+Y, and Cmd+Y on Apple platforms (`chatFloatShortcut`).
With chat windows open it hides or shows all of them. With none it floats the
active tiled pane, when that pane can float and Chat has the keyboard;
+37
View File
@@ -0,0 +1,37 @@
# Ctrl+A toggles Runs and Pipelines
Stage 01-implement (artifact 401). Not committed.
## Behaviour
- Ctrl+A (the same chord on every platform) moves the shell between destinations:
- from Runs, to Pipelines;
- from Pipelines, to Runs;
- from any other destination (Chat, Search, Settings), to Runs.
- It is matched like Ctrl+K in `shell/adaptive_shell.dart`: logical key A with Ctrl alone. Alt, Shift, Cmd, Ctrl+Alt, and key-up events do not match. Repeats of a held chord are swallowed; only the first key-down acts.
- It does not act while a text field (`primaryFocusTakesTyping`) or a `TypingSurface` such as the terminal has focus. The handler returns false, so the field or terminal keeps Ctrl+A (select all, line start).
- The switch goes through the shell's normal `_select`, so a controlled shell (`onDestinationSelected`) receives the destination.
## Changed paths
- `app/lib/shell/shell_runs_pipelines_shortcut.dart` (new): `shellRunsPipelinesShortcut` (matcher), `shellRunsPipelinesTarget` (destination rule), `shellRunsPipelinesShortcutLabel` (`'Ctrl+A'`).
- `app/lib/shell/adaptive_shell.dart`: one branch in `_handleDestinationKeyEvent`, after the Ctrl+K branch and before the typing-surface check; updated doc comment.
- `app/lib/features/settings/keyboard_shortcuts_registry.dart`: "Switch between Runs and Pipelines" help entry, `Ctrl+A` on every platform, with a caveat about text fields and the terminal.
- `app/test/shell/runs_pipelines_shortcut_test.dart` (new): matcher, destination rule, Chat→Runs→Pipelines→Runs sequence, text-field exception, terminal exception.
- `app/test/features/settings/keyboard_shortcuts_help_test.dart`: help entry test over every `TargetPlatform` value.
## Focused results
- `tool/memwatch/full.sh 'test/shell/runs_pipelines_shortcut_test.dart test/features/settings/keyboard_shortcuts_help_test.dart test/shell/shell_chat_shortcut_test.dart test/shell/destination_shortcuts_test.dart'`: PASS, 19 passed, 0 failed, peak 1151 MB, 13s, exit 0.
- Mutation check: with the `primaryFocusTakesTyping()` guard removed, `runs_pipelines_shortcut_test.dart` fails (2 failed, including the text-field case). The guard was restored; the file matches the pre-mutation backup.
- `tool/analyze.sh` on the changed files: clean, exit 0. Run after the focused tests, sequentially.
- No existing test sends Ctrl+A. The `keyA` uses in `chat_shell_terminal_test.dart` and `chat_transcript_selection_test.dart` are plain or Cmd+A, so they are unaffected.
## Affected states
- Shell tabs: Pipelines, Runs, Chat, Search, and Settings (a page of Pipelines).
- Text field focused: Ctrl+A goes to the field.
- Terminal focused: Ctrl+A goes to the terminal.
- Help page: new "Switch between Runs and Pipelines" row.
## Not covered
- No UI capture or device run (ui-review owns that).
- The text-field test pins the platform to Android so that Ctrl+A means select all. On Apple platforms Ctrl+A is line start in the field; the field still keeps it, but that case is not tested.
- The chat composer is not tested directly; it is a text field, so the same guard applies.
- On web, the browser may keep Ctrl+A; the registry caveat does not mention this.
+117
View File
@@ -0,0 +1,117 @@
# First-run walkthrough
A short, skippable four-page walkthrough for new users of the Flutter app.
## What it does
- Shows once per device on first launch, from the Pipelines page.
- Is also offered once per server when the device has already seen it and the
connected server has no pipelines, runs or chats yet (the server is checked
with `list_pipelines`, `list_runs` and `chat_sessions`; an unreadable server
never triggers it).
- Pages: 1) what Pipelines is and how to connect to the server; 2) set up an
agent harness, with an agent picker and one copy button for
`pipelines harness setup <agent>` (`claude`, `codex`, `opencode`, `pi`);
3) the Pipelines and Runs tabs and how to start a run; 4) the Chat tab, float
and terminal.
- Every page has Skip; Back and Next move between pages; Done ends on the last.
- Closing by any route (Skip, Done, the close gesture, a tap outside) records the
device as seen.
- Settings reopens it from Tools → Help → "Show the walkthrough". Reopening
does not change the seen record.
## Where it lives
- `lib/features/walkthrough/`
- `walkthrough_store.dart`: the seen/offered records (`pipelines.next.*` keys;
a store that cannot be read reports "seen", so it never nags).
- `walkthrough_steps.dart`: the page copy and agent list (pure data).
- `first_run_walkthrough.dart`: the stepper and `showFirstRunWalkthrough`
(a Material bottom sheet on phones, a dialog on wide windows, via
`showAppDetails`).
- `walkthrough_harness_command.dart`: agent chips, the command and copy.
- `walkthrough_gate.dart`: the first-launch and empty-server check.
- `lib/application/pipelines_app.dart`: wraps the Pipelines destination body in
the gate (the Pipelines tab is the first screen).
- `lib/features/settings/settings_walkthrough_section.dart`: one row in the
Tools → Help group, plus `SettingsKeys.walkthrough`.
## Focused tests
- `test/features/walkthrough/walkthrough_gate_test.dart`: first launch shows
once; Done and Skip persist; a seen device on an empty server is offered once;
a seen device that starts disconnected makes no server call and is offered
after it connects; an unreadable check is retried on the next connection (and
a repeated notification while connected does not re-query); a server with
work, an unreadable server, a hidden Pipelines page, and an unavailable store
all stay quiet; hiding the Pipelines page while the first-launch read is
still pending keeps the walkthrough closed, and showing it again offers it
once.
- `test/features/walkthrough/first_run_walkthrough_test.dart`: phone bottom
sheet and wide dialog; Back disabled on page 1; four pages with Done on the
last and Skip throughout; the harness picker and copy; large text (2x) and
dark mode without overflow.
- `test/features/settings/settings_walkthrough_test.dart`: the Settings row
reopens the walkthrough on page 1.
## Results
- Focused run: `tool/memwatch/full.sh 'test/features/walkthrough/first_run_walkthrough_test.dart test/features/walkthrough/walkthrough_gate_test.dart test/features/settings/settings_walkthrough_test.dart'`
→ PASS, 20 passed, 0 failed, peak 1031 MB, 16 s. The verdict named only these
three paths.
- Visibility fix (review must-fix, visit 2): the gate offered without checking
`enabled`, so a walkthrough could open over another destination if Pipelines
was hidden before the post-frame callback or during a pending read. The gate
now checks `mounted && enabled` in the callback, after each await, and before
each show. A skipped callback clears the in-flight flag, so re-enabling
Pipelines reschedules the offer. Covered by the new gate test
"hiding Pipelines while an offer is pending keeps the walkthrough closed".
That test was not run against the pre-fix code, so the failing-before claim
is by reasoning only.
- Lifecycle fix (review must-fix): the empty-server check used to run once
right after the first frame, before the session connected. A seen device
then got a `NotConnectedError`, and the check was never retried. The gate now
takes the session as its connection source (`connection` + `connected`), waits
while disconnected, re-runs on each new connection until the server answers,
and stays quiet on a repeated notification while connected. A connection that
arrives between frames requests a visual update, so the post-frame callback
runs. The fix is covered by the two new gate tests above.
- Two earlier runs failed and were fixed in the test code, not by weakening
expectations: the large-text test tapped Next before scrolling it into view,
and the "unavailable store" test awaited the real preferences plugin inside
`testWidgets` and hung. The store now takes an injectable opener, so that case
is a plain test with a null opener.
- `tool/analyze.sh`: clean (0 errors, 0 warnings, 0 infos).
- Not run here: `pipelines_app_test`, the Settings screen suites and the other
Pipelines suites. They belong to the land gate.
## Affected states (checked by focused tests only; nothing captured)
- Phone (390×844): bottom sheet; page 1 with Back disabled; all four pages;
Skip mid-walkthrough.
- Wide (1280×900): dialog; Next reaches page 2.
- Harness page: four agent chips; the command follows the selected agent; copy
copies the selected command and the button shows a check.
- Large text (2×) on a 360×740 phone and dark mode: every page builds with no
exception.
- Gate: first launch once; Done and Skip persist; a seen device on an empty
server is offered once per server; a server with runs, an unreadable server,
a hidden Pipelines page and an unavailable store stay quiet.
- Settings: "Show the walkthrough" reopens page 1 and does not change the seen
record.
Nothing was built, run on a device or captured. `ui-review` owns the rendered
review.
## Limitations
- The gate is tested in isolation with fake stores and gateways. The Pipelines
wiring in `pipelines_app.dart` is not covered by a focused test.
- Narrow window: the empty-server offer marks the server as offered before it
shows. If Pipelines is hidden during that one store write, the server is
consumed without the walkthrough appearing. Fixing it needs the store write
to move to the dialog's close, which changes when the offer is recorded.
- On phones the walkthrough is a Material bottom sheet, not a full page.
- The harness command is shown as a picker with one copy button for the
selected agent, not four separate copy buttons.
- The "Show the walkthrough" test covers the row, not the whole Settings tree.
+4 -3
View File
@@ -15,7 +15,8 @@ mode (below). `FloatingLayer`, the overlay the old windows used, is gone.
- `WindowHost`: the windows as plain children of the terminal stage's stack, in
the shell page (not an overlay above it), outside every destination.
- `WindowLayer` / `WindowFrame`: one window's card, title bar (drag, double
click to maximise, kind actions, Minimise, Maximise, Close) and resize corner.
click to maximise, kind actions, Maximise, the X = minimise) and resize corner.
There is no separate Minimise button; the X hides the window and keeps it.
- `WindowNavigator`: each window's own page stack.
- `WindowFocus`: a focus scope per window; the keyboard follows the top window
and returns to what had it when the last one hides.
@@ -73,8 +74,8 @@ the device, not a server) and `TerminalWindows`, which keeps it in step with
float, panel height); the bottom panel is still a shell panel.
- Showing the terminal in float mode opens or shows the window; hiding it
(Alt+T, Ctrl+`, the options menu) minimises it. The window's Minimise and
Close both hide the terminal. Its shells and tabs live in `TerminalHub`, so
(Alt+T, Ctrl+`, the options menu) minimises it. The window's X (minimise)
hides the terminal. Its shells and tabs live in `TerminalHub`, so
nothing is lost either way, and the window comes back where it was.
- The frame and maximised state are the window system's. The first window
takes the ones `pipelines.terminal-layout.v1` saved before; that record is
+124
View File
@@ -0,0 +1,124 @@
# Wide destination rail with Settings
On a wide window the shell's four destinations (Pipelines, Runs, Chat, Search)
move from the floating bottom-left pill to a Material `NavigationRail` at the
left edge, with Settings pinned to its foot. The rail keeps the running and
unread badges. The Pipelines toolbar's Settings gear is removed where the rail
shows. Phone and narrow layouts are unchanged.
## Design
- **Threshold.** The rail shows at window width >= 697
(`kNavigationRailMinWindowWidth` = `kListDetailMinWidth` 600 +
`kNavigationRailSpace` 97, the rail plus its divider). The body beside the
rail therefore still meets the list/detail split threshold at 697 px. Between
600 and 696 px the floating bar and split layout stay as before.
- **Layout.** `AdaptiveShell.build` returns the same tree at every width:
`Row[rail slot, divider slot, Expanded(ShellRailScope(Scaffold))]`. On a
phone the first two slots are empty. Resizing across the threshold does not
remount a destination, and pages pushed over a tab keep their state.
- **Body width.** `ShellRailScope.bodyWidth` is the window width less the rail
and its divider (`kNavigationRailSpace` = 97), computed in `build`. The
list/detail policy reads it through `ShellRailScope.windowWidth`
(`list_detail.dart`, `list_detail_policy.dart`), so `showsListBesideDetail`
and the pane widths follow the body. Outside the scope the window width still
applies.
- **Rail items** (`navigation_rail.dart`). Four `NavigationRailDestination`s
with `labelType: all`, `trailingAtBottom: true`. Each tab's icon keeps its
badge (`_icon`), a `Tooltip` with its label, and the `shell.destination.<tab>`
key the floating bar used. Settings is a custom `_SettingsRailItem` in
`trailing`, styled like a rail destination (stadium indicator, same colours).
A `NavigationRailDestination` cannot be pinned, so it is not one.
- **Window host.** Floating windows overlay the whole app, so `WindowHost` takes
`reservesRail` (set by `pipelines_app.dart`) and starts its bounds after the
rail and divider (`kNavigationRailSpace`, 97 px, the same inset the shell
uses) when the window is wide enough. Tests that mount the host without a
shell keep the full width.
- **Pipelines gear.** `ShellRailScope.isShown` hides `pipelines-open-settings`
in the shell's toolbar while the rail shows. On a phone it stays.
## Changed paths
- `app/lib/shell/navigation_rail.dart` (new): rail widget, Settings item,
threshold constants.
- `app/lib/shell/shell_rail_scope.dart` (new): body-width scope.
- `app/lib/shell/adaptive_shell.dart`: rail layout and constant tree shape.
- `app/lib/shell/list_detail.dart`, `app/lib/shell/list_detail_policy.dart`:
read the body width through the scope.
- `app/lib/shell/windows/window_host.dart`: `reservesRail` inset (97 px).
- `app/lib/shell/destination.dart`: comment only.
- `app/lib/features/pipelines/screen.dart`: gear hidden beside the rail.
- `app/lib/application/pipelines_app.dart`: `WindowHost(reservesRail: true)`.
## Focused results
Review fix (off-by-one at the threshold): the rail threshold and the
`WindowHost` inset both use `kNavigationRailSpace` (97). Re-run from `app/`
with `tool/memwatch/full.sh`:
- Rail and window-host files (`navigation_rail_test`, `windows/window_host_test`,
`windows/window_layering_test`): `PASS: 21 passed` earlier, then covered by the
run below.
- All 18 changed test files plus the rail and window-host tests
(`application/`, `features/chat/`, `shell/`, `shell/windows/`):
`memwatch: PASS: 108 passed, 0 failed, 0 skipped; exit 0`. The verdict names
only the intended paths.
- `tool/analyze.sh` (whole app, run after the focused tests): `analyze: clean`.
New tests (`test/shell/navigation_rail_test.dart`):
- Wide: labelled rail, full height, left edge, Settings pinned below the tabs.
- Selection marks the tab and one tap selects another.
- Settings opens as a page from the rail foot; no tab is selected meanwhile;
Back returns to Pipelines.
- Running count on the Runs item of the rail.
- A list and its open item lay out to the right of the rail.
- The rail appears at 697 and not at 696; at 697 the list and detail sit side by
side (list starts at 97, detail ends at 697); phone and 640 keep the floating bar.
- Floating windows start after the rail (97) with `reservesRail`, and at 500 px
they use the full width.
- Crossing the threshold keeps a destination mounted with its state.
Updated expectations (each one is a consequence of the rail, not a behaviour
change the task did not ask for):
- Wide-window floating-bar tests moved to 640 px, where the bar still sits
beside the list (`floating_tab_bar_test`, `split_destination_bar_test`,
`split_detail_pages_test`, `split_status_bar_test`, `pane_bar_row_test`,
`chat_sidebar_clearance_test`). The width-driven policy numbers
(`list_pane_resize_test`) now use the body width.
- `settings_page_test`: the gear case runs on a phone; a wide case opens
Settings from the rail. `tab_location_navigation_test` uses the rail's
Settings item at 1100 px.
- `chat_registration_test`, `chat_list_detail_test`, `attention_badge_test`:
the rail replaces the bottom bar at wide widths.
- `list_pane_resize_test` (grip): one `pumpAndSettle` instead of one `pump`.
The focus emphasis reaches the grip one frame later beside the rail. The
expectation (emphasised on focus) is unchanged.
- `chat_sidebar_clearance_test`: the scroll offset is kept up to the new
maximum extent. At 640 px the list is narrower than beside the rail, so its
rows re-wrap and the content is shorter.
- `chat_split_integration_test`: the compact menu's "Runs" is picked by
element, not by text, because the rail also labels Runs. The rail's tooltips
keep `byTooltip('Chat')` working.
- Floating-window expectation (`navigation_rail_test`): the probe window starts at
`100 + kNavigationRailSpace` (97), not 96.
## Affected states
- Wide, rail shown (>= 697 px): rail with badges, Settings pinned, lists beside
the rail, floating windows beside it, no Pipelines gear, Settings page with
Back.
- 600-696 px: floating bar and split layout as before (no rail).
- Phone: unchanged, including the Pipelines gear.
## Limitations
- Not verified in a browser or on a device. `ui-review` owns captures. The
visual match of the rail and the Settings item is by reading the Material
sources, not by a capture.
- The terminal panel is laid over the app's bottom edge (`TerminalStage`), not
inside the shell. When it is open on a wide window it may cover the rail's
foot and Settings. This follows from the stack layout; it was not captured.
- The compact list's "Menu" sheet (`ShellDestinationMenu`) still offers the
destinations beside the rail. It is a duplicate, not a removed feature.
+39
View File
@@ -0,0 +1,39 @@
# Run detail: Output section starts expanded
## Change
- The run Summary's Output section (`run-detail-summary-output`) now starts open.
Input still starts closed. The Summary's default is restored on a different run
and when a search hit names no section (`RunDetailTabs._resetSummarySections`).
- A visit's Summary Output (`run-visit-section-Output`) starts open; Input starts
closed (`_VisitSummaryState._closed = {'Input'}`).
- Both stay collapsible by tapping the title. The open/closed state lives in the
controller or State for that view only; it is not persisted.
- Long outputs: Output is a sliver. `RunFieldSliver` (in `run_field_body.dart`)
builds one `SliverList` row per recorded
field, so a map with hundreds of fields lays out only the rows on screen. It
is used for the run Summary Output (`_StickyField.sliverBody`) and the visit
Summary Output (`_section(..., lazy: true)`), both through `StickySection`'s
sliver path. A closed `SliverReveal` builds nothing.
- Input stays on the box path (`RunFieldBody`); it starts closed, so its cost is
paid only when the operator opens it. The box and sliver forms share the row
builder, so they render the same fields.
## Tests (run through `tool/memwatch/full.sh`, one quoted path list)
- Command: `tool/memwatch/full.sh 'test/features/runs/ui/run_detail_visit_sections_test.dart test/features/runs/ui/run_detail_summary_fields_test.dart test/features/runs/ui/run_detail_widget_test.dart test/features/runs/ui/run_search_selection_test.dart test/features/runs/ui/run_detail_tabs_test.dart test/features/runs/ui/run_detail_visit_test.dart'`
- Verdict (final code): `PASS: 49 passed, 0 failed, 0 skipped; peak 1884 MB; 32s; exit 0`
- New: visit Output starts expanded and collapses/reopens; run Output starts
expanded and collapses for the view; a 500-field visit Output opens with only
its first field built and the page scrolls to the last one (lazy regression).
- Updated (the old expectation was that Output started closed): visit tab/empty-state
tests, run Summary empty-wording and recorded-input tests, search-selection tests
for input, retired field and replacing a visit with the Summary.
- Not changed: Input's closed default and every Input expectation.
## Analyze
- `tool/analyze.sh`: `analyze: clean; 10s; exit 0`
- `dart format --set-exit-if-changed` on the changed files: formatted one widget
test file (whitespace only).
## Limitations
- No widget capture or browser/device check was run here; ui-review owns that.
- Very long Output is laid out when the section opens. Not measured for jank.
+55
View File
@@ -0,0 +1,55 @@
# Window X minimises (no separate Minimise button)
## Change
- The title bar of a floating window is now: kind actions (Dock on a chat),
Maximise / Restore size, then the X.
- The X hides the window and keeps its state, exactly as Minimise did. Its
tooltip and semantics are `Minimise`. It keeps the X glyph (`Icons.close`).
- The X never calls the kind's `closed` hook, so a chat window keeps its chat
open on the server and returns nothing to the tiling.
- `WindowFrame` no longer takes `onClose`; `WindowLayer` wires the X to
`manager.setMinimized(id, true)`.
- Unchanged: the chord (Alt+Y) shows hidden chat windows; the Windows menu
still lists minimised windows with a minimise mark and shows them on choice;
Show all, Minimise all and Close all stay in that menu. Terminal windows
still hide the terminal when their window is hidden by the X.
Changed paths (under `app/`):
- `lib/shell/windows/window_frame.dart`, `window_layer.dart`, `window_kind.dart`,
`window_entry.dart` (comments and the frame's parameters)
- `lib/features/terminal/terminal_window.dart` (comment only)
- `test/shell/windows/window_host_test.dart`, `window_layering_test.dart`
- `test/features/chat/chat_floating_pane_test.dart`
- `test/features/terminal/terminal_surface_test.dart`
- `notes/floating-windows.md`, `notes/chat-floating-pane.md`
## Focused results
- `tool/memwatch/full.sh 'test/shell/windows/window_host_test.dart
test/shell/windows/window_layering_test.dart
test/shell/windows/window_conveniences_test.dart
test/features/chat/chat_floating_pane_test.dart
test/features/terminal/terminal_surface_test.dart'`:
PASS, 72 passed, 0 failed, 0 skipped, exit 0.
- `tool/analyze.sh`: clean, exit 0.
- Not run: the full suite (the land gate runs it). No Cupertino code or tests
touched.
## Affected states (widget-test coverage only)
- Window title bar: no `Close` tooltip; `Minimise` on the X; `Maximise` /
`Restore size` unchanged.
- Chat window: X hides it; the chat stays open, is not docked and sends no
`chat_close`; the chord shows it again with the same frame and composer.
- Probe window: X keeps the entry (minimised), the content state survives, and
the group toggle brings it back.
- Terminal float window: X hides the terminal and keeps its tabs; the chord
shows it again at the same frame.
## Limitations
- No browser or device capture here; `ui-review` owns the title-bar captures.
- The X glyph with a Minimise tooltip is a deliberate choice; a minimise glyph
would be a one-line change in `window_frame.dart` if preferred.