From c8e4faf6a4d46e56b557e4860413281c187d7b74 Mon Sep 17 00:00:00 2001 From: Alan Silva Date: Tue, 10 Nov 2026 19:01:48 +0000 Subject: [PATCH] Plan desktop menus instead of bottom sheets --- docs/plans/floating-windows.md | 27 +++++++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/docs/plans/floating-windows.md b/docs/plans/floating-windows.md index 7c60ccac..469a24e9 100644 --- a/docs/plans/floating-windows.md +++ b/docs/plans/floating-windows.md @@ -272,6 +272,24 @@ neighbours. Runs. - Reload restores windows without visiting Chat. +### Phase 2b: desktop menus instead of bottom sheets + +One change per surface, each with captures of the menu open, in the tiling +and in a window: + +1. **Adaptive helpers** (`showAppChoiceMenu`, `showAppDetails`) in `ui/adaptive/`. + - On a wide layout: an anchored `MenuAnchor` panel, or a dialog/popover for + details. + - On a phone: the bottom sheet. + - Root-targeted, so they are always above windows. +2. **Mode picker** (`chat_mode_control.dart:86`) and add-pane picker + (`chat_add_pane_picker.dart:34`). +3. **Turn, diff and shell-history sheets** (`chat_turn_chip.dart:130`). +4. **Chat details** (`chat_thread_view.dart:535`) and file details + (`files_details.dart:92`) as dialogs/popovers. +5. **Files sort and row menus** (`AppOverflowMenu`), and runs sort + (`runs_filters.dart:264`). + ### Phase 3: terminal on the window system 1. **`terminal` window kind** reusing `TerminalHub`. The panel mode stays a @@ -307,13 +325,14 @@ neighbours. Navigator/Overlay, and `Tooltip`/`MenuAnchor` need a root-targeting wrapper because `RawTooltip` only uses the nearest overlay. - Layering tests (Phase 1.4) cover both: pages inside, popups above. -2. **Bottom sheets vs menus: open.** Proposal (explained to the user): - - On desktop, short choice lists (mode, sort, add pane, turn options) become - menus anchored to their button. +2. **Menus instead of bottom sheets on desktop (decided).** + - Short choice lists become menus anchored to their button: mode, sort, + add pane, turn options, file row actions, and any other list of options. - Richer content (chat details, file details) becomes a dialog or a popover beside the button. - Phones keep bottom sheets. - - Waiting for the user's answer; not needed before Phase 1. + - Built into the shared popup helpers from Phase 1, so window content and + the tiled app get the same behaviour (see Phase 2b). 3. **Window chrome: minimize and close.** - Every window gets a minimize button (the window hides; it stays in the window list and its group's show/hide chord).