Merge commit '82418d31a76548ef5d5965a4472582740036dbc6' into pipelines/run-20261112-1022-settings-as-a-top-level-destination-5a4e

This commit is contained in:
2026-11-12 10:40:58 +00:00
6 changed files with 282 additions and 20 deletions
+2 -2
View File
@@ -52,8 +52,8 @@ class AppTerminals {
/// [shell] with the terminal panel, window or page around it, and the
/// app's floating [windows] above both.
/// [onChat]: the phone shortcut that reopens the terminal shows on the
/// Chat tab only.
/// [onChat]: whether the phone shortcut that reopens the terminal shows on
/// this page. Pages whose own bar carries Terminal pass false.
Widget surround(Widget shell, {bool onChat = true, Widget? windows}) =>
TerminalSurface(
hub: hub,
+5 -1
View File
@@ -828,7 +828,11 @@ class _PipelinesAppState extends State<PipelinesApp>
valueListenable: _attentionCount,
builder: (context, count, _) => _terminals.surround(
_shellFor(route, count),
onChat: route.kind == AppRouteKind.chat,
// Every narrow Chat bar carries Terminal itself (the list's top bar
// and an open chat's bar, see terminalChatBarAction), so the floating
// bubble is off on every route. It otherwise covered the list's
// header and duplicated the open chat's Terminal entry.
onChat: false,
windows: WindowHost(manager: _windows, reservesRail: true),
),
);