Remove Cupertino remnants from runs and pipelines
Keep the assigned runs and pipelines UI Material-only by removing alternate icons, host branches, and Cupertino color usage while preserving compatibility parameters needed by other callers. Update mirrored tests and record focused verification for the cleanup.
This commit is contained in:
@@ -1,7 +1,7 @@
|
||||
import 'package:flutter/cupertino.dart';
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter_test/flutter_test.dart';
|
||||
import 'package:pipelines_app/features/runs/ui/run_path_mini.dart';
|
||||
import 'package:pipelines_app/ui/status/run_status_icon.dart';
|
||||
|
||||
void main() {
|
||||
final run = {
|
||||
@@ -42,7 +42,14 @@ void main() {
|
||||
.whereType<Color>()
|
||||
.map((color) => color.toARGB32())
|
||||
.toList();
|
||||
expect(colors, contains(CupertinoColors.systemGreen.color.toARGB32()));
|
||||
expect(colors, contains(CupertinoColors.systemRed.color.toARGB32()));
|
||||
final context = tester.element(find.byKey(const Key('run-path-mini')));
|
||||
expect(
|
||||
colors,
|
||||
contains(runStatusColor('succeeded').resolveFrom(context).toARGB32()),
|
||||
);
|
||||
expect(
|
||||
colors,
|
||||
contains(runStatusColor('failed').resolveFrom(context).toARGB32()),
|
||||
);
|
||||
});
|
||||
}
|
||||
|
||||
@@ -119,19 +119,14 @@ void main() {
|
||||
final shell = {
|
||||
for (final destination in shellTabDestinations) ...[
|
||||
destinationDetails(destination).icon,
|
||||
destinationDetails(destination).cupertinoIcon,
|
||||
],
|
||||
};
|
||||
final details = [
|
||||
for (final tab in renderedRunDetailTabs) ...[tab.icon, tab.cupertinoIcon],
|
||||
for (final tab in renderedRunDetailTabs) tab.icon,
|
||||
for (final section in shownVisitSections) ...[
|
||||
section.icon,
|
||||
section.cupertinoIcon,
|
||||
],
|
||||
for (final tab in PipelineDetailTab.values) ...[
|
||||
tab.icon,
|
||||
tab.cupertinoIcon,
|
||||
],
|
||||
for (final tab in PipelineDetailTab.values) tab.icon,
|
||||
];
|
||||
for (final icon in details) {
|
||||
expect(shell.contains(icon), isFalse, reason: '$icon');
|
||||
|
||||
Reference in New Issue
Block a user