diff --git a/web/PARITY.md b/web/PARITY.md index abe7f6f4..2798250e 100644 --- a/web/PARITY.md +++ b/web/PARITY.md @@ -25,6 +25,13 @@ no document overflow; captures and `geometry.json` are in `/private/var/folders/jp/q0qvjyg54fl_c5vhhk1ylz2m0000gn/T/opencode/status-miniature-captures/`. These are deterministic fixture captures, not a new live-server parity claim. +Collapsed desktop navigation additionally gives Expand its own 40px flow slot +above the Pipelines brand instead of overlaying it. The same scratch browser +extension asserts non-overlap with brand and first destination, expands again +through the real button at 1100px, and checks the rail remains hidden at +390/420px. Captures: `rail-collapsed-1100.png`, `rail-expanded-1100.png` in the +directory above. Mobile and the expanded rail are unchanged. + ### Chat audit follow-up (2026-10-20, partial — fresh UI captures pending) Codex model follow-up (partial, fixture-tested; fresh UI captures pending): diff --git a/web/lists.css b/web/lists.css index 4d623392..9a879a7c 100644 --- a/web/lists.css +++ b/web/lists.css @@ -369,6 +369,17 @@ .app-rail.collapsed .rail-search { justify-content: center; width: 40px; padding: 0; gap: 0; } .app-rail.collapsed .rail-destinations { align-items: center; } .app-rail.collapsed .rail-footer { width: 100%; } +/* Desktop's collapsed strip owns a real expand slot above the brand icon. + Keep the mobile dock and expanded rail unchanged. */ +@media (min-width: 600px) { + .app-rail.collapsed .rail-collapse { + position: static; + flex: 0 0 40px; + width: 40px; + height: 40px; + margin: 6px 0 0; + } +} .pipeline-head { display: flex; align-items: center; gap: 8px; min-width: 0; } .pipeline-glyph { flex: none; width: 18px; height: 18px; color: var(--muted); } diff --git a/web/test/miniatures-browser.mjs b/web/test/miniatures-browser.mjs index bbac203d..cd70d269 100644 --- a/web/test/miniatures-browser.mjs +++ b/web/test/miniatures-browser.mjs @@ -11,9 +11,11 @@ const out = resolve(process.argv[2] ?? "captures-miniatures"); await mkdir(out, { recursive: true }); const server = createServer(async (req, res) => { try { - const path = resolve(root, `.${req.url === "/" ? "/index.html" : req.url.split("?")[0]}`); + const path = resolve(root, `.${["/", "/fixture"].includes(req.url) ? "/index.html" : req.url.split("?")[0]}`); if (!path.startsWith(root + "/")) throw new Error("outside root"); - const data = await readFile(path); + let data = await readFile(path); + if (req.url === '/fixture') data = data.toString().replace('', + '
'); res.setHeader("Content-Type", ({ ".js": "text/javascript", ".css": "text/css", ".html": "text/html", ".svg": "image/svg+xml" })[extname(path)] ?? "application/octet-stream"); res.end(data); } catch { res.writeHead(404); res.end(); } @@ -24,6 +26,34 @@ const results = []; try { const page = await browser.openPage(`http://127.0.0.1:${server.address().port}/`); await page.waitForSelector("#content"); + // Real shell controls, before replacing content with the list fixtures. + await page.resize(1100, 1000); + await page.click('#railCollapse'); + const rail = await page.evaluate(`(() => { + const button=document.querySelector('#railCollapse'); + const brand=document.querySelector('.rail-brand-icon').getBoundingClientRect(); + const first=document.querySelector('.rail-item').getBoundingClientRect(); + const b=button.getBoundingClientRect(); + return {collapsed:document.querySelector('#appRail').classList.contains('collapsed'), + expanded:button.getAttribute('aria-expanded'),position:getComputedStyle(button).position, + bottom:b.bottom,brandTop:brand.top,firstTop:first.top,width:b.width,height:b.height}; + })()`); + assert.equal(rail.collapsed,true); + assert.equal(rail.expanded,'false'); + assert.equal(rail.position,'static'); + assert.ok(rail.bottom<=rail.brandTop && rail.bottom<=rail.firstTop); + assert.equal(rail.width,40); + assert.equal(rail.height,40); + await page.screenshot(resolve(out,'rail-collapsed-1100.png')); + await page.click('#railCollapse'); + assert.equal(await page.evaluate(`document.querySelector('#railCollapse').getAttribute('aria-expanded')`),'true'); + await page.screenshot(resolve(out,'rail-expanded-1100.png')); + results.push({view:'rail',...rail}); + for (const width of [390,420]) { + await page.resize(width,1000); + assert.equal(await page.evaluate(`getComputedStyle(document.querySelector('#appRail')).display`),'none'); + } + await page.goto(`http://127.0.0.1:${server.address().port}/fixture`); await page.evaluate(`(async () => { const { createRunsView } = await import('/src/views/runs.js'); const { createPipelinesView } = await import('/src/views/pipelines.js'); @@ -54,6 +84,7 @@ try { await page.waitForSelector(".run-mini"); for (const width of [390, 420, 1100]) { await page.resize(width, 1000); + await page.evaluate(`new Promise(resolve=>setTimeout(resolve,150))`); for (const view of ["runs", "pipelines"]) { await page.evaluate(`fixtureState.view=${JSON.stringify(view)};paintFixture()`); const geometry = await page.evaluate(`(() => { @@ -61,9 +92,13 @@ try { return { width:innerWidth, overflow:document.documentElement.scrollWidth>innerWidth, rows:rows.map(row=>{const mini=row.querySelector('.pipeline-mini');const r=row.getBoundingClientRect(); const m=mini.getBoundingClientRect();const svg=mini.querySelector('svg');const node=svg.querySelector('rect'); - return {inset:r.right-m.right,align:svg.getAttribute('preserveAspectRatio'), + const status=row.querySelector('.status-icon')?.dataset.status; + const swatch=document.createElement('span');swatch.style.color='var(--status-'+status+')';mini.append(swatch); + const expectedColor=getComputedStyle(swatch).color;swatch.remove(); + return {inset:r.right-m.right,align:svg.getAttribute('preserveAspectRatio'),status,expectedColor, color:getComputedStyle(mini).color,nodeColor:getComputedStyle(node).color, - right:m.right,rowRight:r.right, rowWidth:r.width};}), + right:m.right,rowRight:r.right, rowWidth:r.width,parentWidth:row.parentElement.clientWidth, + selected:row.classList.contains('selected')};}), reads:window.pinnedReads,filterSeparate:!document.querySelector('.run-toolbar .run-applied-filters'), titleWrap:[...document.querySelectorAll('.run-row-title')].every(el=>getComputedStyle(el).whiteSpace!=='nowrap')}; })()`); @@ -76,6 +111,9 @@ try { assert.equal(geometry.filterSeparate, true); assert.notEqual(geometry.rows[0].color, geometry.rows[1].color); assert.notEqual(geometry.rows[2].color, geometry.rows[4].color); + assert.ok(geometry.rows.every((row)=>row.color===row.expectedColor)); + const selected=geometry.rows.find(row=>row.selected); + assert.equal(selected.rowWidth,selected.parentWidth); } results.push({view,...geometry}); await page.screenshot(resolve(out, `${view}-${width}.png`));