android: preserve run detail pill correction
This commit is contained in:
@@ -1,36 +1,25 @@
|
||||
# The destinations pill stands down over a run's pending decision
|
||||
# The destinations pill stands down in a run detail
|
||||
|
||||
## What this item changed
|
||||
|
||||
`android/` only, the app shell's floating destination pill and the run view's decision surface.
|
||||
`android/` only, the app shell's floating destination pill and run-detail stack.
|
||||
|
||||
- `ui/PipelinesApp.kt` — the pill's one rule gains a second hiding state.
|
||||
`destinationPillVisible(currentRoute, conversationOpen, decisionOpen)` is now
|
||||
`!(currentRoute == CHAT_ROUTE && conversationOpen) && !decisionOpen`: the chat conversation
|
||||
hides it exactly as before (the chat clause is unchanged), and a run's open pending-decision
|
||||
surface hides it too. Everything downstream is unchanged and still keys off that one
|
||||
- `ui/PipelinesApp.kt` — the pill's one rule gains a run-detail hiding state.
|
||||
`destinationPillVisible(currentRoute, conversationOpen, runDetailOpen)` is now
|
||||
`!(currentRoute == CHAT_ROUTE && conversationOpen) && !runDetailOpen`: the chat conversation
|
||||
hides it exactly as before (the chat clause is unchanged), and the full run-detail stack hides
|
||||
it too. `runDetailOpen` derives from the Runs destination's saved selection depth, so it
|
||||
covers summary, graph, stage, artifact and decision surfaces and Back to the list restores it.
|
||||
Everything downstream is unchanged and still keys off that one
|
||||
predicate — `contentPillPadding(pillVisible)` (the named zero) and
|
||||
`pillScrollInset(pillVisible)` (the named `DESTINATION_PILL_RESERVE` +
|
||||
`ATTENTION_CHIP_RESERVE`, or `0.dp` while hidden) — so hiding the pill over a decision
|
||||
leaves no empty band, exactly as hiding it in a conversation already does. The shell holds
|
||||
the new input as `decisionSurfaceOpen` (`remember { mutableStateOf(false) }`: a transient
|
||||
state of the run view, not a destination and not saved — the sheet is not saveable either,
|
||||
so a configuration change closes both together) and passes its setter down the same path
|
||||
`decisionRequest` already travels.
|
||||
- `ui/components/DecisionPrompt.kt` — gains `onSurfaceOpenChange: (Boolean) -> Unit = {}`,
|
||||
reporting `open` on every change (`LaunchedEffect(open)`) and clearing it when the prompt
|
||||
leaves the composition (`DisposableEffect`) so a surface closed with its pane can never
|
||||
leave the pill hidden behind it. The component still owns no networking and no pill
|
||||
knowledge: it only says when its own surface is up.
|
||||
- `ui/screens/RunDetailScreen.kt`, `ui/RunsDestination.kt`, `ui/graph/StageDetailPane.kt` —
|
||||
the run detail, the runs destination and the run's stage pane (its section level included)
|
||||
pass that callback through, so the decision sheet hides the pill wherever it is opened
|
||||
from. The pipeline-side stage pane gets the default no-op.
|
||||
`ATTENTION_CHIP_RESERVE`, or `0.dp` while hidden) — so hiding the pill in a run detail
|
||||
leaves no empty band, exactly as hiding it in a conversation already does.
|
||||
- Tests — `PipelinesNavTest`: the existing `destinationPillVisible` test is extended in place
|
||||
(renamed `thePillStandsDownWhileAConversationOrARunDecisionSurfaceIsOpen`) to pin that the
|
||||
decision surface hides the pill on the runs route, that a run being read keeps it, and that
|
||||
the chat clause is untouched; and the scroll-inset test's loop gains the decision
|
||||
dimension, so `pillScrollInset` is proved zero while the decision surface hides the pill
|
||||
(renamed `thePillStandsDownWhileAConversationOrRunDetailIsOpen`) to pin that the full
|
||||
run-detail stack hides the pill on the runs route, that the run list restores it, and that
|
||||
the chat clause is untouched; and the scroll-inset test's loop gains the detail
|
||||
dimension, so `pillScrollInset` is proved zero while a run detail hides the pill
|
||||
(no empty band) and the drawn reserve while it is drawn.
|
||||
|
||||
No new dimension, so no `ui/theme/Dimens.kt` token was needed (a raw literal would fail
|
||||
@@ -43,32 +32,29 @@ started from the app.
|
||||
place; the `docs-fold` writer should update it.
|
||||
|
||||
- `android/README.md:6219` — the section headline
|
||||
"## Destination pill stands down in an open conversation (17 Oct 2026)" and its opening
|
||||
paragraph ("It now stands down while the Chat destination is showing an open conversation
|
||||
and stays everywhere else, unchanged") now describe only half the rule. The section should
|
||||
also record the new item, e.g. append a dated section:
|
||||
"## Destination pill stands down in an open conversation (17 Oct 2026)" and its opening
|
||||
paragraph ("It now stands down while the Chat destination is showing an open conversation
|
||||
and stays everywhere else, unchanged") now describe only half the rule. The section should
|
||||
also record the new item, e.g. append a dated section:
|
||||
|
||||
```markdown
|
||||
## The destinations pill stands down over a run's pending decision (18 Oct 2026)
|
||||
## The destinations pill stands down in a run detail (18 Oct 2026)
|
||||
|
||||
The floating destinations pill also stood over a run's pending-decision surface — the
|
||||
decision sheet ("Choose things that need to happen") the operator opens from the run
|
||||
summary's Decide action — where it covered the options. It now stands down there too,
|
||||
exactly as it already does inside an open chat conversation, and returns the moment the
|
||||
decision is answered or dismissed. `android/` only; no new dependency, no run started from
|
||||
the app, no server/installer/Docker file touched.
|
||||
The floating destinations pill also stood over run-detail surfaces. It now stands down for
|
||||
the entire detail stack — summary, graph, stage, artifact and pending-decision surfaces —
|
||||
exactly as it already does inside an open chat conversation, and returns on Back to the runs
|
||||
list. `android/` only; no new dependency, no run started from the app, no
|
||||
server/installer/Docker file touched.
|
||||
|
||||
- **The one rule gains a second hiding state.** `destinationPillVisible(currentRoute,
|
||||
conversationOpen, decisionOpen)` is `!(currentRoute == CHAT_ROUTE && conversationOpen) &&
|
||||
!decisionOpen`. The chat clause is unchanged; the new `decisionOpen` is reported up by the
|
||||
run view (`DecisionPrompt.onSurfaceOpenChange`), so the surface is a state of the run view,
|
||||
not a destination: answering or dismissing it returns the pill with no navigation.
|
||||
conversationOpen, runDetailOpen)` is `!(currentRoute == CHAT_ROUTE && conversationOpen) &&
|
||||
!runDetailOpen`. The chat clause is unchanged; `runDetailOpen` derives from the Runs
|
||||
destination's saved selection depth, so every run-detail surface follows the same rule.
|
||||
- **Still one predicate, still no band.** `contentPillPadding` and `pillScrollInset` are
|
||||
unchanged and still derive from `pillVisible` alone, so a hidden pill over the decision
|
||||
leaves no empty band; the scroll-inset test now loops the decision dimension and pins that.
|
||||
- **Scoped to the decision surface.** A run being read, its stage pane, an artifact and the
|
||||
graph all keep the pill; only the open decision sheet hides it. The chat behaviour and the
|
||||
narrow/wide placement rules are untouched.
|
||||
unchanged and still derive from `pillVisible` alone, so a hidden pill in a run detail
|
||||
leaves no empty band; the scroll-inset test now loops the detail dimension and pins that.
|
||||
- **Scoped to the run detail.** The run list keeps the pill; every run-detail surface hides it.
|
||||
The chat behaviour and the narrow/wide placement rules are untouched.
|
||||
```
|
||||
|
||||
## Not stale
|
||||
|
||||
@@ -0,0 +1,31 @@
|
||||
# Run summary Changes viewer
|
||||
|
||||
Item: Android-only recovery of the run summary's observed file-change evidence.
|
||||
|
||||
## What changed
|
||||
|
||||
- `RunSummaryTab.kt` adds a separately collapsible **Changes** section after
|
||||
artifacts. Its header reports the observed file count and `+N -M` statistic.
|
||||
- `ui/changes/` aggregates per-stage file captures by path, preserves capture
|
||||
caveats (unavailable, partial, binary, truncated and mode-only), parses unified
|
||||
patches, and opens a full-screen raw/rendered viewer with file paging, line
|
||||
gutters, scrolling and copy support.
|
||||
- `ChatDiffCard.kt` provides shared diff marker and colour helpers so chat and
|
||||
run evidence render additions, removals and context consistently.
|
||||
|
||||
The screen reports observed workspace changes only; it does not claim model
|
||||
authorship. Large content is scrollable rather than eagerly expanded into the
|
||||
summary layout.
|
||||
|
||||
## Documentation now stale (for `docs-fold`)
|
||||
|
||||
- `android/README.md`'s run-summary/artifact documentation does not describe the
|
||||
Changes disclosure, its raw/rendered viewer, or its capture caveats. Add a
|
||||
dated Android section describing the observed-file count, `+N -M` totals,
|
||||
collapse state, and that unavailable/partial/binary/truncated captures are
|
||||
stated honestly rather than fabricating a diff.
|
||||
|
||||
## Not stale
|
||||
|
||||
- No packaged OpenCode skill reference, README outside `android/README.md`, or
|
||||
`internal/author/install.go` inventory documents this Android-only screen.
|
||||
Reference in New Issue
Block a user