web: right-align list miniatures and color pinned run graphs
This commit is contained in:
@@ -0,0 +1,45 @@
|
||||
import { test } from "node:test";
|
||||
import assert from "node:assert/strict";
|
||||
import { miniatureModel, miniatureColor, createMiniGraphCache } from "../src/miniGraph.js";
|
||||
|
||||
const graph = { stages: [
|
||||
{ key: "a", edges: { success: "b", error: "c" } },
|
||||
{ key: "b", edges: { success: "#success" } },
|
||||
{ key: "c", edges: { error: "#failure" } },
|
||||
] };
|
||||
test("miniatures retain real stage routes, without terminals or fabricated visits", () => {
|
||||
const model = miniatureModel(graph, { status: "failed" });
|
||||
assert.deepEqual(model.nodes.map((n) => n.key).sort(), ["a", "b", "c"]);
|
||||
assert.equal(model.edges.length, 2);
|
||||
assert.equal(model.evidence, false);
|
||||
assert.ok(model.nodes.every((n) => n.color === null && !n.untaken));
|
||||
});
|
||||
test("visited stages/routes use evidence; unvisited branches remain hollow", () => {
|
||||
const model = miniatureModel(graph, { status: "waiting", executing: true, current_stage: "b",
|
||||
steps: [{ stage: "a", status: "completed", outcome: "success", target: "b" }] });
|
||||
assert.equal(model.nodes.find((n) => n.key === "a").color, "var(--ok)");
|
||||
assert.equal(model.nodes.find((n) => n.key === "b").color, "var(--status-waiting)");
|
||||
assert.equal(model.nodes.find((n) => n.key === "c").untaken, true);
|
||||
assert.equal(model.edges.find((e) => e.outcome === "success").color, "var(--ok)");
|
||||
assert.equal(model.edges.find((e) => e.outcome === "error").untaken, true);
|
||||
for (const status of ["succeeded", "failed", "running", "waiting", "interrupted", "queued", "canceled"]) {
|
||||
assert.equal(miniatureColor(status), `var(--status-${status})`);
|
||||
}
|
||||
});
|
||||
test("cache deduplicates pinned reads, rejects latest mismatches and scopes by endpoint", async () => {
|
||||
const calls = [];
|
||||
const cached = createMiniGraphCache(async (id, version) => {
|
||||
calls.push([id, version]); return { version, graph };
|
||||
}, () => {});
|
||||
const run = { pipeline_id: 8, version: 2 };
|
||||
assert.equal(cached(run, [{ id: 8, version: 3, shape: graph }], "one"), null);
|
||||
cached(run, [], "one");
|
||||
await new Promise(setImmediate);
|
||||
assert.deepEqual(calls, [[8, 2]]);
|
||||
assert.equal(cached(run, [], "one"), graph);
|
||||
assert.equal(cached(run, [], "two"), null);
|
||||
assert.equal(cached({ pipeline_id: 8 }, []), null);
|
||||
const mismatch = createMiniGraphCache(async () => ({ version: 3, graph }), () => {});
|
||||
mismatch(run); await new Promise(setImmediate);
|
||||
assert.equal(mismatch(run), null);
|
||||
});
|
||||
@@ -0,0 +1,91 @@
|
||||
// Scratch-only extension of ui-smoke: real DOM/views, deterministic protocol-shaped
|
||||
// evidence; no backend connection, production reads, workflow creation or devices.
|
||||
import { createServer } from "node:http";
|
||||
import { readFile, mkdir, writeFile } from "node:fs/promises";
|
||||
import { resolve, extname } from "node:path";
|
||||
import assert from "node:assert/strict";
|
||||
import { launchChrome } from "./browser.mjs";
|
||||
|
||||
const root = resolve(import.meta.dirname, "..");
|
||||
const out = resolve(process.argv[2] ?? "captures-miniatures");
|
||||
await mkdir(out, { recursive: true });
|
||||
const server = createServer(async (req, res) => {
|
||||
try {
|
||||
const path = resolve(root, `.${req.url === "/" ? "/index.html" : req.url.split("?")[0]}`);
|
||||
if (!path.startsWith(root + "/")) throw new Error("outside root");
|
||||
const data = await readFile(path);
|
||||
res.setHeader("Content-Type", ({ ".js": "text/javascript", ".css": "text/css", ".html": "text/html", ".svg": "image/svg+xml" })[extname(path)] ?? "application/octet-stream");
|
||||
res.end(data);
|
||||
} catch { res.writeHead(404); res.end(); }
|
||||
});
|
||||
await new Promise((r) => server.listen(0, "127.0.0.1", r));
|
||||
const browser = await launchChrome();
|
||||
const results = [];
|
||||
try {
|
||||
const page = await browser.openPage(`http://127.0.0.1:${server.address().port}/`);
|
||||
await page.waitForSelector("#content");
|
||||
await page.evaluate(`(async () => {
|
||||
const { createRunsView } = await import('/src/views/runs.js');
|
||||
const { createPipelinesView } = await import('/src/views/pipelines.js');
|
||||
const { defaultRunFilters } = await import('/src/runs.js');
|
||||
const { EMPTY_PIPELINE_FILTERS } = await import('/src/pipelines.js');
|
||||
const graph = { stages: [{ key:'plan', edges:{success:'build',error:'reject'} },
|
||||
{key:'build',edges:{success:'finish'}},{key:'reject',edges:{error:'#failure'}},
|
||||
{key:'finish',edges:{success:'#success'}}] };
|
||||
const statuses = ['succeeded','failed','running','interrupted','waiting','queued'];
|
||||
const state = { view:'runs', url:'scratch', loading:false, selectedRunId:1,
|
||||
openMenu:null, runFilters:{...defaultRunFilters(),pipelineId:7}, runSort:'server_order',
|
||||
pipelineFilters:{...EMPTY_PIPELINE_FILTERS},pipelineSort:'server_order', pipelinesLoaded:true,
|
||||
runsLoaded:true, pipelines:[{id:7,name:'Pinned workflow',version:3,stages:4,shape:graph}],
|
||||
runs:statuses.map((status,i)=>({id:i+1,pipeline_id:7,version:2,name:'Pinned workflow',
|
||||
title:'A wrapped run title that preserves the complete task context across narrow screens '+status,
|
||||
status,executing:['running','waiting'].includes(status),current_stage:'build',
|
||||
created_at:new Date().toISOString(),steps:i===0?[
|
||||
{stage:'plan',status:'completed',outcome:'success',target:'build'},
|
||||
{stage:'build',status:'completed',outcome:'success',target:'finish'}]:undefined})) };
|
||||
let runs, pipelines;
|
||||
const renderContent=()=>document.querySelector('#content').replaceChildren(
|
||||
state.view==='runs'?runs.renderRunList():pipelines.renderPipelineList());
|
||||
const rt={state,repo:{getPipeline:async(id,version)=>{window.pinnedReads=(window.pinnedReads||0)+1;return {id,version,graph};}},
|
||||
renderContent,renderAttentionBell:()=>document.createElement('span'),selectRun:()=>{},pushRoute:()=>{}};
|
||||
runs=createRunsView(rt);pipelines=createPipelinesView(rt);
|
||||
window.fixtureState=state;window.paintFixture=renderContent;renderContent();
|
||||
})()`);
|
||||
await page.waitForSelector(".run-mini");
|
||||
for (const width of [390, 420, 1100]) {
|
||||
await page.resize(width, 1000);
|
||||
for (const view of ["runs", "pipelines"]) {
|
||||
await page.evaluate(`fixtureState.view=${JSON.stringify(view)};paintFixture()`);
|
||||
const geometry = await page.evaluate(`(() => {
|
||||
const rows=[...document.querySelectorAll('#content .row')];
|
||||
return { width:innerWidth, overflow:document.documentElement.scrollWidth>innerWidth,
|
||||
rows:rows.map(row=>{const mini=row.querySelector('.pipeline-mini');const r=row.getBoundingClientRect();
|
||||
const m=mini.getBoundingClientRect();const svg=mini.querySelector('svg');const node=svg.querySelector('rect');
|
||||
return {inset:r.right-m.right,align:svg.getAttribute('preserveAspectRatio'),
|
||||
color:getComputedStyle(mini).color,nodeColor:getComputedStyle(node).color,
|
||||
right:m.right,rowRight:r.right, rowWidth:r.width};}),
|
||||
reads:window.pinnedReads,filterSeparate:!document.querySelector('.run-toolbar .run-applied-filters'),
|
||||
titleWrap:[...document.querySelectorAll('.run-row-title')].every(el=>getComputedStyle(el).whiteSpace!=='nowrap')};
|
||||
})()`);
|
||||
assert.equal(geometry.overflow, false);
|
||||
assert.ok(geometry.rows.length > 0);
|
||||
assert.ok(geometry.rows.every((r)=>r.inset>=6 && r.inset<40 && r.align==='xMaxYMid meet'));
|
||||
assert.equal(geometry.reads, 1);
|
||||
if (view === 'runs') {
|
||||
assert.equal(geometry.titleWrap, true);
|
||||
assert.equal(geometry.filterSeparate, true);
|
||||
assert.notEqual(geometry.rows[0].color, geometry.rows[1].color);
|
||||
assert.notEqual(geometry.rows[2].color, geometry.rows[4].color);
|
||||
}
|
||||
results.push({view,...geometry});
|
||||
await page.screenshot(resolve(out, `${view}-${width}.png`));
|
||||
if (view === 'runs') {
|
||||
await page.evaluate(`document.querySelector('.run-row[data-run-id="1"]').scrollIntoView({block:'end'})`);
|
||||
await page.screenshot(resolve(out, `runs-evidence-${width}.png`));
|
||||
}
|
||||
}
|
||||
}
|
||||
await writeFile(resolve(out, 'geometry.json'), JSON.stringify(results,null,2));
|
||||
await page.close();
|
||||
} finally { await browser.close(); await new Promise((r)=>server.close(r)); }
|
||||
console.log(`Scratch captures and geometry: ${out}`);
|
||||
Reference in New Issue
Block a user