fix(notify): open configured web run pages from ntfy

This commit is contained in:
2026-10-21 13:05:10 +01:00
parent 870c70aefa
commit 9ee2e003bf
12 changed files with 201 additions and 14 deletions
+26
View File
@@ -298,6 +298,31 @@ class SetupNativeTests(unittest.TestCase):
installer.run(setup_native.arguments(arguments))
self.assertFalse(manage.load(prefix)["allow_authoring"])
def test_notification_web_url_is_preserved_and_can_be_overridden(self):
for override in (None, "https://new-pipelines.example.com"):
with self.subTest(override=override), tempfile.TemporaryDirectory() as directory:
installer = self.installer(directory, Recorder())
prefix = Path(directory) / "prefix"
prefix.mkdir()
(prefix / setup_native.MARKER).write_text(json.dumps({"opencode_env": {
"PIPELINES_WEB_PUBLIC_URL": "https://pipelines.example.com"}}))
if override:
installer.environ["PIPELINES_WEB_PUBLIC_URL"] = override
with patch.object(setup_native.shutil, "which", side_effect=self.which_all()), \
patch.object(setup_native.lan, "detect_lan", return_value="192.168.1.20"), \
patch.object(setup_native.configure, "host_timezone", return_value="UTC"), \
redirect_stdout(io.StringIO()):
installer.run(setup_native.arguments([]))
self.assertEqual(manage.load(prefix)["opencode_env"]["PIPELINES_WEB_PUBLIC_URL"],
override or "https://pipelines.example.com")
def test_invalid_notification_web_url_refused_before_install(self):
with tempfile.TemporaryDirectory() as directory:
installer = self.installer(directory, Recorder())
installer.environ["PIPELINES_WEB_PUBLIC_URL"] = "https://user:secret@example.com"
with self.assertRaisesRegex(ValueError, "PIPELINES_WEB_PUBLIC_URL"):
installer.run(setup_native.arguments([]))
def test_missing_opencode_fails_actionably(self):
with tempfile.TemporaryDirectory() as directory:
installer = self.installer(directory, Recorder())
@@ -325,6 +350,7 @@ class SetupNativeTests(unittest.TestCase):
self.assertEqual(config["opencode"], "/usr/bin/opencode")
self.assertEqual(config["pi"], "")
self.assertEqual(config["opencode_env"]["PIPELINES_DEFAULT_MODEL"], "fixture/host-default")
self.assertEqual(config["opencode_env"]["PIPELINES_WEB_PUBLIC_URL"], "http://192.168.1.20:8082")
host = json.loads(installer.harness_config_path().read_text())["profiles"]["opencode"]
self.assertEqual(host["model"], "fixture/host-default")
self.assertEqual(host["pipeline_model"], "fixture/host-default")