fix(notify): open configured web run pages from ntfy

This commit is contained in:
2026-10-21 13:05:10 +01:00
parent 870c70aefa
commit 9ee2e003bf
12 changed files with 201 additions and 14 deletions
+1 -1
View File
@@ -78,7 +78,7 @@ func (d serviceDefinition) render(platform string) (string, error) {
// Only explicitly supported settings are captured, never the complete environment
// or provider credentials. File-based notification credentials remain references.
var serviceEnvironmentKeys = []string{"PATH", "HOME", "XDG_CONFIG_HOME", "XDG_DATA_HOME", "XDG_STATE_HOME", "XDG_CACHE_HOME", "PIPELINES_OPENCODE", "PIPELINES_OPENCODE_ENDPOINT", "PIPELINES_OPENCODE_ENDPOINT_PASSWORD_FILE", "PIPELINES_OPENCODE_ENDPOINT_USERNAME", "PIPELINES_NTFY_URL", "PIPELINES_NTFY_PUBLIC_URL", "PIPELINES_NTFY_TOKEN_FILE"}
var serviceEnvironmentKeys = []string{"PATH", "HOME", "XDG_CONFIG_HOME", "XDG_DATA_HOME", "XDG_STATE_HOME", "XDG_CACHE_HOME", "PIPELINES_OPENCODE", "PIPELINES_OPENCODE_ENDPOINT", "PIPELINES_OPENCODE_ENDPOINT_PASSWORD_FILE", "PIPELINES_OPENCODE_ENDPOINT_USERNAME", "PIPELINES_NTFY_URL", "PIPELINES_NTFY_PUBLIC_URL", "PIPELINES_NTFY_TOKEN_FILE", "PIPELINES_WEB_PUBLIC_URL"}
func envValues(env map[string]string) []string {
var values []string
+15
View File
@@ -111,6 +111,21 @@ func TestServiceWritesRefuseUnmanagedFilesAndSymlinks(t *testing.T) {
}
}
func TestServicePreservesNotificationWebOrigin(t *testing.T) {
d := serviceDefinition{Binary: "/bin/server", Directory: "/repo", Environment: map[string]string{
"PIPELINES_WEB_PUBLIC_URL": "https://pipelines.example.com",
}}
for _, platform := range []string{"linux", "darwin"} {
text, err := d.render(platform)
if err != nil {
t.Fatal(err)
}
if !strings.Contains(text, "PIPELINES_WEB_PUBLIC_URL") || !strings.Contains(text, "https://pipelines.example.com") {
t.Fatalf("%s lost notification web origin", platform)
}
}
}
func TestServiceConfigurationPreviewAndLifecycleWithMockOSManager(t *testing.T) {
t.Setenv("PIPELINES_PREFIX", "")
if runtime.GOOS != "darwin" && runtime.GOOS != "linux" {