fix(notify): open configured web run pages from ntfy
This commit is contained in:
@@ -0,0 +1,24 @@
|
||||
# Notification web run links
|
||||
|
||||
Run-attention/completion notifications and stage hooks now use
|
||||
`PIPELINES_WEB_PUBLIC_URL` to build `<origin>/runs/<id>` links to the authenticated
|
||||
web app. This is an operator-controlled origin, not an inferred API/ntfy host.
|
||||
Credentials, queries, fragments and subpaths are rejected; invalid configuration
|
||||
omits the link with a diagnostic. Existing Android-only deployments without this
|
||||
setting retain their original scheme. Already-sent notifications are unchanged.
|
||||
|
||||
Native setup saves its advertised web address by default and retains explicit
|
||||
origin overrides across reinstalls. Custom service generation preserves the
|
||||
variable; Docker Compose forwards it. Authenticated proxy login already preserves
|
||||
the target run and is covered by a new isolated HTTP regression.
|
||||
|
||||
Verified: full Go race suite, build/vet, installer unit tests, stage-hook web links
|
||||
(including attachments), waiting/failed run web payloads, URL validation and
|
||||
service-environment retention on both renderers. The isolated real proxy test
|
||||
checks unauthenticated gating, wrong-password rejection and return to the exact
|
||||
run after login. No production notification was sent to test this fix.
|
||||
|
||||
Code is not deployed/configured on the live server: the operator's phone-facing
|
||||
web URL is still needed, and a backend update must wait for safe deployment.
|
||||
Dummy run #22 completed with its old `pipelines://run/22` notification acknowledged
|
||||
by ntfy; that verifies publishing, not reception or correct web navigation.
|
||||
Reference in New Issue
Block a user