search: browse bounded recent items with kind-only queries
This commit is contained in:
@@ -1,6 +1,6 @@
|
||||
import { test } from "node:test";
|
||||
import assert from "node:assert/strict";
|
||||
import { parseSearchQuery, SEARCH_KINDS } from "../src/search.js";
|
||||
import { parseSearchQuery, searchQuerySendable, searchPanelBody, SEARCH_KINDS } from "../src/search.js";
|
||||
|
||||
test("both type aliases and kinds are case insensitive", () => {
|
||||
for (const { value } of SEARCH_KINDS.filter((kind) => kind.value)) {
|
||||
@@ -36,3 +36,22 @@ test("type-only query is distinguishable from literal text and blank input", ()
|
||||
assert.deepEqual(parseSearchQuery("t:pipeline"), { query: "", kind: "pipeline", hasType: true });
|
||||
assert.deepEqual(parseSearchQuery(""), { query: "", kind: "", hasType: false });
|
||||
});
|
||||
|
||||
test("blank text is sendable only with a supported nonempty kind", () => {
|
||||
for (const { value } of SEARCH_KINDS) {
|
||||
assert.equal(searchQuerySendable(" \n\t ", value), value !== "");
|
||||
}
|
||||
assert.equal(searchQuerySendable("", "unknown"), false);
|
||||
assert.equal(searchQuerySendable("plan"), true);
|
||||
});
|
||||
|
||||
test("kind-only responses distinguish loading, honest empty state and cleared filters", () => {
|
||||
assert.equal(searchPanelBody({ loading: true, query: "" }, [], "pipeline").kind, "searching");
|
||||
assert.deepEqual(searchPanelBody({ loaded: true, query: "" }, [], "pipeline"), {
|
||||
kind: "empty", message: "No pipelines yet.",
|
||||
});
|
||||
assert.equal(searchPanelBody({ loaded: false, query: "" }, [], "pipeline").kind, "idle");
|
||||
assert.equal(searchPanelBody({ loaded: true, query: "" }, [], "").kind, "idle");
|
||||
assert.equal(searchPanelBody({ loaded: true, query: "", truncated: true }, [], "field").message,
|
||||
"No fields found within the server's scan limit.");
|
||||
});
|
||||
|
||||
@@ -8,7 +8,7 @@ import { fileURLToPath } from "node:url";
|
||||
import { launchChrome, eventually } from "./browser.mjs";
|
||||
|
||||
const root = fileURLToPath(new URL("../", import.meta.url));
|
||||
const out = resolve(process.argv[2] || "captures/search-types");
|
||||
const out = resolve(process.argv[2] || "captures/search-types-recent");
|
||||
await mkdir(out, { recursive: true });
|
||||
const server = createServer(async (req, res) => {
|
||||
try {
|
||||
@@ -39,7 +39,14 @@ try {
|
||||
window.framesSent = [];
|
||||
const repo = new PipelinesRepository({ call: async (frame) => {
|
||||
framesSent.push(frame);
|
||||
return { search_results: { results: [] } };
|
||||
const fixtures = {
|
||||
pipeline: [{ kind: 'pipeline', target: 'pipeline:12', pipeline: { id: 12, name: 'Recent fixture pipeline', version: 1, stages: 2 } }],
|
||||
artifact: [{ kind: 'artifact', target: '/artifacts/12/1/report.txt', artifact: { run_id: 12, sequence: 1, name: 'Recent fixture report.txt', url: '/artifacts/12/1/report.txt', content_type: 'text/plain', size_bytes: 20 } }],
|
||||
};
|
||||
return { search_results: {
|
||||
results: frame.search.query === '' ? fixtures[frame.search.kind] || [] : [],
|
||||
truncated: frame.search.query === '' && ['field', 'pipeline'].includes(frame.search.kind),
|
||||
} };
|
||||
}});
|
||||
const state = { searchQuery: '', searchKind: '', searchSort: 'relevance',
|
||||
searchResults: [], searchSequencer: new SearchSequencer(), searchActiveIndex: 0 };
|
||||
@@ -69,17 +76,30 @@ try {
|
||||
assert.equal((await last()).search.query, '"t:run" t:unknown');
|
||||
await page.screenshot(`${out}/04-literal-tokens.png`);
|
||||
|
||||
const before = await page.evaluate("framesSent.length");
|
||||
await page.fill("#searchInput", "t:pipeline");
|
||||
await eventually(() => page.evaluate("document.querySelector('#searchResults').textContent.includes('Add search text')"));
|
||||
await new Promise((done) => setTimeout(done, 400));
|
||||
assert.equal(await page.evaluate("framesSent.length"), before);
|
||||
await page.screenshot(`${out}/05-type-only-help.png`);
|
||||
await search("t:pipeline");
|
||||
assert.deepEqual((await last()), { type: "search", search: { query: "", kind: "pipeline", limit: 0 } });
|
||||
await eventually(() => page.evaluate("document.querySelector('#searchResults').textContent.includes('Recent fixture pipeline')"));
|
||||
await page.screenshot(`${out}/05-type-only-pipelines.png`);
|
||||
await search("type:ARTIFACT");
|
||||
assert.deepEqual((await last()).search, { query: "", kind: "artifact", limit: 0 });
|
||||
await eventually(() => page.evaluate("document.querySelector('#searchResults').textContent.includes('Recent fixture report.txt')"));
|
||||
await page.screenshot(`${out}/06-type-only-artifacts.png`);
|
||||
|
||||
await page.evaluate("document.querySelector('#searchKind').value = 'step'; document.querySelector('#searchKind').dispatchEvent(new Event('change'))");
|
||||
await eventually(() => page.evaluate("document.querySelector('#searchResults').textContent === 'No steps yet.'"));
|
||||
assert.deepEqual((await last()).search, { query: "", kind: "step", limit: 0 });
|
||||
await page.screenshot(`${out}/07-empty-kind.png`);
|
||||
await page.evaluate("document.querySelector('#searchKind').value = 'field'; document.querySelector('#searchKind').dispatchEvent(new Event('change'))");
|
||||
await eventually(() => page.evaluate("document.querySelector('#searchResults').textContent.includes(\"No fields found within the server's scan limit.\")"));
|
||||
await page.screenshot(`${out}/08-scan-bound-empty.png`);
|
||||
const beforeClear = await page.evaluate("framesSent.length");
|
||||
await page.click("#searchClearFilter");
|
||||
assert.equal(await page.evaluate("document.querySelector('#searchInput').value"), "");
|
||||
assert.equal(await page.evaluate("document.querySelector('#searchKind').value"), "");
|
||||
await page.screenshot(`${out}/06-cleared-filter.png`);
|
||||
console.log(`PASS: type tokens, wire kind/query, precedence, selector replacement, literals, type-only help and clear. Captures: ${out}`);
|
||||
assert.equal(await page.evaluate("document.querySelector('#searchResults').textContent"), "");
|
||||
assert.equal(await page.evaluate("framesSent.length"), beforeClear);
|
||||
await page.screenshot(`${out}/09-cleared-filter.png`);
|
||||
console.log(`PASS: type tokens, wire kind/query, precedence, selector replacement, literals, kind-only results/empty state and clear. Captures: ${out}`);
|
||||
} finally {
|
||||
await browser?.close();
|
||||
await new Promise((done) => server.close(done));
|
||||
|
||||
Reference in New Issue
Block a user