Remove Cupertino update dialog branches
Keep the Material update dialogs as the only reachable implementation while preserving public cupertino parameters for callers. Update focused tests and document the verified checks.
This commit is contained in:
@@ -0,0 +1,42 @@
|
||||
# Cupertino removal — lib/features/updates
|
||||
|
||||
## Change
|
||||
- `lib/features/updates/launch_update_dialog.dart`: deleted the Cupertino dialog
|
||||
branches from `showLaunchUpdateDialog`, `showLaunchUpdateFailure` and
|
||||
`installLaunchUpdate`, and from the private `_InstallProgress` widget
|
||||
(`CupertinoAlertDialog`, `CupertinoActivityIndicator`, `CupertinoDialogAction`,
|
||||
`showCupertinoDialog`). The Material `AlertDialog`/`LinearProgressIndicator`
|
||||
path is unchanged.
|
||||
- Public signatures keep `required bool cupertino` (unused now) so callers in
|
||||
other directories continue to compile; nothing outside `lib/features/updates`
|
||||
was edited.
|
||||
- Removed the `package:flutter/cupertino.dart` import; no `CupertinoIcons` or
|
||||
`CupertinoColors` were used in this directory.
|
||||
|
||||
## Tests
|
||||
- `test/features/updates/native_update_dialog_test.dart`: existing Material
|
||||
prompt loop retained (`cupertino: false`). Added regression tests for the
|
||||
Material failure alert and the Material install-progress dialog/progress bar.
|
||||
No Cupertino test variants were present to delete.
|
||||
- `test/application/startup_update_flow_test.dart` (review follow-up): the web
|
||||
refresh test no longer mounts with `cupertino: true`; it now asserts the
|
||||
Material `AlertDialog`. The local `mount` helper lost its unused `cupertino`
|
||||
parameter and passes `cupertino: false` explicitly. The
|
||||
`package:flutter/cupertino.dart` import became `package:flutter/material.dart`.
|
||||
- `test/application/startup_update_check_test.dart` already mounted Material
|
||||
only (`cupertino: false`); no change.
|
||||
- No other test reaches these dialogs with `cupertino: true` or a `CupertinoApp`
|
||||
host; the remaining `cupertino: true` tests elsewhere cover unrelated UI.
|
||||
|
||||
## Checks
|
||||
- `tool/analyze.sh`: clean (16s, exit 0).
|
||||
- `tool/memwatch/full.sh 'test/features/updates test/application/startup_update_flow_test.dart test/application/startup_update_check_test.dart'`:
|
||||
38 passed, 0 failed, 0 skipped; 38s; exit 0.
|
||||
- `grep -rn 'Cupertino\|cupertino' lib/features/updates`: only the three kept
|
||||
`required bool cupertino` parameters. In the update tests only `cupertino:
|
||||
false` arguments remain.
|
||||
|
||||
## UI states
|
||||
- Update-available prompt, update-failure alert and install-progress dialog now
|
||||
always render the existing Material variants. No pixel change on the Material
|
||||
path; Cupertino host paths are unreachable in this Material-only app.
|
||||
Reference in New Issue
Block a user