From 944a26ce1a6581dec168f85fc4b1b759d69fb5c2 Mon Sep 17 00:00:00 2001 From: Alan Silva Date: Sun, 1 Nov 2026 01:41:54 +0000 Subject: [PATCH] Open run artifact groups by default Turn documents are hidden behind the Debug toggle now, so the run's own artifact groups (the run Artifacts tab and a stage's Artifacts section) start open instead of collapsed. --- app/lib/features/runs/ui/run_detail_tabs.dart | 1 - .../features/runs/ui/run_detail_visit_artifacts.dart | 1 - .../features/runs/ui/run_artifacts_action_test.dart | 7 +------ .../runs/ui/run_detail_visit_sections_test.dart | 11 +---------- 4 files changed, 2 insertions(+), 18 deletions(-) diff --git a/app/lib/features/runs/ui/run_detail_tabs.dart b/app/lib/features/runs/ui/run_detail_tabs.dart index 50dd8306..82f194b3 100644 --- a/app/lib/features/runs/ui/run_detail_tabs.dart +++ b/app/lib/features/runs/ui/run_detail_tabs.dart @@ -466,7 +466,6 @@ class _RunDetailTabsState extends State { steps: runDetailArtifactSteps(widget.run), executing: runDetailExecuting(widget.run), configuredEndpoint: widget.configuredEndpoint, - initiallyCollapsed: true, embedded: true, ); case RunDetailTab.changes: diff --git a/app/lib/features/runs/ui/run_detail_visit_artifacts.dart b/app/lib/features/runs/ui/run_detail_visit_artifacts.dart index bc9c2d74..23ee33b7 100644 --- a/app/lib/features/runs/ui/run_detail_visit_artifacts.dart +++ b/app/lib/features/runs/ui/run_detail_visit_artifacts.dart @@ -39,7 +39,6 @@ class RunVisitArtifacts extends StatelessWidget { steps: runSteps.isEmpty ? [step] : runSteps, focusIndex: runSteps.isEmpty ? 0 : visitIndex, configuredEndpoint: configuredEndpoint, - initiallyCollapsed: true, embedded: true, ), ); diff --git a/app/test/features/runs/ui/run_artifacts_action_test.dart b/app/test/features/runs/ui/run_artifacts_action_test.dart index 37688173..54c3973b 100644 --- a/app/test/features/runs/ui/run_artifacts_action_test.dart +++ b/app/test/features/runs/ui/run_artifacts_action_test.dart @@ -5,7 +5,6 @@ import 'package:pipelines_app/core/api_gateway.dart'; import 'package:pipelines_app/features/runs/data/runs_repository.dart'; import 'package:pipelines_app/features/runs/ui/run_detail_view.dart'; import 'package:pipelines_app/features/runs/ui/runs_controller.dart'; -import 'package:pipelines_app/ui/layout/sticky_section.dart'; import '../../artifacts/domain/artifact_fixtures.dart'; @@ -114,11 +113,7 @@ void main() { await tester.pumpAndSettle(); await tester.tap(find.byKey(const ValueKey('run-detail-tab-artifacts'))); await tester.pumpAndSettle(); - final sections = find.byType(StickySectionTitle); - for (var index = 0; index < sections.evaluate().length; index += 1) { - await tester.tap(sections.at(index)); - } - await tester.pumpAndSettle(); + // Artifact groups start open: the files show without a tap. expect(find.text('Artifacts ยท 2 recorded'), findsOneWidget); expect(find.text('build.log'), findsOneWidget); diff --git a/app/test/features/runs/ui/run_detail_visit_sections_test.dart b/app/test/features/runs/ui/run_detail_visit_sections_test.dart index 93d6a00f..c45ecedc 100644 --- a/app/test/features/runs/ui/run_detail_visit_sections_test.dart +++ b/app/test/features/runs/ui/run_detail_visit_sections_test.dart @@ -7,19 +7,10 @@ import 'package:pipelines_app/features/runs/ui/run_detail_visit_facts.dart'; import 'package:pipelines_app/features/runs/ui/run_detail_visit_sections.dart'; import 'package:pipelines_app/features/runs/ui/run_detail_visit_session_state.dart'; import 'package:pipelines_app/ui/adaptive/glass_pill.dart'; -import 'package:pipelines_app/ui/layout/sticky_section.dart'; import 'run_detail_graph_support.dart'; import 'run_detail_visit_support.dart'; -Future _expandArtifactGroups(WidgetTester tester) async { - final sections = find.byType(StickySectionTitle); - for (var index = 0; index < sections.evaluate().length; index += 1) { - await tester.tap(sections.at(index)); - } - await tester.pumpAndSettle(); -} - Future _showTurnDocuments(WidgetTester tester) async { await tester.tap(find.byKey(const Key('artifact-debug-toggle'))); await tester.pumpAndSettle(); @@ -204,7 +195,7 @@ void main() { await openVisit(tester, platform, run: run, sequence: 2); expectVisitHeading(tester, 'plan', 2); await openVisitTab(tester, RunVisitSection.artifacts); - await _expandArtifactGroups(tester); + // Artifact groups start open: the files show without a tap. expect(find.text('plan-2.csv'), findsOneWidget); expect(find.text('public/shared.csv'), findsNothing); expect(find.byType(ArtifactGalleryPage), findsOneWidget);