Merge commit '551e403d48d51e4904387d2c299dcfd9ec62dbf9' into pipelines/run-20261111-1951-material-cleanup-shared-ui-primitives-65fb
This commit is contained in:
@@ -0,0 +1,7 @@
|
||||
# Desktop dialogs for remaining sheets
|
||||
|
||||
Added focused wide/narrow route regressions for the chat colour picker and the
|
||||
Needs you surface. The existing runs filter test already covers the same split.
|
||||
Wide layouts assert a Material `Dialog`; narrow layouts assert a Material
|
||||
`BottomSheet`, while the existing interaction tests continue to cover selection,
|
||||
dismissal, and live updates.
|
||||
@@ -0,0 +1,26 @@
|
||||
# Keyboard shortcuts help
|
||||
|
||||
Added a Settings → Tools → Help entry that opens a root-layered, bounded Material help
|
||||
surface on desktop and the existing adaptive sheet on narrow layouts. The
|
||||
registry reuses the terminal, floating-chat, Center Stage and window-cycle
|
||||
label helpers, and records browser caveats for shortcuts that may be reserved.
|
||||
Search and its tooltip share platform-aware labels for Option/Alt+/, macOS
|
||||
Cmd+/, and Ctrl+/. The separately reviewed Search handler change (run 367)
|
||||
is integrated into this candidate before landing the help.
|
||||
Floating-chat help describes the new Terminal-to-composer focus handoff
|
||||
instead of the obsolete macOS shell-yank exception.
|
||||
Chat list numbering likewise uses Command only on macOS, matching the shell
|
||||
rule on iOS and other platforms.
|
||||
|
||||
Focused verification:
|
||||
|
||||
- `tool/memwatch/full.sh 'test/features/settings/keyboard_shortcuts_help_test.dart test/features/settings/settings_screen_test.dart'`
|
||||
— 15 passed, 0 failed.
|
||||
- `tool/analyze.sh` — clean.
|
||||
|
||||
Browser/full-app capture was not run in this implementation stage; ui-review
|
||||
should verify desktop light/dark, scaled text, keyboard traversal, and phone
|
||||
constraints with the full-app fixture.
|
||||
|
||||
Manager merged-tree verification after Search integration: 24 focused help,
|
||||
Settings, Search-shortcut and chat-keyboard tests passed; analysis was clean.
|
||||
@@ -0,0 +1,34 @@
|
||||
# Material-only fixture cleanup
|
||||
|
||||
Removed alternate Cupertino hosts and query switches from the search, saved-server,
|
||||
and artifact-list browser fixtures. Their existing Material routes, callbacks,
|
||||
text scaling, selection state, and retry behavior remain unchanged. Updated the
|
||||
capture-kit documentation to describe the single Material fixture surface.
|
||||
|
||||
Focused verification: `artifact_visit_list_test.dart` and
|
||||
`artifact_visit_list_semantics_test.dart` passed (14 tests); `tool/analyze.sh`
|
||||
reported clean. No browser capture was run because the fixture chrome host was
|
||||
only simplified, not visually redesigned.
|
||||
|
||||
## Review follow-up
|
||||
|
||||
Removed the remaining `platform=cupertino` branch from the full-app capture
|
||||
fixture and its web/native route helper signatures. The fixture now always
|
||||
constructs the Material app; the shared `PipelinesApp.cupertino` compatibility
|
||||
parameter remains untouched for other callers.
|
||||
|
||||
Focused verification: the two artifact visit-list tests passed (14 tests), and
|
||||
`tool/analyze.sh` reported clean. The first attempted test command used stale
|
||||
paths and failed to load them; the corrected paths were then run successfully.
|
||||
|
||||
## Review follow-up
|
||||
|
||||
Removed the capture CLI's obsolete `--platform` option and URL forwarding,
|
||||
including the script/example `platform` field. Capture routes now expose only
|
||||
the Material fixture while retaining theme, search, sizing, and fixture params.
|
||||
|
||||
Focused verification: `artifact_visit_list_test.dart` and
|
||||
`artifact_visit_list_semantics_test.dart` passed (14 tests); `tool/analyze.sh`
|
||||
reported clean. `node tool/capture/capture.mjs --help` no longer lists a
|
||||
platform option, and no platform/Cupertino capture option remains under
|
||||
`tool/capture`.
|
||||
@@ -0,0 +1,15 @@
|
||||
# Open Search with Alt+/ and Command+/
|
||||
|
||||
- Updated `shellSearchShortcut` to accept an exact Alt+/ chord by physical
|
||||
slash position, including macOS Option dead-key logical values.
|
||||
- Existing Ctrl+/ and macOS Command+/ matching remains logical-slash based;
|
||||
Shift and mixed/extra modifiers remain rejected.
|
||||
- Search destination routing, focus, query retention, and composer drafts were
|
||||
left unchanged.
|
||||
- Focused checks: `tool/memwatch/full.sh 'test/shell/search_shortcuts_test.dart
|
||||
test/shell/destination_shortcuts_test.dart test/shell/list_shortcuts_test.dart
|
||||
test/features/chat/chat_keyboard_focus_test.dart'` — PASS (13 passed, 0
|
||||
failed, 0 skipped).
|
||||
- `tool/analyze.sh` — clean.
|
||||
- Browser capture was not run in this implementation stage; UI review owns
|
||||
full-app Alt+/ and Meta+/ interaction evidence.
|
||||
Reference in New Issue
Block a user