diff --git a/app/notes/P2-node.md b/app/notes/P2-node.md index 680d2284..98d4ae72 100644 --- a/app/notes/P2-node.md +++ b/app/notes/P2-node.md @@ -15,7 +15,7 @@ font, size, padding on a button, palette value or CSS token was added. | `lib/features/graph/widgets/graph_stage_node.dart` | 126 | one content-sized node as a native Material card or Cupertino button | | `test/features/graph/widgets/graph_stage_node_test.dart` | 235 | key identity, semantics, keyboard, focus retention, wrap and terminal honesty | | `test/features/graph/widgets/graph_stage_node_render_test.dart` | 210 | painted-boundary and painted-surface checks on real render objects/pixels | -| `tool/graph_node_probe.dart` | 83 | isolated browser fixture, 1x and 2x narrow cases | +| `tool/graph_node_probe.dart` | 90 | isolated browser fixture with stock light/dark themes, 1x and 2x narrow cases | | `tool/graph_node_probe.mjs` | 151 | headless-Chrome runner: labels, click identity, `aria-current`, captures | | `notes/P2-node.md` | this page | facts for review/landing | @@ -87,21 +87,27 @@ including `#success` / `#failure`; the display label is never used as identity. - **Focus retention.** Tab + Enter on the Material node, then the primary focus must still be a descendant of the node's `Card`. -## Checks actually run +## Checks actually run (landing, after merging main) ``` dart format --output=none --set-exit-if-changed lib/features/graph/widgets \ test/features/graph/widgets tool/graph_node_probe.dart # 0 changed, exit 0 +flutter pub get # dependencies resolved flutter test test/features/graph/widgets # 13 passed -flutter test # 460 passed +flutter test test/features/graph # 113 passed +flutter test # 526 passed flutter analyze # No issues found! flutter build web -t tool/graph_node_probe.dart --release # ✓ Built build/web PROBE_VARIANT=material PROBE_SCHEME=dark node tool/graph_node_probe.mjs # passed, 6 captures PROBE_VARIANT=material PROBE_SCHEME=light node tool/graph_node_probe.mjs # passed, 6 captures PROBE_VARIANT=cupertino PROBE_SCHEME=dark node tool/graph_node_probe.mjs # passed, 6 captures PROBE_VARIANT=cupertino PROBE_SCHEME=light node tool/graph_node_probe.mjs # passed, 6 captures +flutter build web --release # ✓ app bundle restored ``` +The whole-suite count is 526 after `main` brought in the changes viewer and +routed-edge tests; the earlier figure of 460 was measured before that merge. + The runner asserts the initial labels (`Selected: build`, `plan`, `build`, `running`, `Success`, `Failure`), that exactly the `build` node carries `aria-current="true"` (Flutter web maps `Semantics(selected:)` to `aria-current`, @@ -109,26 +115,29 @@ not `aria-selected` — review note 5), that clicking `plan` and `Success` yield exactly `Selected: plan` and `Selected: #success`, and that the selected `aria-current` moves to `plan`. -## Browser evidence (current) +## Browser evidence (landing, current) -Real headless Chrome, loopback fixture only, 390×844 phone and 1280×800 desktop; -dark is Chrome's default scheme, light uses `prefers-color-scheme: light`. +Real headless Chrome, loopback fixture only, 390×844 phone and 1280×800 desktop. +The Material fixture now supplies a stock dark theme (`darkTheme` + +`themeMode.system`), so `PROBE_SCHEME=dark` and `=light` are genuinely different +renders (phone PNG SHA-256 `ac6272fd…` versus `c603c119…`); Cupertino follows the +platform scheme (`3e39555f…` versus `1f40f8b5…`). The runner writes +`material-nodes-*.png`, `light-material-nodes-*.png`, `cupertino-nodes-*.png` and +`light-cupertino-nodes-*.png`, plus `-long-1x-crop.png` / `-long-2x-crop.png`; +the shared copies below use a `land-p2-node-` prefix. -- `/Users/alan/.local/share/pipelines/data/artifacts/64/public/p2-node-fix-material-dark-phone.png` -- `.../p2-node-fix-material-light-phone.png` -- `.../p2-node-fix-material-dark-desktop.png` -- `.../p2-node-fix-material-long-2x-crop.png` (2x enlargement of the wrapped 2x node) -- `.../p2-node-fix-material-long-1x-crop.png` -- `.../p2-node-fix-material-selected-plan.png` -- `.../p2-node-fix-cupertino-dark-phone.png` -- `.../p2-node-fix-cupertino-light-phone.png` -- `.../p2-node-fix-cupertino-dark-desktop.png` -- `.../p2-node-fix-cupertino-long-2x-crop.png` -- `.../p2-node-fix-cupertino-selected-terminal.png` +- `/Users/alan/.local/share/pipelines/data/artifacts/64/public/land-p2-node-material-dark-phone.png` +- `.../land-p2-node-material-light-phone.png` +- `.../land-p2-node-material-dark-long-2x-crop.png` +- `.../land-p2-node-cupertino-dark-phone.png` +- `.../land-p2-node-cupertino-light-phone.png` +- `.../land-p2-node-cupertino-dark-long-2x-crop.png` - Runner: `.../public/graph_node_probe.mjs` (same file as `tool/graph_node_probe.mjs`) -The visit-1 captures (`material-nodes-*.png`, `cupertino-nodes-*.png`) and the UI -review crops are superseded by this set; they are kept only as history. +The visit-2 `p2-node-fix-material-dark-*` captures were the default light theme +with a "dark" name because the fixture had no dark theme; they are history only, +as are the visit-1 `material-nodes-*.png` / `cupertino-nodes-*.png` set and the +UI-review crops. Pixel measurements of the current 2x crops (crops are 2x, 8 logical px margin): @@ -142,10 +151,10 @@ x 16–316, y 16–200 container, and Cupertino ink x 59–264, y 59–164. No glyph ink enters a corner band or crosses the visible boundary in either scaling; the previous outline crossing is gone. -Inspected captures: Material shows outlined node bodies, a visibly filled -selected node, `running` only on `build`, and no status on either terminal; -Cupertino shows a tinted body for every unselected node and a filled selected -node in both light and dark. +Inspected captures: Material shows outlined node bodies and a visibly filled +selected node in real light and dark, `running` only on `build`, and no status on +either terminal; Cupertino shows a tinted body for every unselected node and a +filled selected node in both schemes. ## Honest limits @@ -170,8 +179,9 @@ node in both light and dark. - **No composition.** No canvas, layout invocation, edge painter, visit menu, shell registration or `main.dart` wiring: the widget is still not visible in the app. -- **Not committed.** This stage forbids commit/push/deploy; the paths stay - untracked on `flutter/p2-node-widget` for Review and Land. +- **State of the branch.** The six paths are committed on + `flutter/p2-node-widget` and `main` is merged in with no conflicts; the server + performs the landing and the post-landing ancestry check. - **Fixture-only browser evidence**: no Pipelines server, real run, authentication change, deployment or production data. - **Mobile unverified**: web test/analyze/build only; no Android/iOS build, diff --git a/app/tool/graph_node_probe.dart b/app/tool/graph_node_probe.dart index ff94f501..46c07f9f 100644 --- a/app/tool/graph_node_probe.dart +++ b/app/tool/graph_node_probe.dart @@ -77,6 +77,13 @@ void main() { ? CupertinoApp(home: const _Probe(cupertino: true)) : MaterialApp( theme: ThemeData(platform: TargetPlatform.android), + // Stock dark theme so the forced `prefers-color-scheme` capture is + // a real dark render rather than a duplicate light one. + darkTheme: ThemeData( + platform: TargetPlatform.android, + brightness: Brightness.dark, + ), + themeMode: ThemeMode.system, home: const _Probe(cupertino: false), ), );