Unify flexible list-detail panes and highlight active pipelines and runs
This commit is contained in:
@@ -0,0 +1,40 @@
|
||||
# Consistent selected rows and list/detail panes
|
||||
|
||||
## Changes
|
||||
|
||||
- Pipelines, Runs and Chat now use `shell/list_detail.dart`'s `ListDetailPanes`.
|
||||
Both panes are plain `Expanded` children: equal shares of the available space,
|
||||
with no pixel pane widths, min/max width clamps or per-screen split ratios.
|
||||
Removed the Chat width clamps and Pipelines' separate weighted split.
|
||||
- All three use the existing shared responsive breakpoint for list/detail
|
||||
presentation. Phone-size selections remain real pushed pages with stock Back.
|
||||
- Runs keeps its list, filters and attention bell available beside an open run.
|
||||
Its own detail bar is scoped to the detail pane, matching Chat's composition.
|
||||
The selected row remains visible while loading or when a detail read fails.
|
||||
- Pipelines and Runs use the same theme-based selected backgrounds as Chat:
|
||||
Material secondary-container color and Cupertino tertiary-system fill, with
|
||||
selected semantics. Switching items moves the highlight.
|
||||
- Detail-bar actions flex within the pane rather than overflowing narrow panes.
|
||||
Cupertino destination state survives sidebar/tab-layout reparenting; inline
|
||||
bars do not join route-navigation heroes when resizing into a phone page.
|
||||
|
||||
## Checks and evidence
|
||||
|
||||
- Full `flutter test`: **1,927 passed**. `flutter analyze`: clean.
|
||||
- Release web build: `build/shared-list-detail-web`.
|
||||
- New integration matrix covers both native hosts, light/dark, three widths,
|
||||
every destination, switching two selections, equal pane widths, and
|
||||
wide → phone → wide resizing without clearing the selected item.
|
||||
- Existing run-action/navigation tests now scope detail assertions to the detail
|
||||
(the list deliberately repeats the selected title). Phone Back coverage is
|
||||
retained; wide tests assert the visible list/detail rather than a removed Back.
|
||||
- Real browser probes measure pane bounds and selected accessibility state in
|
||||
`build/shared-list-detail-{material,material-dark,cupertino,cupertino-light}/`.
|
||||
In every variant, list and body widths are equal and identical across all three
|
||||
destinations. Selection changes do not resize either pane. Captures inspected.
|
||||
- Fixture limits: pipeline schedules are intentionally unsupported by the wiring
|
||||
fixture; the second run deliberately refuses its detail read. These are fixture
|
||||
error states, not claims that schedules or provider execution were verified.
|
||||
- No pre-change screenshot captured. Source diffs show the removed independent
|
||||
widths and hidden Runs list. No public web/APK publication or new device test
|
||||
was performed for this change.
|
||||
Reference in New Issue
Block a user