From 7cb95471cb7269b50555d2638e544d97b167b0b0 Mon Sep 17 00:00:00 2001 From: Alan Silva Date: Wed, 11 Nov 2026 21:13:38 +0000 Subject: [PATCH] Format integrated runs and pipelines cleanup --- app/lib/features/pipelines/screen.dart | 2 +- app/lib/features/pipelines/ui/run_pipeline_action.dart | 2 +- app/lib/features/pipelines/widgets/pipeline_detail_panel.dart | 2 +- app/lib/features/pipelines/widgets/pipeline_detail_tab.dart | 1 - app/lib/features/runs/actions/decision_action.dart | 2 +- app/lib/features/runs/screen.dart | 2 +- app/test/ui/adaptive/icon_only_tab_bars_test.dart | 4 +--- 7 files changed, 6 insertions(+), 9 deletions(-) diff --git a/app/lib/features/pipelines/screen.dart b/app/lib/features/pipelines/screen.dart index 77d9d418..ac00caee 100644 --- a/app/lib/features/pipelines/screen.dart +++ b/app/lib/features/pipelines/screen.dart @@ -328,7 +328,7 @@ class _PipelinesScreenState extends State { key: const Key('pipelines-refresh'), label: 'Refresh', icon: Icons.refresh, - onPressed: _controller.load, + onPressed: _controller.load, ); Widget _materialShell(BuildContext context, Widget body) { diff --git a/app/lib/features/pipelines/ui/run_pipeline_action.dart b/app/lib/features/pipelines/ui/run_pipeline_action.dart index aaf1db6a..c0003966 100644 --- a/app/lib/features/pipelines/ui/run_pipeline_action.dart +++ b/app/lib/features/pipelines/ui/run_pipeline_action.dart @@ -175,7 +175,7 @@ class _RunPipelineActionState extends State { key: runPipelineActionKey, label: 'Run ${widget.detail.displayName}', icon: Icons.play_arrow_rounded, - onPressed: _open, + onPressed: _open, ); } return FilledButton( diff --git a/app/lib/features/pipelines/widgets/pipeline_detail_panel.dart b/app/lib/features/pipelines/widgets/pipeline_detail_panel.dart index 8b6b58c2..9a26ecc0 100644 --- a/app/lib/features/pipelines/widgets/pipeline_detail_panel.dart +++ b/app/lib/features/pipelines/widgets/pipeline_detail_panel.dart @@ -408,7 +408,7 @@ class _PipelineDetailPanelState extends State { ? 'View runs of this pipeline' : 'View runs of ${detail.name}', icon: Icons.list_alt_outlined, - onPressed: widget.onViewPipelineRuns == null + onPressed: widget.onViewPipelineRuns == null ? null : () => widget.onViewPipelineRuns!(detail.id), ), diff --git a/app/lib/features/pipelines/widgets/pipeline_detail_tab.dart b/app/lib/features/pipelines/widgets/pipeline_detail_tab.dart index 4ce44775..66c03795 100644 --- a/app/lib/features/pipelines/widgets/pipeline_detail_tab.dart +++ b/app/lib/features/pipelines/widgets/pipeline_detail_tab.dart @@ -13,5 +13,4 @@ enum PipelineDetailTab { /// The tab's glyph, the only thing the bottom bar draws (the label is its /// accessible name); distinct from the shell's Pipelines tab beneath it. final IconData icon; - } diff --git a/app/lib/features/runs/actions/decision_action.dart b/app/lib/features/runs/actions/decision_action.dart index e7a353c9..51ac651c 100644 --- a/app/lib/features/runs/actions/decision_action.dart +++ b/app/lib/features/runs/actions/decision_action.dart @@ -62,7 +62,7 @@ class _HumanDecisionActionState extends State { context: context, run: widget.run, gateway: widget.gateway, - onRunChanged: _acceptRun, + onRunChanged: _acceptRun, isCurrent: () => _owns(decision.runId), ); } finally { diff --git a/app/lib/features/runs/screen.dart b/app/lib/features/runs/screen.dart index c991ac95..79a87e73 100644 --- a/app/lib/features/runs/screen.dart +++ b/app/lib/features/runs/screen.dart @@ -218,7 +218,7 @@ class _RunsScreenState extends State { run: current, gateway: widget.gateway, onRunChanged: controller.acceptRunDetail, - isCurrent: () => mounted && controller.selectedRunId == selected, + isCurrent: () => mounted && controller.selectedRunId == selected, ), ); }); diff --git a/app/test/ui/adaptive/icon_only_tab_bars_test.dart b/app/test/ui/adaptive/icon_only_tab_bars_test.dart index 3d9cc416..1c866b6b 100644 --- a/app/test/ui/adaptive/icon_only_tab_bars_test.dart +++ b/app/test/ui/adaptive/icon_only_tab_bars_test.dart @@ -123,9 +123,7 @@ void main() { }; final details = [ for (final tab in renderedRunDetailTabs) tab.icon, - for (final section in shownVisitSections) ...[ - section.icon, - ], + for (final section in shownVisitSections) ...[section.icon], for (final tab in PipelineDetailTab.values) tab.icon, ]; for (final icon in details) {