From 79dc1dc029ead5146f3268140d658ab255269a97 Mon Sep 17 00:00:00 2001 From: Alan Silva Date: Fri, 23 Oct 2026 13:12:17 +0100 Subject: [PATCH] fix(app): a short server URL keeps a one-line settings field --- .../features/settings/settings_controls.dart | 2 ++ .../settings/settings_screen_test.dart | 22 +++++++++++++++++++ 2 files changed, 24 insertions(+) diff --git a/app/lib/features/settings/settings_controls.dart b/app/lib/features/settings/settings_controls.dart index 4098daf7..32be8d4d 100644 --- a/app/lib/features/settings/settings_controls.dart +++ b/app/lib/features/settings/settings_controls.dart @@ -63,6 +63,7 @@ class SettingsTextField extends StatelessWidget { controller: controller, onChanged: onChanged, keyboardType: TextInputType.url, + minLines: 1, maxLines: maxLines, autocorrect: false, enableSuggestions: false, @@ -107,6 +108,7 @@ class SettingsTextField extends StatelessWidget { onChanged: onChanged, placeholder: placeholder, keyboardType: TextInputType.url, + minLines: 1, maxLines: maxLines, autocorrect: false, enableSuggestions: false, diff --git a/app/test/features/settings/settings_screen_test.dart b/app/test/features/settings/settings_screen_test.dart index 8bc8e0d5..4bfc9494 100644 --- a/app/test/features/settings/settings_screen_test.dart +++ b/app/test/features/settings/settings_screen_test.dart @@ -71,6 +71,28 @@ void main() { expect(tester.takeException(), isNull); }); + testWidgets('a short server URL keeps a one-line field', (tester) async { + final client = transport.PipelinesClient( + channelFactory: FakeChannelFactory().call, + ); + addTearDown(client.dispose); + await _pump( + tester, + client, + store: MemorySettingsStore(serverUrl: 'ws://127.0.0.1:8080/connect'), + ); + + final fields = find.byType(TextField); + final url = tester.widget(fields.first); + expect(url.minLines, 1); + // The URL field grows only when its text wraps: one line is the same + // height as the single-line workspace field below it. + Size editable(Finder field) => tester.getSize( + find.descendant(of: field, matching: find.byType(EditableText)), + ); + expect(editable(fields.first).height, editable(fields.last).height); + }); + testWidgets('an invalid URL shows the field error and opens no socket', ( tester, ) async {