From 795c5d3a791377d6df7ec1ea0b6b6d347df1d396 Mon Sep 17 00:00:00 2001 From: Alan Silva Date: Fri, 23 Oct 2026 12:13:51 +0100 Subject: [PATCH] fix(app): wrap long settings server URLs --- .../features/settings/settings_controls.dart | 4 +++ .../features/settings/settings_sections.dart | 1 + .../settings/settings_screen_test.dart | 27 +++++++++++++++++++ 3 files changed, 32 insertions(+) diff --git a/app/lib/features/settings/settings_controls.dart b/app/lib/features/settings/settings_controls.dart index 0f5a639f..4098daf7 100644 --- a/app/lib/features/settings/settings_controls.dart +++ b/app/lib/features/settings/settings_controls.dart @@ -21,6 +21,7 @@ class SettingsTextField extends StatelessWidget { required this.helper, required this.onChanged, this.error = '', + this.maxLines = 1, }); final TextEditingController controller; @@ -29,6 +30,7 @@ class SettingsTextField extends StatelessWidget { final String helper; final ValueChanged onChanged; final String error; + final int maxLines; @override Widget build(BuildContext context) { @@ -61,6 +63,7 @@ class SettingsTextField extends StatelessWidget { controller: controller, onChanged: onChanged, keyboardType: TextInputType.url, + maxLines: maxLines, autocorrect: false, enableSuggestions: false, textInputAction: TextInputAction.done, @@ -104,6 +107,7 @@ class SettingsTextField extends StatelessWidget { onChanged: onChanged, placeholder: placeholder, keyboardType: TextInputType.url, + maxLines: maxLines, autocorrect: false, enableSuggestions: false, clearButtonMode: OverlayVisibilityMode.editing, diff --git a/app/lib/features/settings/settings_sections.dart b/app/lib/features/settings/settings_sections.dart index 35c112e8..b80b729c 100644 --- a/app/lib/features/settings/settings_sections.dart +++ b/app/lib/features/settings/settings_sections.dart @@ -37,6 +37,7 @@ class SettingsConnectionSection extends StatelessWidget { helper: serverUrlHelper, error: controller.urlError, onChanged: controller.updateServerUrl, + maxLines: 2, ), const SizedBox(height: settingsTitleGap), SettingsActions( diff --git a/app/test/features/settings/settings_screen_test.dart b/app/test/features/settings/settings_screen_test.dart index 66d4d2d1..8bc8e0d5 100644 --- a/app/test/features/settings/settings_screen_test.dart +++ b/app/test/features/settings/settings_screen_test.dart @@ -44,6 +44,33 @@ void main() { expect(factory.channels, isEmpty); }); + testWidgets('long server URLs can wrap in a narrow settings viewport', ( + tester, + ) async { + tester.view.physicalSize = const Size(390, 844); + tester.view.devicePixelRatio = 1; + addTearDown(tester.view.resetPhysicalSize); + addTearDown(tester.view.resetDevicePixelRatio); + + final client = transport.PipelinesClient( + channelFactory: FakeChannelFactory().call, + ); + addTearDown(client.dispose); + await _pump( + tester, + client, + store: MemorySettingsStore( + serverUrl: + 'wss://a-very-long-server-hostname-that-exceeds-a-mobile-field.test:8123/connect', + ), + ); + + final field = tester.widget(find.byType(TextField).first); + expect(field.maxLines, 2); + expect(field.controller?.text, contains('/connect')); + expect(tester.takeException(), isNull); + }); + testWidgets('an invalid URL shows the field error and opens no socket', ( tester, ) async {