From 6d623197f9b784c8a5874439609d7e0adb499271 Mon Sep 17 00:00:00 2001 From: Alan Silva Date: Sat, 24 Oct 2026 11:13:22 +0100 Subject: [PATCH] perf(chat): isolate usage updates from transcript rendering --- .../conversation/chat_thread_controller.dart | 13 +++- .../chat/conversation/chat_thread_view.dart | 2 +- .../conversation/chat_usage_rebuild_test.dart | 63 +++++++++++++++++++ 3 files changed, 74 insertions(+), 4 deletions(-) create mode 100644 app/test/features/chat/conversation/chat_usage_rebuild_test.dart diff --git a/app/lib/features/chat/conversation/chat_thread_controller.dart b/app/lib/features/chat/conversation/chat_thread_controller.dart index d83d54c5..828b271b 100644 --- a/app/lib/features/chat/conversation/chat_thread_controller.dart +++ b/app/lib/features/chat/conversation/chat_thread_controller.dart @@ -35,6 +35,7 @@ class ChatThreadController extends ChangeNotifier { isAlive: () => !_disposed, ); StreamSubscription? _subscription; + final _transcriptChanges = ChangeNotifier(); List _messages = const []; bool _running = false; @@ -55,6 +56,9 @@ class ChatThreadController extends ChangeNotifier { bool _resyncAgain = false; List get messages => _messages; + + /// Usage-only snapshots refresh Info, not the expensive transcript tree. + Listenable get transcriptChanges => _transcriptChanges; bool get running => _running; String? get liveAssistantMessageId => _liveAssistantMessageId; bool get loaded => _loaded; @@ -239,7 +243,7 @@ class ChatThreadController extends ChangeNotifier { final usage = chatUsageSnapshot(body['usage']); if (usage == null || !_reportedUsage(usage)) return; _usage = usage; - _notify(); + _notify(transcript: false); return; } if (body['kind'] == 'form') { @@ -334,13 +338,16 @@ class ChatThreadController extends ChangeNotifier { _notify(); } - void _notify() { - if (!_disposed) notifyListeners(); + void _notify({bool transcript = true}) { + if (_disposed) return; + notifyListeners(); + if (transcript && !_disposed) _transcriptChanges.notifyListeners(); } @override void dispose() { _disposed = true; + _transcriptChanges.dispose(); _generation++; unawaited(_subscription?.cancel()); super.dispose(); diff --git a/app/lib/features/chat/conversation/chat_thread_view.dart b/app/lib/features/chat/conversation/chat_thread_view.dart index c35b670a..a0eb6a70 100644 --- a/app/lib/features/chat/conversation/chat_thread_view.dart +++ b/app/lib/features/chat/conversation/chat_thread_view.dart @@ -575,7 +575,7 @@ class _ChatThreadViewState extends State { @override Widget build(BuildContext context) => AnimatedBuilder( - animation: _controller, + animation: _controller.transcriptChanges, builder: (context, _) { final cupertino = chatControlsStyleOf(context) == ChatControlsStyle.cupertino; diff --git a/app/test/features/chat/conversation/chat_usage_rebuild_test.dart b/app/test/features/chat/conversation/chat_usage_rebuild_test.dart new file mode 100644 index 00000000..d7198528 --- /dev/null +++ b/app/test/features/chat/conversation/chat_usage_rebuild_test.dart @@ -0,0 +1,63 @@ +import 'package:flutter/cupertino.dart'; +import 'package:flutter/material.dart'; +import 'package:flutter_test/flutter_test.dart'; +import 'package:pipelines_app/features/chat/conversation/chat_thread_view.dart'; +import 'package:pipelines_app/features/chat/ui/transcript/chat_message_view.dart'; + +import 'chat_thread_fixtures.dart'; + +void main() { + for (final cupertino in [false, true]) { + testWidgets( + 'usage updates leave transcript widgets alone but refresh Info ($cupertino)', + (tester) async { + final gateway = FakeChatGateway(); + addTearDown(gateway.close); + gateway.history = (_) async => chatPage([ + chatMessage( + 'a1', + 'assistant', + parts: [ + {'type': 'text', 'text': '**Existing answer**'}, + ], + ), + ]); + final thread = ChatThreadView( + gateway: gateway, + sessionId: 's', + onBack: () {}, + ); + await tester.pumpWidget( + cupertino + ? CupertinoApp(home: CupertinoPageScaffold(child: thread)) + : MaterialApp(home: Scaffold(body: thread)), + ); + await tester.pumpAndSettle(); + final answer = tester.widget( + find.byType(ChatMessageView), + ); + gateway.emitEvent({ + 'session_id': 's', + 'kind': 'usage', + 'usage': {'scope': 'session', 'total_tokens': 123}, + }); + await tester.pumpAndSettle(); + expect( + tester.widget(find.byType(ChatMessageView)), + same(answer), + ); + await tester.tap(find.byKey(const Key('chat-info'))); + await tester.pumpAndSettle(); + expect(find.text('123'), findsOneWidget); + gateway.emitEvent({ + 'session_id': 's', + 'kind': 'usage', + 'usage': {'scope': 'session', 'total_tokens': 456}, + }); + await tester.pumpAndSettle(); + expect(find.text('456'), findsOneWidget); + expect(find.text('123'), findsNothing); + }, + ); + } +}