From 6a071a5b024931f2ca39b807a7b05b1b122ac7c7 Mon Sep 17 00:00:00 2001 From: Alan Silva Date: Tue, 10 Nov 2026 23:02:20 +0000 Subject: [PATCH] Drop Cupertino variants of the row menu and run detail tests --- .../chat/ui/sessions/chat_color_test.dart | 3 ++- .../sessions/chat_sessions_screen_test.dart | 24 ------------------- .../ui/sessions/chat_split_menu_test.dart | 3 ++- .../runs/ui/run_detail_widget_test.dart | 3 ++- 4 files changed, 6 insertions(+), 27 deletions(-) diff --git a/app/test/features/chat/ui/sessions/chat_color_test.dart b/app/test/features/chat/ui/sessions/chat_color_test.dart index cf958438..c3a59fca 100644 --- a/app/test/features/chat/ui/sessions/chat_color_test.dart +++ b/app/test/features/chat/ui/sessions/chat_color_test.dart @@ -78,7 +78,8 @@ Color _accentColor(WidgetTester tester, String id) => tester.widget(_accent(id)).accent!; void main() { - for (final cupertino in [false, true]) { + // The row menu is Material only. + for (final cupertino in [false]) { for (final brightness in Brightness.values) { final host = '${cupertino ? 'Cupertino' : 'Material'} ${brightness.name}'; diff --git a/app/test/features/chat/ui/sessions/chat_sessions_screen_test.dart b/app/test/features/chat/ui/sessions/chat_sessions_screen_test.dart index 2513481a..5fe5506a 100644 --- a/app/test/features/chat/ui/sessions/chat_sessions_screen_test.dart +++ b/app/test/features/chat/ui/sessions/chat_sessions_screen_test.dart @@ -178,30 +178,6 @@ void main() { }, ); - testWidgets('duplicate Cupertino titles disambiguate the action labels', ( - tester, - ) async { - final semantics = tester.ensureSemantics(); - final gateway = FakeChatGateway() - ..sessionsReply = { - 'chat_sessions': [ - {'id': 'd1', 'title': 'New chat', 'directory': '/work'}, - {'id': 'd2', 'title': 'New chat', 'directory': '/work'}, - ], - }; - await pumpCupertinoChat(tester, gateway); - - expect( - tester.getSemantics(find.byKey(const Key('chat-actions-d1'))).label, - 'Chat actions for New chat (d1)', - ); - expect( - tester.getSemantics(find.byKey(const Key('chat-actions-d2'))).label, - 'Chat actions for New chat (d2)', - ); - semantics.dispose(); - }); - testWidgets('closed chats start folded away behind their heading', ( tester, ) async { diff --git a/app/test/features/chat/ui/sessions/chat_split_menu_test.dart b/app/test/features/chat/ui/sessions/chat_split_menu_test.dart index 91316e1c..5eb02902 100644 --- a/app/test/features/chat/ui/sessions/chat_split_menu_test.dart +++ b/app/test/features/chat/ui/sessions/chat_split_menu_test.dart @@ -8,7 +8,8 @@ import 'chat_test_harness.dart'; import 'fake_chat_gateway.dart'; void main() { - for (final cupertino in [false, true]) { + // The row menu is Material only. + for (final cupertino in [false]) { for (final beside in [false, true]) { testWidgets( '${cupertino ? 'Cupertino' : 'Material'} split menu passes selected chat ${beside ? 'beside' : 'below'}', diff --git a/app/test/features/runs/ui/run_detail_widget_test.dart b/app/test/features/runs/ui/run_detail_widget_test.dart index af3d96e0..05cffd34 100644 --- a/app/test/features/runs/ui/run_detail_widget_test.dart +++ b/app/test/features/runs/ui/run_detail_widget_test.dart @@ -133,7 +133,8 @@ void main() { }); tearDown(() => controller.dispose()); - for (final platform in AppPlatform.values) { + // The run's More menu is Material only. + for (final platform in [AppPlatform.material]) { testWidgets('${platform.name} detail at 390 with 2x text', (tester) async { gateway.detail = runFixture(steps: 12); await controller.select(1);