From 66cb9edee1367da311589ecfacc3ac312dc1a395 Mon Sep 17 00:00:00 2001 From: Alan Silva Date: Wed, 11 Nov 2026 21:08:54 +0000 Subject: [PATCH] Keep diff choices readable at large text sizes --- .../features/changes/widgets/diff_form_control.dart | 3 +++ app/lib/ui/adaptive/app_popups.dart | 3 +++ app/notes/material-chat-cleanup.md | 11 +++++++++++ 3 files changed, 17 insertions(+) diff --git a/app/lib/features/changes/widgets/diff_form_control.dart b/app/lib/features/changes/widgets/diff_form_control.dart index 2b4a939f..6d9cbac2 100644 --- a/app/lib/features/changes/widgets/diff_form_control.dart +++ b/app/lib/features/changes/widgets/diff_form_control.dart @@ -80,6 +80,9 @@ Widget diffFormMenu( for (final entry in diffFormLabels.entries) AppChoiceMenuItem( selected: entry.key == form, + // At accessibility text sizes the check mark otherwise leaves + // too little room for the longest label in the phone sheet. + contentPadding: EdgeInsets.zero, onTap: () { Navigator.of(sheetContext).pop(); onChanged(entry.key); diff --git a/app/lib/ui/adaptive/app_popups.dart b/app/lib/ui/adaptive/app_popups.dart index 4d035b15..e46c0e26 100644 --- a/app/lib/ui/adaptive/app_popups.dart +++ b/app/lib/ui/adaptive/app_popups.dart @@ -65,16 +65,19 @@ class AppChoiceMenuItem extends StatelessWidget { required this.child, required this.selected, required this.onTap, + this.contentPadding, }); final Widget child; final bool selected; final VoidCallback? onTap; + final EdgeInsetsGeometry? contentPadding; @override Widget build(BuildContext context) => ListTile( enabled: onTap != null, title: child, + contentPadding: contentPadding, trailing: selected ? Icon(Icons.check, color: Theme.of(context).colorScheme.primary) : null, diff --git a/app/notes/material-chat-cleanup.md b/app/notes/material-chat-cleanup.md index 96c69090..f767953e 100644 --- a/app/notes/material-chat-cleanup.md +++ b/app/notes/material-chat-cleanup.md @@ -14,3 +14,14 @@ - `tool/analyze.sh`: clean. - No rendered capture was performed; these changes remove alternate metadata and branches without changing Material layout or visual behavior. + +## Land-gate regression follow-up + +- Fixed the narrow 2x-text diff-form bottom sheet: its selected check mark no + longer reduces the `Rendered` title below the width of the whole word. +- Added optional `contentPadding` to the shared Material `AppChoiceMenuItem`; + only the diff-form menu uses zero padding for this constrained case. +- Focused watchdog: 16 passed, 0 failed in + `test/features/changes/diff_presentation_test.dart` and + `test/ui/adaptive/app_popups_test.dart`. +- `tool/analyze.sh`: clean.