Merge commit 'ff6a6e18d2408c4b5f24c0ded0e293240dc8d7aa' into pipelines/run-20261112-0053-remove-templates-from-settings-b935
This commit is contained in:
@@ -0,0 +1,40 @@
|
||||
# Center stage column edges
|
||||
|
||||
## Change
|
||||
- In center stage (Alt+E / Option+E), the centred chat column had no visible
|
||||
boundary: its neighbours are strips or the workspace background, so the
|
||||
column's end read as unfinished.
|
||||
- Added two 1px `outlineVariant` hairlines (`ChatCenterStageEdges` in
|
||||
`app/lib/features/chat/workspace/chat_center_stage_edges.dart`). Each sits
|
||||
centred in the 12px gap beside the stage, or on the workspace edge when the
|
||||
stage reaches it.
|
||||
- Painted from `chat_workspace_surface.dart`, only while a stage layout exists.
|
||||
The split layout, phone/collapsed layouts and single-chat workspaces draw
|
||||
nothing new.
|
||||
- Reading width is unchanged (stage stays `chatCenterStageWidth`, 950 at the
|
||||
test size). The lines travel with the stage's animated rectangle.
|
||||
|
||||
## Focused results
|
||||
- `tool/memwatch/full.sh 'test/features/chat/workspace/chat_center_stage_test.dart'`
|
||||
→ PASS: 21 passed, 0 failed, 0 skipped; peak 893 MB; 8s; exit 0.
|
||||
New tests among them:
|
||||
- `the stage edges sit in the gaps beside the stage, or on the workspace edge`
|
||||
- `center stage draws the column edges in the light theme, only on stage`
|
||||
- `center stage draws the column edges in the dark theme, only on stage`
|
||||
- `tool/analyze.sh` → clean, exit 0.
|
||||
- Not run: other `test/features/chat/workspace/*` files use `ChatWorkspace`
|
||||
without `centerStage` on stage, so the new branch is not reached there. The
|
||||
land gate runs the suites.
|
||||
|
||||
## Affected states (code-level only)
|
||||
- Center stage on, 3 panes, light and dark: both hairlines present, colour is
|
||||
the theme's `outlineVariant`.
|
||||
- Center stage off: no hairlines (asserted in both themes).
|
||||
- Stage with a neighbour on each side (gaps) and stage at a workspace edge
|
||||
(line on the edge) are both covered by the geometry test.
|
||||
|
||||
## Limitations
|
||||
- No browser or device capture was made; `ui-review` owns visual evidence.
|
||||
Visual weight of a 1px `outlineVariant` line in light and dark is unverified.
|
||||
- Hairlines hide at once when leaving center stage (same as the split
|
||||
dividers); they do not fade.
|
||||
@@ -29,6 +29,14 @@ every destination and come back at app start without Chat being opened.
|
||||
terminal). On macOS Ctrl+Y in a terminal always goes to the shell.
|
||||
- **Focus**: a window that shows or comes to the top puts the keyboard in its
|
||||
composer; hiding the last window gives it back to what had it.
|
||||
- **Cycle**: while a floating chat window's content holds the keyboard (a
|
||||
composer, a Files page inside it), Ctrl+Tab brings the next visible chat
|
||||
window to the top and Ctrl+Shift+Tab the previous one, wrapping round. The
|
||||
order is the stacking order, bottom to top, and the window's composer takes
|
||||
the keyboard. Command+Tab stays with the system. With the tiling focused,
|
||||
Ctrl+Tab still cycles its panes; while the terminal claims tab keys (shown)
|
||||
it switches terminal tabs. Alt+` (`windowCycleShortcut`) still cycles every
|
||||
kind of window, not only chats.
|
||||
- **Popups**: sheets, dialogs, menus and tooltips opened from a floating chat
|
||||
are above every window. Files opens as a page inside the window, and a file
|
||||
opened from it stays in the window. Because the window's own title bar names
|
||||
@@ -60,6 +68,23 @@ every destination and come back at app start without Chat being opened.
|
||||
|
||||
## Checks
|
||||
|
||||
- Focused, 2026-11-12, `tool/memwatch/full.sh` with
|
||||
`test/features/chat/chat_floating_pane_test.dart` and
|
||||
`test/features/terminal/terminal_chat_tab_test.dart`: 16 passed, 0 failed.
|
||||
New in the first: Ctrl+Tab and Ctrl+Shift+Tab over three floating chats
|
||||
(order, wrap, composer focus, Command+Tab ignored); with the tiling focused
|
||||
Ctrl+Tab moves the active pane and leaves the windows alone, and with one
|
||||
window focused it does nothing; a terminal that claims tab keys keeps
|
||||
Ctrl+Tab over a focused chat window.
|
||||
- `tool/analyze.sh` on the changed paths: clean.
|
||||
- Affected states: two or more floating chats; one floating chat; tiling
|
||||
focused; a window focused with the terminal shown (claimed); Command+Tab.
|
||||
- Not covered: the terminal's own tab switching (the test app has no terminal
|
||||
surface), real browser or device keys, and captures (ui-review's).
|
||||
- Observed, not changed: in the widget harness, floating from a pane's More
|
||||
menu does not leave the keyboard in the new window's composer (the window
|
||||
takes it); the chord and Ctrl+Tab do.
|
||||
|
||||
- `test/features/chat/chat_floating_pane_test.dart` (the Chat screen with the
|
||||
window host), `test/features/chat/windows/chat_windows_test.dart`,
|
||||
`test/features/chat/workspace/chat_workspace_float_test.dart`,
|
||||
|
||||
@@ -0,0 +1,32 @@
|
||||
# Ctrl+K / Alt+K open Chat
|
||||
|
||||
Run 391 (ctrl-k-and-alt-k-open-chat), stage 01-implement. Not committed.
|
||||
|
||||
## Behaviour
|
||||
- Ctrl+K, or Alt+K (Option+K on Apple platforms, matched by physical key so the dead-key symbol still counts), switches the shell to the Chat destination from any destination, then calls `AdaptiveShell.onOpenChat`.
|
||||
- The app passes `_focusOpenChatComposer`, which requests the composer of the last workspace chat (`_chatWorkspaceRoute`) through `ChatRuntime.composerFocus`.
|
||||
- Ctrl+K is left to the terminal while the terminal has the keyboard (`primaryFocusIsTypingSurface`). Alt+K still switches there.
|
||||
- Shift, Meta, or Ctrl+Alt together do not match. Repeats are swallowed; only the first key-down acts.
|
||||
- The help page has an "Open Chat" entry: `Option+K, Ctrl+K` on macOS, `Alt+K, Ctrl+K` elsewhere.
|
||||
|
||||
## Changed paths
|
||||
- `app/lib/shell/shell_chat_shortcut.dart` (new): `shellChatShortcut`, `shellChatShortcutLabels`.
|
||||
- `app/lib/shell/adaptive_shell.dart`: key handling, `_openChat`, `onOpenChat` parameter.
|
||||
- `app/lib/application/pipelines_app.dart`: `_focusOpenChatComposer`, wired as `onOpenChat`.
|
||||
- `app/lib/features/settings/keyboard_shortcuts_registry.dart`: "Open Chat" entry.
|
||||
- `app/test/shell/shell_chat_shortcut_test.dart` (new): matcher, switch from another destination, controlled shell callback, terminal exception.
|
||||
- `app/test/application/chat_open_shortcut_test.dart` (new): the full `PipelinesApp` opens `/chat/s1`, moves to Runs, then Alt+K and Ctrl+K each return to `/chat/s1` and put the keyboard in the `s1` composer (primary focus).
|
||||
- `app/test/features/settings/keyboard_shortcuts_help_test.dart`: "Open Chat" help entry test.
|
||||
|
||||
## Focused results
|
||||
- Review follow-up (composer focus), `tool/memwatch/full.sh 'test/application/chat_open_shortcut_test.dart test/shell/shell_chat_shortcut_test.dart test/features/settings/keyboard_shortcuts_help_test.dart'`: PASS, 12 passed, 0 failed, peak 1306 MB, 5s, exit 0. Run after `dart format` on the new test.
|
||||
- Mutation check: with the `_focusOpenChatComposer` request removed from `pipelines_app.dart`, `chat_open_shortcut_test.dart` fails on the composer focus expectation. The source was restored afterwards; `git diff` shows the original wiring.
|
||||
- Earlier stage run (not repeated here): `test/shell/destination_shortcuts_test.dart`, `test/shell/search_shortcuts_test.dart`, `test/features/chat/workspace/chat_float_shortcut_test.dart` passed with the shell test and help test (21 passed, 0 failed, peak 1062 MB).
|
||||
- `tool/analyze.sh`: clean.
|
||||
- Tests that press K chords: none outside the new files. The new shell check returns false for every other key, so the earlier typing-surface and search paths keep their order.
|
||||
|
||||
## Not covered
|
||||
- The composer-focus test drives the real app with a fake channel; it does not cover a chat opened only through a route with no history yet.
|
||||
- No UI capture or device run (ui-review owns that).
|
||||
- Ctrl+Y: the float chord is not left to the terminal. `chatFloatShortcut` matches Ctrl+Y on every platform, and `chat_floating_pane_test.dart` covers Ctrl+Y from the terminal on macOS. Ctrl+K was made the only terminal exception, as the task asked.
|
||||
- On web, the browser may keep Ctrl+K (address/search focus); the help caveat says so.
|
||||
Reference in New Issue
Block a user