fix: stop store-bound workers and reconcile settled repair fixtures
This commit is contained in:
@@ -354,6 +354,8 @@ func (r *runner) resumeRunNotifications() {
|
||||
select {
|
||||
case <-r.ctx.Done():
|
||||
return
|
||||
case <-r.store.Done():
|
||||
return
|
||||
case <-ticker.C:
|
||||
r.deliverRunNotifications(time.Now())
|
||||
}
|
||||
|
||||
@@ -19,6 +19,8 @@ func (r *runner) scheduleLoop() {
|
||||
select {
|
||||
case <-r.ctx.Done():
|
||||
return
|
||||
case <-r.store.Done():
|
||||
return
|
||||
case now := <-ticker.C:
|
||||
if err := r.scheduleTick(now, false); err != nil {
|
||||
log.Printf("scheduler: %v", err)
|
||||
|
||||
@@ -100,11 +100,22 @@ func TestRuntimeRepairRejectsUnrecordedAndActiveVisits(t *testing.T) {
|
||||
h, _, id := sessionExportRunner(t, "v2", func(stage.SessionExportRequest) (stage.SessionExportResult, error) {
|
||||
return stage.SessionExportResult{}, errors.New("unavailable")
|
||||
})
|
||||
for _, sequence := range []int{0, 1, 2} {
|
||||
for _, sequence := range []int{0, 2} {
|
||||
if _, err := h.runner.repairSessionExport(context.Background(), id, sequence); err == nil {
|
||||
t.Fatalf("invalid visit %d accepted", sequence)
|
||||
}
|
||||
}
|
||||
// The shared fixture now confirms executor cleanup, as the runtime should.
|
||||
// Explicitly model an in-flight executor for the active-visit repair case.
|
||||
h.runner.mu.Lock()
|
||||
h.runner.active[id] = activeRun{cancel: func() {}}
|
||||
h.runner.mu.Unlock()
|
||||
if _, err := h.runner.repairSessionExport(context.Background(), id, 1); err == nil {
|
||||
t.Fatal("active visit accepted for export repair")
|
||||
}
|
||||
h.runner.mu.Lock()
|
||||
delete(h.runner.active, id)
|
||||
h.runner.mu.Unlock()
|
||||
}
|
||||
|
||||
func TestCLIRepairSessionExportUsesRuntimeProtocol(t *testing.T) {
|
||||
|
||||
@@ -0,0 +1,32 @@
|
||||
package server
|
||||
|
||||
import (
|
||||
"context"
|
||||
"path/filepath"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"git.a-wan.net/alan/pipelines/internal/pipeline"
|
||||
)
|
||||
|
||||
func TestNotificationWorkerStopsWhenEmbeddedStoreCloses(t *testing.T) {
|
||||
store, err := pipeline.Open(filepath.Join(t.TempDir(), "workers.db"))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
r, err := newRunner(context.Background(), store)
|
||||
if err != nil {
|
||||
store.Close()
|
||||
t.Fatal(err)
|
||||
}
|
||||
if err := store.Close(); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
done := make(chan struct{})
|
||||
go func() { r.schedulerWG.Wait(); close(done) }()
|
||||
select {
|
||||
case <-done:
|
||||
case <-time.After(time.Second):
|
||||
t.Fatal("notification worker outlived its store")
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user