From 4ab65692d6d193df895435980867f6af4871e322 Mon Sep 17 00:00:00 2001 From: Alan Silva Date: Mon, 19 Oct 2026 00:40:10 +0100 Subject: [PATCH] Schedule Android UI review through the android-devices pool The Android UI reviewer declares the android-devices pool instead of one hard-coded Pixel, so a second UI run can use the idle foldable emulator instead of waiting behind the single phone. Updates the Android map's device rules to match the pool (replacing the old single-phone / no-emulator rule) and records the pool, its members and the delivery-only personal Fold in a note. Safety rules are unchanged; configuration and the pipeline version are separate steps. --- android/AGENTS.md | 34 +++++++++++++++++----------- docs/notes/android-device-pool.md | 37 +++++++++++++++++++++++++++++++ 2 files changed, 58 insertions(+), 13 deletions(-) create mode 100644 docs/notes/android-device-pool.md diff --git a/android/AGENTS.md b/android/AGENTS.md index c6ae43ed..469362b9 100644 --- a/android/AGENTS.md +++ b/android/AGENTS.md @@ -18,30 +18,38 @@ GRADLE=/Users/alan/.gradle/wrapper/dists/gradle-8.11.1-bin/bpt9gzteqjrbo1mjrsomd Always `--no-daemon`: a leftover daemon is what makes these look slow. Add **one** test class at a time while iterating — the full suite is for the end. -## The dev device +## Devices and the resource pool The ADB executable is `/Users/alan/Library/Android/sdk/platform-tools/adb`. Use that absolute path (or explicitly add its directory to PATH); `adb: command -not found` alone is not evidence that the leased phone is disconnected. +not found` alone is not evidence that the leased device is disconnected. For populated attention review, `TestExportReadyAttentionReviewFixture` exports a create-only scratch database when `PIPELINES_ATTENTION_REVIEW_DIR` names a new directory. Its fixture.json identifies one failed, one finished and one waiting run and the workspace. Build a scratch server, read back those states, and keep the owned server alive through all UI interactions. The export itself does not -leave a server running or configure a phone. Never use a dead scratch endpoint. +leave a server running or configure a device. Never use a dead scratch endpoint. -Only the **UI reviewer**, while its stage holds a declared runner-exclusive resource -for the selected phone, may use the device. Implementers and code reviewers do code, -builds, unit tests and source review only: **no adb, installs, captures, device-setting -changes or main-build restoration**. Never acquire a phone using sleep/check loops. -Do not use the phone until compatible resource scheduling is deployed and every device -user has opted in or has been reconciled by the operator. Existing pinned runs are not -retroactively protected. The resource for the device below is `phone-47241FDAS00DLK`. +Only the **UI reviewer**, while its stage holds the runner-granted resource for its +visit, may use a device. Implementers and code reviewers do code, builds, unit +tests and source review only: **no adb, installs, captures, device-setting changes +or main-build restoration**. Never acquire a device using sleep/check loops. The +runner grants exactly one concrete member of the `android-devices` resource pool +and passes it to the stage as `resource_target`; take the `adb -s` target from +`resource_target.metadata.adb_serial` and do not choose a device yourself. -The only device is the operator's **Pixel 9 Pro XL, serial `47241FDAS00DLK`**. The operator's -Pixel 10 Pro Fold (`58281FDCG000JF`) is theirs: use it only where an item's brief explicitly allows -it, and never make it a default. **Never start or use an emulator.** +The pool's two members are: + +- `phone-47241FDAS00DLK` — the operator's **Pixel 9 Pro XL**, adb serial + `47241FDAS00DLK` (metadata `kind=phone`). +- `emulator-Pipelines_Fold_A` — one managed **foldable emulator**, adb serial + `emulator-5554` (metadata `kind=emulator`, `avd=Pipelines_Fold_A`). Its unfolded + built-in display is 2076x2152; its cover display is 1080x2424. + +The operator's **Pixel 10 Pro Fold** (`58281FDCG000JF`) is delivery-only: never a +test target. Do not start an ad-hoc emulator — the one managed foldable AVD above +is the only emulator in scope. The UI reviewer records original app connection/workspace, display size and power/settings before changing them. Before any capture: `svc power stayon usb`, `settings put global stay_on_while_plugged_in 7`, diff --git a/docs/notes/android-device-pool.md b/docs/notes/android-device-pool.md new file mode 100644 index 00000000..2466e4a2 --- /dev/null +++ b/docs/notes/android-device-pool.md @@ -0,0 +1,37 @@ +# Android device pool — 2026-10-19 + +The Android UI reviewer used to request one hard-coded device +(`{"exclusive":"phone-47241FDAS00DLK"}`), so a second UI run had to wait behind +the single Pixel even when another device was idle. Android UI stages now request +the `android-devices` pool instead; the runner grants one free member and passes +it to the stage as `resource_target`, and the stage takes its `adb -s` target +from `resource_target.metadata.adb_serial`. A stage still never chooses a device. + +## Pool members + +| member | adb serial | metadata | +| --- | --- | --- | +| `phone-47241FDAS00DLK` | `47241FDAS00DLK` | `kind=phone`, `model=Pixel_9_Pro_XL` | +| `emulator-Pipelines_Fold_A` | `emulator-5554` | `kind=emulator`, `avd=Pipelines_Fold_A` | + +The emulator is a single managed **foldable** AVD (`Pipelines_Fold_A`, unfolded +built-in display 2076x2152, cover display 1080x2424), started by the operator. It +is the only emulator in scope: ad-hoc emulators are still not started per task. + +The operator's **Pixel 10 Pro Fold** (`58281FDCG000JF`) is delivery-only and is +deliberately not a pool member — never a test target. + +## Rule reconciliation + +`android/AGENTS.md` previously said "never start or use an emulator" and pinned +the Pixel as the only device. That rule is replaced by the pool above so the map, +the runner resource declaration and the live device set agree; the safety rules +(UI-reviewer-only device work, lease-scoped fixtures, settings/build restoration, +fail-closed cleanup) are unchanged. + +## Scope + +This note, the map update and the pool declaration are configuration and +documentation only. No device probing, health check or autostart is added: the +emulator must already be running and the pool declaration is a static list, so an +offline member is simply not grantable until it is running again.