Merge commit 'ad064754873b463c7168742a4b30513986ce4ca8' into pipelines/run-20261112-1043-new-background-tasks-indicator-in-the-co-b095
This commit is contained in:
@@ -0,0 +1,73 @@
|
||||
# Rail top strip and empty top-right island
|
||||
|
||||
Two shell chrome defects on the wide layout (run 20261112-1022).
|
||||
|
||||
## Causes
|
||||
|
||||
- **White strip above the rail (96x8 at y=0).** On a wide window
|
||||
`WindowMargins` adds `wideExtraTop` (16 - 8 = 8 px) to `MediaQuery` top
|
||||
padding. `ShellNavigationRail` pads its rail by that top inset with a plain
|
||||
`Padding`, so the 8 px above the rail's Material surface was never painted
|
||||
and showed the canvas behind it (white in both themes).
|
||||
- **Empty circular pill (top right of Search and Settings).**
|
||||
`pipelines_app.dart` put `WindowsMenuButton` in `barActions` on every tab.
|
||||
The button returns `SizedBox.shrink()` with no open window, but
|
||||
`SegmentedBar` counted it as an action, so the trailing island was drawn
|
||||
around nothing.
|
||||
|
||||
## Changes (app/)
|
||||
|
||||
- `lib/shell/navigation_rail.dart`: the rail is wrapped in a `ColoredBox`
|
||||
(key `shell.navigation-rail.surface`) in the theme surface, and the
|
||||
`NavigationRail` gets the same `backgroundColor`. The top inset still moves
|
||||
the rail's content down; the inset itself is painted.
|
||||
- `lib/shell/windows/windows_menu_button.dart`: new static
|
||||
`WindowsMenuButton.hasWindows(manager)`, the single predicate for "a window
|
||||
is listed".
|
||||
- `lib/shell/adaptive_shell.dart`: new optional `windowManager` parameter.
|
||||
The shell adds the Windows button to the bar's actions only when
|
||||
`hasWindows` is true, and merges the manager into the top bar's listenable
|
||||
so the island appears and disappears with windows.
|
||||
- `lib/application/pipelines_app.dart`: the Windows button is no longer in
|
||||
`barActions`; `windowManager: _windows` is passed to the shell instead.
|
||||
|
||||
## Tests (focused, run through tool/memwatch/full.sh)
|
||||
|
||||
Paths: `test/shell/navigation_rail_surface_test.dart`,
|
||||
`test/shell/shell_bar_empty_actions_test.dart`,
|
||||
`test/shell/navigation_rail_test.dart` (existing, affected by the rail
|
||||
change), `test/shell/windows/window_conveniences_test.dart` (existing, uses
|
||||
`WindowsMenuButton` directly).
|
||||
|
||||
- Result: `PASS: 28 passed, 0 failed, 0 skipped; peak 1128 MB; 4s; exit 0`.
|
||||
- Rail surface, light and dark: the cover is at y=0, its colour equals the
|
||||
theme surface, the rail's background equals it, the rail content starts at
|
||||
the 8 px inset, and the strip above it is inside the cover.
|
||||
- Action island: Search, Settings and Pipelines at 1000 px and 430 px draw no
|
||||
`segmented.actions` island with no window; a shell with no window manager
|
||||
draws none; the Windows button is the island only while a window is open
|
||||
and goes away when it closes.
|
||||
|
||||
`tool/analyze.sh`: clean, exit 0.
|
||||
|
||||
Not run: the land gate and the full app suite (owned by the gate stage).
|
||||
Pre-existing failures listed in the memory note were not checked here.
|
||||
|
||||
## Affected UI states (for ui-review to capture)
|
||||
|
||||
- Wide window (1600x1000), light and dark: rail top (should now be the
|
||||
surface colour, not white), on every tab and on Settings.
|
||||
- Wide and narrow (430x900), Search and Settings: no empty pill at top right.
|
||||
- Wide window with one or more floating windows open: the Windows button is
|
||||
shown in the top-right island.
|
||||
|
||||
Before-captures exist in `/tmp/ui-review/` (`base-dark-1600x1000/12-settings.png`,
|
||||
`base-light-430x900/11-search.png`, and others). No after-captures were
|
||||
taken in this stage, per the stage rules; ui-review owns capture.
|
||||
|
||||
## Limitations
|
||||
|
||||
- The "rail top colour equals rail surface" check is a widget-tree check
|
||||
(colour and rect), not a pixel read from a rendered frame.
|
||||
- `WindowMargins` (the source of the 8 px) is untouched; the fix is at the
|
||||
rail, so the rail's content position is unchanged.
|
||||
@@ -0,0 +1,72 @@
|
||||
# Settings destination: Back only when pushed; one Settings entry per screen
|
||||
|
||||
Run 20261112-1022 (stage 01-implement). Not committed.
|
||||
|
||||
## Rule
|
||||
|
||||
- Settings opened from a shell control (rail item, phone bar item) is a
|
||||
destination: no Back arrow. The Pipelines item leaves it for the Pipelines body.
|
||||
- Settings opened any other way (a first load / deep link to `/settings`, a route
|
||||
change that is not a shell control, the Pipelines gear) is a pushed page: Back
|
||||
returns to Pipelines.
|
||||
- The Pipelines bar's gear is kept only where the floating tab bar is the shell's
|
||||
sole navigation (window width at least 600 and below the rail's 697; see
|
||||
`showsFloatingTabBarOnly`). There the floating bar lists tabs only, so the gear
|
||||
is the one Settings entry. The phone bar and the rail both offer Settings, so the
|
||||
gear is gone there.
|
||||
|
||||
## Changed paths (app/)
|
||||
|
||||
- `lib/shell/adaptive_shell.dart`: `_navigatingTo` / `_settingsPushed`; `_noteShown`
|
||||
is called on a shown-destination change; Back is built only when Settings is
|
||||
pushed.
|
||||
- `lib/shell/navigation_rail.dart`: `showsFloatingTabBarOnly(context)`.
|
||||
- `lib/shell/destination.dart`: doc comment only.
|
||||
- `lib/features/pipelines/screen.dart`: the bar's gear is shown only when
|
||||
`showsFloatingTabBarOnly`; the rail check is gone. The non-shell paths keep the gear.
|
||||
- `lib/application/pipelines_app.dart`: `_selectDestination` leaves Settings for the
|
||||
Pipelines body (`_bodyRoutes`) instead of re-selecting the Settings route filed
|
||||
under the Pipelines tab (the nav-only Settings has no Back, so without this the
|
||||
Pipelines item would trap the user on Settings).
|
||||
- Tests, new: `test/shell/settings_back_test.dart` (nav selection has no Back; route
|
||||
push has Back and returns; first load has Back; nav after pushed clears Back);
|
||||
`test/features/pipelines/pipelines_settings_gear_test.dart` (phone and rail: no
|
||||
gear; floating band: gear present and its handler opens Settings).
|
||||
- Tests, changed: `test/application/settings_page_test.dart`,
|
||||
`test/application/tab_location_navigation_test.dart`,
|
||||
`test/application/settings_registration_test.dart`,
|
||||
`test/shell/navigation_rail_test.dart`. They now tap the nav item instead of the gear
|
||||
and expect no Back on nav-opened Settings.
|
||||
|
||||
## Focused results (memwatch, from app/)
|
||||
|
||||
- New shell + gear tests and shell/rail/bar files: 54 passed, 0 failed.
|
||||
(`settings_back_test`, `pipelines_settings_gear_test`, `navigation_rail_test`,
|
||||
`shell_bar_test`, `tab_history_back_test`, `shell_navigation_bar_test`,
|
||||
`split_destination_bar_test`, `pipelines_screen_filter_test`)
|
||||
- Final run over all affected files (12 paths): 60 passed, 7 failed. The 7 are all
|
||||
app-level tests that fail on HEAD for the same reason (see below). None is new.
|
||||
- `settings_page_test`: "390 ... no gear ..." and "1200 ... rail ..."
|
||||
- `tab_location_navigation_test`: "Settings is retained ...", "a delayed read ...",
|
||||
"an explicit root URL ...", "Settings does not clear ..."
|
||||
- `settings_registration_test`: "Settings shares socket and one native bar"
|
||||
- Baseline check: a copy of app/ with HEAD's versions of the edited files fails the
|
||||
same tests in the same way (`Expected: '/settings' Actual: '/pipelines'` after a
|
||||
nav tap, and `Found 0 widgets with key 'segmented.more'` for the gear at 390).
|
||||
`templates_wiring_test` passes on both.
|
||||
- `tool/analyze.sh`: clean (0 errors, 0 warnings, 0 infos).
|
||||
|
||||
## Limitations
|
||||
|
||||
- App-level Settings navigation is not verified by these tests: a tap on the Settings
|
||||
nav item does not change the route in this harness, on HEAD or on this change. The
|
||||
behaviour is covered at shell level (`settings_back_test`) and by the gear test.
|
||||
- System Back on a nav-opened Settings still closes to Pipelines (the shell's
|
||||
PopScope is unchanged).
|
||||
- The mid-width band keeps the gear by design (the floating bar has no Settings
|
||||
entry). Adding Settings to the floating bar would remove it; not done here.
|
||||
- Not built or captured here (ui-review owns that). States to re-capture:
|
||||
- `base-light-430x900/12-settings.png` and `circle/01-hover.png`: Settings from the
|
||||
nav has no Back arrow.
|
||||
- `base-light-430x900/01-pipelines.png`: no Settings gear in the Pipelines header.
|
||||
- A width between 600 and 696: the gear stays, and it opens Settings with Back.
|
||||
Reference in New Issue
Block a user