Merge branch 'main' into web-runs-home
# Conflicts: # web/src/app.js # web/styles.css # web/test/ui-smoke.mjs
This commit is contained in:
+336
-39
@@ -4,6 +4,25 @@
|
||||
import { PipelinesClient } from "./client.js";
|
||||
import { PipelinesRepository } from "./repository.js";
|
||||
import { validateServerUrl, resolveArtifactUrl } from "./serverUrl.js";
|
||||
import {
|
||||
PIPELINE_SORTS,
|
||||
PIPELINE_DETAIL_TABS,
|
||||
RUN_PRESENCES,
|
||||
RUN_STATUS_FILTERS,
|
||||
EMPTY_PIPELINE_FILTERS,
|
||||
filterPipelines,
|
||||
graphNote,
|
||||
latestRunByPipeline,
|
||||
pipelineFilterCount,
|
||||
pipelineListEmptyState,
|
||||
pipelineSubtitle,
|
||||
pipelineUpdatedLine,
|
||||
runBadge,
|
||||
runBadgeMetaLine,
|
||||
sortPipelines,
|
||||
summaryFields,
|
||||
versionRow,
|
||||
} from "./pipelines.js";
|
||||
import {
|
||||
RUN_STATES,
|
||||
RUN_TIME_RANGES,
|
||||
@@ -63,6 +82,16 @@ const state = {
|
||||
runDetail: null,
|
||||
selectedPipelineId: null,
|
||||
selectedRunId: null,
|
||||
// Pipelines view: client-side filter/sort/detail-tab state. The run history is
|
||||
// fetched alongside the pipelines so the list can show each pipeline's last
|
||||
// run; runsLoaded tells a genuinely empty history apart from one not in hand.
|
||||
pipelineFilters: { ...EMPTY_PIPELINE_FILTERS },
|
||||
pipelineSort: "server_order",
|
||||
pipelineMenu: null,
|
||||
pipelineTab: "summary",
|
||||
versionsExpanded: false,
|
||||
pipelinesLoaded: false,
|
||||
runsLoaded: false,
|
||||
loading: false,
|
||||
error: "",
|
||||
runFilters: defaultRunFilters(),
|
||||
@@ -231,28 +260,234 @@ function tabButton(view, label) {
|
||||
|
||||
function renderPipelineList() {
|
||||
const list = h("div", { class: "list" });
|
||||
if (state.loading && !state.pipelines.length) {
|
||||
list.append(h("div", { class: "muted pad", text: "Loading…" }));
|
||||
return list;
|
||||
}
|
||||
if (!state.pipelines.length) {
|
||||
list.append(h("div", { class: "muted pad", text: "No pipelines." }));
|
||||
return list;
|
||||
}
|
||||
for (const p of state.pipelines) {
|
||||
list.append(
|
||||
list.append(renderPipelineControls());
|
||||
const rows = h("div", { id: "pipelineRows" });
|
||||
fillPipelineRows(rows);
|
||||
list.append(rows);
|
||||
return list;
|
||||
}
|
||||
|
||||
/**
|
||||
* The list's filter + sort toolbar and (when open) the matching menu panel. The
|
||||
* rows themselves live in the separate `#pipelineRows` container so a keystroke
|
||||
* in the name filter can refresh just the rows without rebuilding (and so
|
||||
* blurring) the input the operator is typing in.
|
||||
*/
|
||||
function renderPipelineControls() {
|
||||
const filters = state.pipelineFilters;
|
||||
const count = pipelineFilterCount(filters);
|
||||
const panel = state.pipelineMenu;
|
||||
const controls = h(
|
||||
"div",
|
||||
{ class: "list-controls" },
|
||||
h(
|
||||
"div",
|
||||
{ class: "list-toolbar" },
|
||||
h(
|
||||
"button",
|
||||
{
|
||||
class: `row${state.selectedPipelineId === p.id ? " selected" : ""}`,
|
||||
onclick: () => selectPipeline(p),
|
||||
id: "filterToggle",
|
||||
class: `control${panel === "filter" ? " active" : ""}`,
|
||||
onclick: () => {
|
||||
state.pipelineMenu = panel === "filter" ? null : "filter";
|
||||
renderContent();
|
||||
},
|
||||
},
|
||||
h("span", { class: "row-title", text: p.name || `pipeline ${p.id}` }),
|
||||
h("span", { class: "row-meta", text: `#${p.id} · v${p.version} · ${p.stages} stage${p.stages === 1 ? "" : "s"}` }),
|
||||
h("span", { text: "Filter" }),
|
||||
h("span", { id: "filterCount", class: "count", text: count ? ` (${count})` : "" }),
|
||||
),
|
||||
h("button", {
|
||||
id: "sortToggle",
|
||||
class: `control${panel === "sort" ? " active" : ""}`,
|
||||
text: `Sort: ${pipelineSortLabel(state.pipelineSort)}`,
|
||||
onclick: () => {
|
||||
state.pipelineMenu = panel === "sort" ? null : "sort";
|
||||
renderContent();
|
||||
},
|
||||
}),
|
||||
h("button", {
|
||||
id: "clearFilters",
|
||||
class: "ghost clear",
|
||||
text: "Clear filters",
|
||||
hidden: count === 0,
|
||||
onclick: clearPipelineFilters,
|
||||
}),
|
||||
),
|
||||
);
|
||||
if (panel === "filter") controls.append(renderFilterPanel());
|
||||
if (panel === "sort") controls.append(renderSortPanel());
|
||||
return controls;
|
||||
}
|
||||
|
||||
function renderFilterPanel() {
|
||||
const filters = state.pipelineFilters;
|
||||
const panel = h("div", { class: "menu-panel filter-panel" });
|
||||
panel.append(h("div", { class: "filter-section", text: "Name" }));
|
||||
panel.append(
|
||||
h(
|
||||
"label",
|
||||
{ class: "filter-field" },
|
||||
h("span", { class: "filter-field-label", text: "Pipeline name contains" }),
|
||||
h("input", {
|
||||
id: "pipelineNameFilter",
|
||||
type: "text",
|
||||
value: filters.name,
|
||||
spellcheck: "false",
|
||||
oninput: (e) => {
|
||||
state.pipelineFilters = { ...state.pipelineFilters, name: e.target.value };
|
||||
// Targeted refresh: the input keeps focus and its value while the
|
||||
// list narrows behind it.
|
||||
refreshPipelineRows();
|
||||
},
|
||||
}),
|
||||
),
|
||||
);
|
||||
panel.append(h("div", { class: "filter-section", text: "Runs" }));
|
||||
for (const presence of RUN_PRESENCES) {
|
||||
panel.append(
|
||||
h(
|
||||
"label",
|
||||
{ class: "filter-item" },
|
||||
h("input", {
|
||||
type: "radio",
|
||||
name: "runPresence",
|
||||
checked: filters.presence === presence.key,
|
||||
onchange: () => {
|
||||
state.pipelineFilters = { ...state.pipelineFilters, presence: presence.key };
|
||||
renderContent();
|
||||
},
|
||||
}),
|
||||
h("span", { text: presence.label }),
|
||||
),
|
||||
);
|
||||
}
|
||||
return list;
|
||||
panel.append(h("div", { class: "filter-section", text: "Last run status" }));
|
||||
for (const status of RUN_STATUS_FILTERS) {
|
||||
panel.append(
|
||||
h(
|
||||
"label",
|
||||
{ class: "filter-item" },
|
||||
h("input", {
|
||||
id: `status-${status}`,
|
||||
type: "checkbox",
|
||||
checked: filters.lastRunStatuses.includes(status),
|
||||
onchange: (e) => {
|
||||
const next = e.target.checked
|
||||
? [...state.pipelineFilters.lastRunStatuses, status]
|
||||
: state.pipelineFilters.lastRunStatuses.filter((s) => s !== status);
|
||||
state.pipelineFilters = { ...state.pipelineFilters, lastRunStatuses: next };
|
||||
renderContent();
|
||||
},
|
||||
}),
|
||||
h("span", { text: status }),
|
||||
),
|
||||
);
|
||||
}
|
||||
panel.append(
|
||||
h("div", { class: "filter-actions" }, h("button", { class: "ghost", text: "Clear filters", onclick: clearPipelineFilters })),
|
||||
);
|
||||
return panel;
|
||||
}
|
||||
|
||||
function renderSortPanel() {
|
||||
const panel = h("div", { class: "menu-panel sort-panel" });
|
||||
for (const option of PIPELINE_SORTS) {
|
||||
panel.append(
|
||||
h("button", {
|
||||
class: `sort-option${state.pipelineSort === option.key ? " active" : ""}`,
|
||||
text: option.label,
|
||||
onclick: () => {
|
||||
state.pipelineSort = option.key;
|
||||
state.pipelineMenu = null;
|
||||
renderContent();
|
||||
},
|
||||
}),
|
||||
);
|
||||
}
|
||||
panel.append(
|
||||
h(
|
||||
"div",
|
||||
{ class: "filter-actions" },
|
||||
h("button", {
|
||||
class: "ghost",
|
||||
text: "Reset",
|
||||
onclick: () => {
|
||||
state.pipelineSort = "server_order";
|
||||
state.pipelineMenu = null;
|
||||
renderContent();
|
||||
},
|
||||
}),
|
||||
),
|
||||
);
|
||||
return panel;
|
||||
}
|
||||
|
||||
/** Re-renders the rows and the toolbar's active-filter badge after a filter change. */
|
||||
function refreshPipelineRows() {
|
||||
const rows = document.getElementById("pipelineRows");
|
||||
if (rows) fillPipelineRows(rows);
|
||||
const count = pipelineFilterCount(state.pipelineFilters);
|
||||
const badge = document.getElementById("filterCount");
|
||||
if (badge) badge.textContent = count ? ` (${count})` : "";
|
||||
const clear = document.getElementById("clearFilters");
|
||||
if (clear) clear.hidden = count === 0;
|
||||
}
|
||||
|
||||
/** Sorts, filters and renders the pipeline rows (or the matching empty state) into `rowsEl`. */
|
||||
function fillPipelineRows(rowsEl) {
|
||||
const latestRuns = latestRunByPipeline(state.runs);
|
||||
const runsKnown = state.runsLoaded;
|
||||
const now = Date.now();
|
||||
const nodes = [];
|
||||
if (state.loading && !state.pipelines.length) {
|
||||
nodes.push(h("div", { class: "muted pad", text: "Loading pipelines…" }));
|
||||
} else if (!state.pipelinesLoaded) {
|
||||
nodes.push(h("div", { class: "muted pad", text: "Connect to the server to load pipelines." }));
|
||||
} else {
|
||||
const sorted = sortPipelines(state.pipelines, state.pipelineSort, latestRuns);
|
||||
const items = filterPipelines(sorted, state.pipelineFilters, latestRuns, runsKnown);
|
||||
if (items.length) {
|
||||
for (const pipeline of items) nodes.push(renderPipelineRow(pipeline, latestRuns, runsKnown, now));
|
||||
} else {
|
||||
const empty = pipelineListEmptyState(state.pipelines, items, state.pipelineFilters);
|
||||
const box = h("div", { class: "empty pad" }, h("div", { class: "muted", text: empty.message }));
|
||||
if (empty.clearAction) {
|
||||
box.append(h("button", { class: "ghost", text: empty.clearAction, onclick: clearPipelineFilters }));
|
||||
}
|
||||
nodes.push(box);
|
||||
}
|
||||
}
|
||||
rowsEl.replaceChildren(...nodes);
|
||||
}
|
||||
|
||||
function renderPipelineRow(pipeline, latestRuns, runsKnown, now) {
|
||||
const children = [
|
||||
h("span", { class: "row-title", text: pipeline.name || `pipeline ${pipeline.id}` }),
|
||||
h("span", { class: "row-meta", text: pipelineSubtitle(pipeline) }),
|
||||
];
|
||||
const updated = pipelineUpdatedLine(pipeline);
|
||||
if (updated) children.push(h("span", { class: "row-meta", text: updated }));
|
||||
if (runsKnown) {
|
||||
const run = latestRuns.get(pipeline.id);
|
||||
if (!run) {
|
||||
children.push(h("span", { class: "row-meta muted", text: "no runs recorded" }));
|
||||
} else {
|
||||
const badge = runBadge(run, now);
|
||||
children.push(
|
||||
h(
|
||||
"span",
|
||||
{ class: "row-run" },
|
||||
h("span", { class: `chip chip-${badge.state}`, text: badge.state }),
|
||||
h("span", { class: "row-meta", text: runBadgeMetaLine(badge) }),
|
||||
),
|
||||
);
|
||||
}
|
||||
}
|
||||
return h(
|
||||
"button",
|
||||
{ class: `row${state.selectedPipelineId === pipeline.id ? " selected" : ""}`, onclick: () => selectPipeline(pipeline) },
|
||||
...children,
|
||||
);
|
||||
}
|
||||
|
||||
function renderPipelineDetail() {
|
||||
@@ -262,40 +497,91 @@ function renderPipelineDetail() {
|
||||
pane.append(h("div", { class: "muted pad", text: "Select a pipeline." }));
|
||||
return pane;
|
||||
}
|
||||
pane.append(h("h2", { text: d.name || `pipeline ${d.id}` }));
|
||||
pane.append(
|
||||
h("h2", { text: d.name || `pipeline ${d.id}` }),
|
||||
h(
|
||||
"div",
|
||||
{ class: "kv" },
|
||||
kv("ID / version", `#${d.id} · v${d.version}`),
|
||||
kv("Stages", String(d.stages ?? (d.graph?.stages?.length ?? 0))),
|
||||
kv("Content hash", d.content_hash || "—"),
|
||||
kv("Created", fmtTime(d.created_at)),
|
||||
kv("Updated", fmtTime(d.updated_at)),
|
||||
kv("Latest version", d.latest_version ? String(d.latest_version) : "—"),
|
||||
{ class: "detail-tabs" },
|
||||
...PIPELINE_DETAIL_TABS.map((tab) =>
|
||||
h("button", {
|
||||
class: `detail-tab${state.pipelineTab === tab.key ? " active" : ""}`,
|
||||
text: tab.label,
|
||||
onclick: () => {
|
||||
state.pipelineTab = tab.key;
|
||||
renderContent();
|
||||
},
|
||||
}),
|
||||
),
|
||||
),
|
||||
);
|
||||
const stages = d.graph?.stages ?? [];
|
||||
if (stages.length) {
|
||||
pane.append(h("h3", { text: "Stages" }));
|
||||
const ul = h("ul", { class: "stages" });
|
||||
for (const s of stages) {
|
||||
const outcomes = Object.keys(s.edges ?? {}).join(", ");
|
||||
ul.append(
|
||||
h(
|
||||
"li",
|
||||
{},
|
||||
h("code", { text: s.key }),
|
||||
s.type ? h("span", { class: "chip", text: s.type }) : null,
|
||||
outcomes ? h("span", { class: "muted", text: `→ ${outcomes}` }) : null,
|
||||
),
|
||||
);
|
||||
if (state.pipelineTab === "graph") {
|
||||
pane.append(h("p", { class: "graph-note muted", text: graphNote() }));
|
||||
return pane;
|
||||
}
|
||||
if (state.pipelineTab === "source") {
|
||||
pane.append(h("pre", { class: "source-code" }, h("code", { text: d.source || "" })));
|
||||
return pane;
|
||||
}
|
||||
pane.append(h("div", { class: "detail-subtitle muted", text: pipelineSubtitle({ ...d, stages: d.graph?.stages?.length ?? d.stages }) }));
|
||||
const rows = h("div", { class: "kv" });
|
||||
for (const field of summaryFields(d)) {
|
||||
rows.append(
|
||||
h(
|
||||
"div",
|
||||
{ class: "kv-row" },
|
||||
h("span", { class: "kv-key", text: field.key }),
|
||||
h("span", { class: `kv-val${field.monospace ? " monospace" : ""}`, text: field.value }),
|
||||
),
|
||||
);
|
||||
}
|
||||
pane.append(rows);
|
||||
pane.append(
|
||||
h(
|
||||
"button",
|
||||
{
|
||||
class: "section-toggle",
|
||||
onclick: () => {
|
||||
state.versionsExpanded = !state.versionsExpanded;
|
||||
renderContent();
|
||||
},
|
||||
},
|
||||
h("span", { class: "chevron", text: state.versionsExpanded ? "\u25be" : "\u25b8" }),
|
||||
h("span", { text: "Versions" }),
|
||||
),
|
||||
);
|
||||
if (state.versionsExpanded) {
|
||||
const versions = d.versions ?? [];
|
||||
const body = h("div", { class: "section-body versions-list" });
|
||||
if (!versions.length) {
|
||||
body.append(h("div", { class: "muted", text: "No versions recorded." }));
|
||||
} else {
|
||||
for (const version of versions) {
|
||||
const row = versionRow(version);
|
||||
body.append(
|
||||
h(
|
||||
"div",
|
||||
{ class: "version-row" },
|
||||
h("span", { class: "version-title", text: row.versionLabel }),
|
||||
h("span", { class: "muted", text: row.stagesText }),
|
||||
row.createdText ? h("span", { class: "muted", text: row.createdText }) : null,
|
||||
),
|
||||
);
|
||||
}
|
||||
}
|
||||
pane.append(ul);
|
||||
pane.append(body);
|
||||
}
|
||||
return pane;
|
||||
}
|
||||
|
||||
function pipelineSortLabel(key) {
|
||||
return (PIPELINE_SORTS.find((option) => option.key === key) ?? PIPELINE_SORTS[0]).label;
|
||||
}
|
||||
|
||||
function clearPipelineFilters() {
|
||||
state.pipelineFilters = { ...EMPTY_PIPELINE_FILTERS };
|
||||
renderContent();
|
||||
}
|
||||
|
||||
function renderRunList() {
|
||||
const pane = h("div", { class: "list runs" });
|
||||
pane.append(renderRunToolbar());
|
||||
@@ -725,10 +1011,19 @@ async function loadCurrentView(force = false) {
|
||||
try {
|
||||
if (state.view === "pipelines") {
|
||||
state.pipelines = await repo.listPipelines();
|
||||
state.pipelinesLoaded = true;
|
||||
// The last-run line joins list_runs onto the pipelines, so the history is
|
||||
// fetched alongside them; runsLoaded distinguishes a genuinely empty
|
||||
// history from one that has not arrived yet.
|
||||
const { runs, usage } = await repo.listRuns();
|
||||
state.runs = runs;
|
||||
if (usage) state.usage = usage;
|
||||
state.runsLoaded = true;
|
||||
} else {
|
||||
const { runs, usage } = await repo.listRuns();
|
||||
state.runs = runs;
|
||||
state.usage = usage;
|
||||
state.runsLoaded = true;
|
||||
}
|
||||
state.loading = false;
|
||||
renderContent();
|
||||
@@ -744,6 +1039,8 @@ async function loadCurrentView(force = false) {
|
||||
async function selectPipeline(summary) {
|
||||
state.selectedPipelineId = summary.id;
|
||||
state.pipelineDetail = null;
|
||||
state.pipelineTab = "summary";
|
||||
state.versionsExpanded = false;
|
||||
renderContent();
|
||||
try {
|
||||
state.pipelineDetail = await repo.getPipeline(summary.id, summary.version);
|
||||
|
||||
Reference in New Issue
Block a user