Remove Cupertino onboarding branches
Keep onboarding on the app's Material-only path and remove unreachable Cupertino widgets and host-specific tests. Preserve the reviewed Material behavior while documenting the focused checks and verification limits.
This commit is contained in:
@@ -0,0 +1,41 @@
|
||||
# Onboarding: Material-only
|
||||
|
||||
Removed the Cupertino branch from `lib/features/onboarding`:
|
||||
|
||||
- `onboarding_flow.dart`: Material `Scaffold`, `TextField` (outline border),
|
||||
`FilledButton` with a small `CircularProgressIndicator`, `TextButton` for
|
||||
"Change server", theme error colour and `headlineSmall` title. Dropped the
|
||||
unused `flutter/cupertino.dart` and `ui/adaptive/host.dart` imports.
|
||||
- `discovery/discovery_panel.dart`: `OutlinedButton.icon` scan action, Material
|
||||
busy indicator and theme error colour.
|
||||
- `discovery/discovered_server_row.dart`: Material `ListTile`,
|
||||
`CheckboxListTile` and `FilledButton`; Cupertino list tiles, chevrons,
|
||||
checkbox and activity indicators removed.
|
||||
|
||||
Public constructors (`OnboardingFlow`, `DiscoveryPanel`, `DiscoveredServerRow`)
|
||||
are unchanged; no `cupertino` parameters existed there. Private helpers lost
|
||||
their now-unused `cupertino`/`context` arguments. No Cupertino icons or colours
|
||||
are kept: the Material path uses none of them.
|
||||
|
||||
## Affected UI states
|
||||
|
||||
First run server entry, machine name, discovery idle/scanning/empty/error, the
|
||||
discovered single-route row, the multi-route checklist and "Use <name>", the
|
||||
sign-in step, probe error text and the "Change server" action. All render the
|
||||
same Material widgets as before on the Material path; no layout or copy changed.
|
||||
|
||||
## Checks
|
||||
|
||||
- `tool/memwatch/full.sh 'test/features/onboarding '` — PASS, 24 tests, exit 0.
|
||||
- `tool/memwatch/full.sh 'test/features/settings/saved_server_discovery_test.dart
|
||||
test/application/pipelines_root_test.dart
|
||||
test/application/zero_server_recovery_test.dart'` — PASS, 7 tests, exit 0
|
||||
(other users of `OnboardingFlow`/`DiscoveryPanel`).
|
||||
- `tool/analyze.sh` — clean, exit 0.
|
||||
- `grep -rn 'Cupertino\|cupertino' lib/features/onboarding test/features/onboarding`
|
||||
— no matches.
|
||||
|
||||
Test change: `discovery_panel_test.dart` lost its `CupertinoApp` host variant and
|
||||
the `CupertinoListTile` expectation; the `host` helper now always builds a
|
||||
`MaterialApp`. No Material test expectation changed. No UI capture was taken in
|
||||
this stage.
|
||||
Reference in New Issue
Block a user