Merge commit 'a823a6e8a398ab1327ff22f9c393d970e52a6f4b' into pipelines/run-20261111-1947-use-desktop-dialogs-for-remaining-sheets-4d07

This commit is contained in:
2026-11-11 20:47:24 +00:00
87 changed files with 707 additions and 833 deletions
+14
View File
@@ -21,3 +21,17 @@ Evidence:
No browser fixture was run in this implementation stage; browser terminal
fixture support and full-app rendered evidence remain for the appropriate
review stage.
## Manager browser integration
Verified the merged full-app fixture with
`chats=2&header=1&terminals=1&terminal=float` at 1800×1000. Floated the second
chat, clicked the exposed Terminal content to focus it, then pressed Ctrl+Y.
Before typing, the browser's active element was the chat's `TEXTAREA`, labelled
`Work on demo`. Typing `Typed immediately after Ctrl+Y` appeared in that chat
without another click; the chat was visibly above Terminal.
Inspected `06-typed.png`. Capture reports, semantics snapshots and screenshots
are retained under run 369's `public/manager-integration-ctrl-y/`. This verifies
the actual Terminal/Chat widgets and browser focus handoff with a fake gateway,
not a live shell backend or native device installation.
+26
View File
@@ -0,0 +1,26 @@
# Keyboard shortcuts help
Added a Settings → Tools → Help entry that opens a root-layered, bounded Material help
surface on desktop and the existing adaptive sheet on narrow layouts. The
registry reuses the terminal, floating-chat, Center Stage and window-cycle
label helpers, and records browser caveats for shortcuts that may be reserved.
Search and its tooltip share platform-aware labels for Option/Alt+/, macOS
Cmd+/, and Ctrl+/. The separately reviewed Search handler change (run 367)
is integrated into this candidate before landing the help.
Floating-chat help describes the new Terminal-to-composer focus handoff
instead of the obsolete macOS shell-yank exception.
Chat list numbering likewise uses Command only on macOS, matching the shell
rule on iOS and other platforms.
Focused verification:
- `tool/memwatch/full.sh 'test/features/settings/keyboard_shortcuts_help_test.dart test/features/settings/settings_screen_test.dart'`
— 15 passed, 0 failed.
- `tool/analyze.sh` — clean.
Browser/full-app capture was not run in this implementation stage; ui-review
should verify desktop light/dark, scaled text, keyboard traversal, and phone
constraints with the full-app fixture.
Manager merged-tree verification after Search integration: 24 focused help,
Settings, Search-shortcut and chat-keyboard tests passed; analysis was clean.
@@ -0,0 +1,14 @@
# Material chat Cupertino cleanup
- Removed dead Material-only conversation helpers and the unused Cupertino icon
metadata from the thread header; `ChatBarAction.cupertinoIcon` remains an
optional ignored compatibility parameter for callers in other chat lanes.
- Removed unused `cupertino` arguments from transcript bubbles and copy-button
construction while preserving the existing Material widgets and behavior.
- Focused UI states covered: transcript bubble color rendering, message layout,
and chat thread view/header behavior.
- Checks: `tool/memwatch/full.sh 'test/features/chat/ui/transcript/chat_bubble_color_test.dart test/features/chat/ui/transcript/chat_message_view_test.dart test/features/chat/conversation/chat_thread_view_test.dart'`
— PASS (24 passed); `tool/analyze.sh` — clean.
- No visual redesign or browser/device capture was needed: the edits remove
unused parameters and alternate icon metadata without changing rendered
Material controls, layout, focus, scrolling, or navigation behavior.
+7
View File
@@ -0,0 +1,7 @@
# Material chat and graph probes
- Removed Cupertino imports, host branches, and local style flags from the assigned chat and graph/stage-definition Dart probes.
- Preserved Material scaffolds, dark/light themes, text scaling, fixture data, callbacks, and browser interaction states.
- Focused watchdog tests: 39 passed across graph widgets and chat thread/composer coverage.
- `tool/analyze.sh`: clean, 0 errors, 0 warnings.
- Node syntax checks passed for the corresponding probe drivers. No browser capture was run; this cleanup does not alter intended Material rendering.
@@ -0,0 +1,14 @@
# Material-only terminal and chat shell cleanup
- Removed Cupertino icon imports, alternate icon metadata, and ignored host
flags from terminal and chat-shell widgets while retaining the existing
Material controls and terminal keyboard/focus/resize behavior.
- `TerminalSurface.cupertino` and `TerminalToggleButton.cupertino` remain
optional ignored compatibility parameters for the application lane's
existing `app_terminals.dart` callers; they have no rendering effect and are
ready for removal after those callers migrate.
- Focused check: `tool/memwatch/full.sh` with the nine terminal/chat-shell test
paths, 52 passed, 0 failed, 0 skipped.
- Analysis: `tool/analyze.sh` clean.
- No visual redesign or capture was performed; the changed widgets continue to
use the same Material palette, controls, layout, and semantics.
@@ -0,0 +1,25 @@
# Material startup and shell cleanup
- Consolidated application startup, onboarding, routing pages, connection
states, Search, Templates, Schedules, and the navigation shell onto Material
composition on every platform.
- Kept legacy `cupertino` constructor arguments optional/ignored where callers
still pass them; no Cupertino widgets or platform host selection remain in
the changed application paths.
- Focused watchdog command ran the mirrored application/routing/navigation and
shell tests: 38 passed and 7 failed. The seven failures were teardown
assertions for the pre-existing 15-second `LaunchUpdateChecker` timer in
`PipelinesApp`; no Material cleanup assertion failed.
- `tool/analyze.sh`: clean (exit 0).
- No rendered capture was performed; this cleanup preserves the existing
Material scaffold, bars, connection states, focus, and navigation semantics.
## Manager recovery
The navigation and template-wiring fixtures were inadvertently invoking native
update plugins. They now explicitly disable updates, while dedicated startup
update tests retain and exercise the real update-check behavior.
The focused routing, app, schedules, template-wiring, split-bar, startup-update
check and startup-update-flow tests passed: 39 passed, zero failed. No production
update behavior was changed to hide the teardown failures.
+15
View File
@@ -0,0 +1,15 @@
# Open Search with Alt+/ and Command+/
- Updated `shellSearchShortcut` to accept an exact Alt+/ chord by physical
slash position, including macOS Option dead-key logical values.
- Existing Ctrl+/ and macOS Command+/ matching remains logical-slash based;
Shift and mixed/extra modifiers remain rejected.
- Search destination routing, focus, query retention, and composer drafts were
left unchanged.
- Focused checks: `tool/memwatch/full.sh 'test/shell/search_shortcuts_test.dart
test/shell/destination_shortcuts_test.dart test/shell/list_shortcuts_test.dart
test/features/chat/chat_keyboard_focus_test.dart'` — PASS (13 passed, 0
failed, 0 skipped).
- `tool/analyze.sh` — clean.
- Browser capture was not run in this implementation stage; UI review owns
full-app Alt+/ and Meta+/ interaction evidence.