Add shared live run graphs, debugging, editor choice and draft cleanup

This commit is contained in:
2026-10-09 19:17:43 +01:00
parent 9b8afc874f
commit 0f80ff4e95
33 changed files with 1162 additions and 72 deletions
+62
View File
@@ -0,0 +1,62 @@
package draft
import (
"os"
"path/filepath"
"testing"
)
func TestDeleteOnlySelectedManagedDraftAndMetadata(t *testing.T) {
t.Setenv("PIPELINES_DRAFT_DIR", t.TempDir())
a, err := Create("discard", "discard me", "other-server", true, 0)
if err != nil {
t.Fatal(err)
}
b, err := Create("keep", "keep me", "server", false, 3)
if err != nil {
t.Fatal(err)
}
if err := Delete(a.Path); err != nil {
t.Fatal(err)
}
for _, path := range []string{a.Path, a.Path + ".json"} {
if _, err := os.Stat(path); !os.IsNotExist(err) {
t.Fatal("deleted file remains", path, err)
}
}
if source, err := Read(b.Path); err != nil || source != "keep me" {
t.Fatal("unrelated draft changed", source, err)
}
items, err := List()
if err != nil || len(items) != 1 || items[0].Path != b.Path {
t.Fatal("draft list did not refresh after deletion", items, err)
}
}
func TestDeleteRejectsExternalFilesAndSymlinks(t *testing.T) {
dir := t.TempDir()
t.Setenv("PIPELINES_DRAFT_DIR", dir)
external := filepath.Join(t.TempDir(), "pipeline-external.md")
os.WriteFile(external, []byte("keep"), 0600)
os.WriteFile(external+".json", []byte("{}"), 0600)
if err := Delete(external); err == nil {
t.Fatal("external source deleted")
}
link := filepath.Join(dir, "pipeline-link.md")
if err := os.Symlink(external, link); err != nil {
t.Fatal(err)
}
os.WriteFile(link+".json", []byte("{}"), 0600)
if err := Delete(link); err == nil {
t.Fatal("symlink accepted")
}
regular := filepath.Join(dir, "pipeline-regular.md")
os.WriteFile(regular, []byte("keep"), 0600)
os.Symlink(external+".json", regular+".json")
if err := Delete(regular); err == nil {
t.Fatal("symlink metadata accepted")
}
if source, err := os.ReadFile(external); err != nil || string(source) != "keep" {
t.Fatal("symlink target changed", err)
}
}
+34
View File
@@ -8,6 +8,7 @@ import (
"os"
"path/filepath"
"sort"
"strings"
)
type Draft struct {
@@ -114,3 +115,36 @@ func List() ([]Draft, error) {
}
return items, nil
}
// Delete only a selected, managed cache draft and its sidecar. Never recurse,
// follow a file symlink, or delete an arbitrary external submission source.
func Delete(path string) error {
dir, err := Directory()
if err != nil {
return err
}
absolute, err := filepath.Abs(path)
if err != nil {
return err
}
name := filepath.Base(absolute)
if filepath.Dir(absolute) != filepath.Clean(dir) || !strings.HasPrefix(name, "pipeline-") || !strings.HasSuffix(name, ".md") {
return fmt.Errorf("only managed drafts inside %s can be deleted", dir)
}
for _, file := range []string{absolute + ".json", absolute} {
info, err := os.Lstat(file)
if os.IsNotExist(err) && file == absolute {
continue
}
if err != nil {
return err
}
if !info.Mode().IsRegular() {
return fmt.Errorf("draft and metadata must be regular files, not symlinks or directories")
}
}
if err := os.Remove(absolute); err != nil && !os.IsNotExist(err) {
return err
}
return os.Remove(absolute + ".json")
}